GetLogicalDriveStrings() problem

I have a simple program:

Code:

---

#include <windows.h>
#include <stdio.h>

void main()
{
  char cmd[50];
  GetLogicalDriveStrings(50, cmd);
  puts(cmd);
}

---

When done, it outputs:

Quote:

---

A:\

---

And that's all! But i have more logical drives!!!
Where is the problem?
Thx.

From GetLogicalDriveStrings:

Quote:

---

Originally Posted by msdn,

pBuffer
[out] Pointer to a buffer that receives a series of null-terminated strings, one for each valid drive in the system, plus with an additional null character. Each string is a device name.

---

Also, main returns int.

Ok. And if I want, for example, to show all of my logical drives, how can I do this? I mean that I don't want simply write smth like that:

Code:

---

for(int i=0; i<an_int_value; i++)
  printf("%c", cmd[i]);

---

I need smth better ;)

Code:

---

TCHAR buf[256], * pbuf = buf;
DWORD i = 0;

::GetLogicalDriveStrings(sizeof buf, buf);

while( *pbuf )
{
        // deal wit it deal wit it
        pbuf += _tcslen( pbuf ) + 1;
}

---

Thx. Now it's clear. But new problem appeared.. After I obtain list of my drives, i try to obtain list of subdirectories. I use next code:

Code:

---

char cPath[MAX_PATH];
printf("\nEnter the path  ");
gets(cPath);
hFile = FindFirstFile(cPath, &lpfd);

if(hFile == INVALID_HANDLE_VALUE)
{
  printf("\"%s\" - No such directory\n", cPath);
  main();
}
.......

---

And every time hFile == INVALID_HANDLE_VALUE, even if drive which I enter into cPath does exist.

use fgets(cPath, sizeof (cPath), stdin)
and remove '\n' from the string

it steel doesn't work... But! Smth. interesting happened: even if I call FindFirstFile like this:

Code:

---

hFile = FindFirstFile("c:\\", &lpfd);

---

It can't find that directory!

To find a diretory - you should past its name without \
like "d:\\work"

and don't call main function by yourself

ok. but if i want to see what contains my directory c:\ ?
I try to find it even like that:

Code:

---

hFile = FindFirstFile("c:", &lpfd);

---

And it steel doesn't work...

to see what is in the c: use c:\\*

Ohh! Thank so much! I forgot about asterisk (*)!! Finally it works! Thanks!

One correction:

Code:

---

void main()

---

Should be:

Code:

---

int main()

---

Quote:

---

and don't call main function by yourself

---

why? if I wnat to use recursion from the main function?

2 manutd:
I have read the faq, reffered to type of main(), and i don't see a big difference between
void main() and int main().
Can you explain?

> and i don't see a big difference between void main() and int main().
> gets(cPath);
Is that also your explanation for using gets() rather than fgets(), because you can't see the difference?

> why?
1. It's crummy to use a recursive call when all you wanted was a while loop.
2. Calling main is actually illegal in C++, and is probably illegal in C99.
3. If someone knows this about your code, they might just try a stack overflow attack to see what happens. But since you used gets(), why would they bother?

But if you just want to go your own way with the "works for me" attitude, then this isn't the place for you. We'll stop talking it you stop listening.


> if I wnat to use recursion from the main function?
So do

Code:

---

int main ( int argc, char *argv[] ) { return mymain(argc,argv); }

---

and recurse on mymain. It's no big hardship if you really want to do it.

> Can you explain?
What, didn't you read the FAQ?
What part of the FAQ is giving you trouble with this concept?

I don't want to "work for me". I just try to understand my own mystakes, and I think that this forum can help me. And, as you can see, I'm not stop to listen to you, I just give you some questions to find some answers.

Quote:

---

What part of the FAQ is giving you trouble with this concept?

---

No troubles. I just read the FAQ, and didn't find big difference beetwen void main and int main, probably it's caused by my worst english...
Anyway, thanks for your answer

The standard states that main() should return an int, so main() should return an int.

well, finally it's clear for me! standard says that - and i'll follow this rule!

Quote:

---

Originally Posted by LMZ

well, finally it's clear for me! standard says that - and i'll follow this rule!

---

main returns int in any case even if you don't put return statement in it.
when you declare function one way, and actually it is defined another way - you mess with the stack.
(You say that the main is void - notifying the compiler that the function does not put return value to the stack... Actually main puts something to the stack...)

Messing with the stack has unpredictable results.

2 vart:
Know I absolutely understood why I shouldn't use main as void. Thank you so much!