accepting +123 help

Code:

#include <stdio.h> main() { int state, n=0; char input; state=0; fputs("Enter a positive or negetive integer\n", stdout); while ( (input=getchar()) !='\n' ) { switch ( state ) { case 0 : (input=='+'||'-')?(state=2):(state=1); break; case 1 : (isdigit(input))?(state=2):(state=3); break; case 2 : (isdigit(input))?(state=2):(state=3); break; case 3 : (isdigit(input) || input=='+' || input =='-')?(state=2):(state=5); break; case 4 : (isdigit(input))?(state=2):(state=5); } } if ( state == 2 ) printf("Accepted state = A\n"); else printf("Rejected, state = R\n"); return 0; }

the above is supposed to accept positive or negative numbers...

example: +12132
or: 12345
or: -12345
or: 1

it is supposed to regect all else. including

1,111,111
+123+1
+
johnyboy
1johnyboy1
j12345

the program does everything it should except it accepts illegal characters as long as they arn't the last digit.

Code:

#include <stdio.h> main() { int state, n=0; char input; state=0; fputs("Enter a positive or negetive integer\n", stdout); while ( (input=getchar()) !='\n' ) { switch ( state ) { case 0 : (input=='+'||'-')?(state=3):((isdigit(input))?(state=1):(state=2)); break; case 1 : (isdigit(input))?(state=1):(state=2); break; case 2 : (state=2); break; case 3 : (isdigit(input))?(state=1):(state=5); } } if ( state == 1 ) printf("Accepted state = A\n"); else printf("Rejected, state = R\n"); return 0; }

the above works better... it's only problem is that it rejects any input that is only 1 character...
example: 1
or 2
or 3
or +
or -
or v

does anybody see an easy way to fix either of these programs?

Quote:

(input=='+'||'-')

This should be (input == '+' || input == '-') and it would also be better if you used if-else tags.

the compiler accepts (input=='+'||'-')... thats not the problem... and i could use if-else tags but that would be just as difficult... regaurdless thats not whats wrong with the program...

Yes it is the problem. Here's why:

In C, true is non-zero. The hyphen character can also be a number: 0x2D. Since this is non-zero you end up with a false positive here:

(input == '+' || '-')

Follow OnionKnight's advice.

Quote:

Originally Posted by peanut

the compiler accepts (input=='+'||'-')... thats not the problem... and i could use if-else tags but that would be just as difficult... regaurdless thats not whats wrong with the program...

It is the problem. It may compile, but it doesn't mean you're right. What's the point of asking for help if you're going to ignore what people tell you?

"Help!"
"That's the problem."
"Oh no, I couldn't possibly be doing something wrong!"

Quzah.

why so sarcastic quzah? did i say something to offend you?

thanks citizen and onionKnight. it does work now... i thought onionKnight was simply making a suggestion to make my code look better... but i really did want to use the switch statement regaurdless of readability and run-time. Sorry for shooting down your advice i thought it was simply a readability preference.

Don't insult folks who try to correct your screwups, whether or not they use kid gloves or an open fist. Try to see the big picture. We try to do whatever it takes to help others not screw up.

This

Quote:

the compiler accepts (input=='+'||'-')... thats not the problem

is an example of what not to do. You were informed of this, as well as receiving other corrections.

Accept them all as constructive criticisms. Many more will follow throughout your learning.

Someday when you or I write code that no one can criticize is the point at which you can feel confident that you or I may be doing things correctly.

And...
There are other and better and simpler and more correct ways of doing what you are attempting, but I'll reserve comment depending on your posts.

Quote:

Originally Posted by peanut

why so sarcastic quzah? did i say something to offend you?

thanks citizen and onionKnight. it does work now... i thought onionKnight was simply making a suggestion to make my code look better... but i really did want to use the switch statement regaurdless of readability and run-time. Sorry for shooting down your advice i thought it was simply a readability preference.

I wasn't thinking about the switch, it was the conditional operators.

Code:

switch (state) { case 0: if (input == '+' || input == '-') state = 3; else if (isdigit(input)) state = 1; else state = 2; break; case 1: if (isdigit(input)) state = 1; else state = 2; break; case 2: state = 2; break; case 3: if (isdigit(input)) state = 1; else state = 5; break; }

Not as compact, but easier to follow.