Printable View
Hello. I've written a program that sorts the words it took from a file alphabetically. And it works fine with standart characters. But I am from turkey and I need it to recognise turkish characters either. And that, I don't know how. If you know how to do this, please help me. Thanks.
strcmp with your local set correctly for your compiler should handle it.
Quzah.
Or locale even ;)
yeah but can you explain me how to use this locale thing. I include the locale.h first. Then what must i do?
I only need to know how to spell function names, and to make sure all my variables, however misspelled, are the same misspelling. ;)Quote:
Originally Posted by Salem
Quzah.
quzah, i still don't know how to use locale. please explain
clicky click
You could of course go to your favourite search engine and put in some magic words, like 'rapums rapums' ... er ... 'C programming set locale', instead of waiting around for me to reply...
Quzah.
I did of course. I've learned that i need to call function setlocale(LC_ALL,""). And it makes the program recognize turkish letters which it already did by some other way.Now it puts the turkish letters at the end of the array without any order, after it sorts the standard letters. Thats why I've been asking again, am I doing something wrong? thanks.
It sorts them numerically. Each letter has a value assigned to it. Do something like this, and you'll see how it sorts each letter:strcmp is going to start with whatever letter is listed first, and considers that before anything after that in the list.Code:#include<stdio.h>
#include<ctype.h>
int main( void )
{
int x;
for( x = 0; x < 256; x++ )
{
if( isprint( x ) )
printf("%c%c", x, x % 32 ? ' ' : '\n' );
}
printf( "\n" );
return 0;
}
Quzah.
You could try posting some code.
By the way, I think you need to use strcoll() not strcmp() if you want locale-aware sorting order.
hi again, thanks for the help. strcoll worked perfect and problem is solved, but i've got a new one. now 002.txt is the list of words to be sorted. There are 4600 lines in the list and one word each. Now I first want it to count the number of words in the list by counting the '\n' and set size as this.The print the size for me to see.
As I mentioned, it should count 4600, but it counts 488965236 or something like that which means to me that it skips the end of file and I don't know why. This is the first problem. Please help if you can and I'll be thankfull and also asking some more probably:) Thanks a lot.
Code:#include<stdio.h>
#include<string.h>
#include<locale.h>
int main ()
{
setlocale(LC_ALL, "");
FILE *pt;
FILE *pt2;
long size;
pt=fopen("C:\\002.txt","r");
pt2=fopen("C:\\003.txt","w");
do{
if(getc(pt)=='\n')
size++;
}while(!feof(pt));
rewind(pt);
printf("%d",size);
char a[size][50];
int i,j;
for(i=0;i<size;i++) fscanf(pt,"%s",&a[i][0]);
char temp[50];
for(i=0;i<(size-1);i++)
for(j=0;j<(size-1);j++)
if(strcoll(&a[j][0], &a[j+1][0]) >0 )
{
strcpy(temp,&a[j][0]);
strcpy(&a[j][0], &a[j+1][0]);
strcpy(&a[j+1][0], temp);
}
for(i=0;i<size;i++)
fprintf(pt2,"%s\n",&a[i][0]);
getch();
return 0;
}
> it should count 4600, but it counts 488965236 or something like that
Try initialising size to 0 before you start counting.
There is much in your code which isn't standard C
> char a[size][50];
C neither has variable sized arrays, nor mixed declarations and statements.
This would be better for TWO reasons
1. It's valid CCode:char (*a)[50];
/* now work out the size */
/* now allocate the space */
a = malloc ( size * sizeof *a );
2. It means you can do this in your exchange, which is FAR more efficient than copying the strings.
Also look up the qsort() function, which will be more efficient than the bubble sort you have implemented.Code:char *temp = a[j];
a[j] = a[j+1];
a[j+1] = temp;
> fprintf(pt2,"%s\n",&a[i][0]);
You can drop the & and [0], and just have
fprintf(pt2,"%s\n",a [ i ] );
Ditto in all the other places where you have the same style.
Thank you for your time again. I'll look up qsort().Now that is how my code looks like after I did as you said.
in theCode:#include<stdio.h>
#include<string.h>
#include<locale.h>
int main ()
{
setlocale(LC_ALL, "");
FILE *pt;
FILE *pt2;
long size=100;
pt=fopen("C:\\002.txt","r");
pt2=fopen("C:\\003.txt","w");
char (*a)[50];
do{
if(getc(pt)=='\n')
size++;
}while(!feof(pt));
rewind(pt);
printf("%d",size);
a = malloc ( size* sizeof *a );
int i,j;
for(i=0;i<size;i++) fscanf(pt,"%s",a[i]);
char *temp;
for(i=0;i<(size-1);i++)
for(j=0;j<(size-1);j++)
if(strcoll(a[j], a[j+1]) >0 )
{
char *temp = a[j];
*a[j] = a[j+1];
*a[j+1] = temp;
}
for(i=0;i<size;i++)
fprintf(pt2,"%s\n",a[i]);
getch();
return 0;
}
lines I had a "incompatible types in assignment" error so I add the "*"'s.There are two problems.Code:a[j] = a[j+1];
a[j+1] = temp;
First, now it doesnt sort. It just changes the first letter of each word with a weird character. And second, my first problem continues. The size... It still counts more than there is.Do you see anything wrong with this part:
Code:do{
if(getc(pt)=='\n')
size++;
}while(!feof(pt));
Why are you setting it to 100? Where are you pulling that number out of? Your ass apparently.
Quzah.
100 was miswritten, definition is "size=0". sorry for that
So now that you've fixed that, how's the size? How are you checking when you say it prints out the wrong number? Make a file with:Save it. Load it. What's your answer? Do you have a newline after the 5? Try it with and without. Note the 'size'. Just make a file that does only that. Open, count the newlines, close, print the size.Code:1
2
3
4
5
Quzah.
> lines I had a "incompatible types in assignment" error so I add the "*"'s.
Yeah, my mistake :(
You would need char **a to make swapping pointers possible. (*a)[50] are still arrays, so you still have to use the strcpy() approach you had previously.
I can't see anything wrong with your line counter, apart the the already mentioned =100
Try debugging with really small files (like one or two lines) and see what results you get.
Beware that lots of trailing blank lines will likely make your code fail in it's present form.