Im in the process of finishing my File Editor so have a look and tell me what you think of it at the specified e-mail (see readme.txt).Thanx...
Printable View
Im in the process of finishing my File Editor so have a look and tell me what you think of it at the specified e-mail (see readme.txt).Thanx...
#1 The indentation looks lousy, especially if your screen is a little narrow. What's wrong wiith just four spaces?
#2 system("cls")... that's a bad idea.
#3#4Code:31| cin >> selection;
#5Code:44| if (!a_file.is_open())
#6 There is no way I get to read my file before I blindly edit it.Code:90| else (a_file.good());
#7 It's buggy, even in option 1 it will enter an infinite loop. See #4.
#8 You don't have the permissions to create this folder on my computer.
...Code:ofstream c_file("D:\\LW_INFO\\LUF.txt");
...
#99 I can't enter newlines into my file?! What is this?!
...
...
A limit on the max file size is probably a fine idea too. You don't want to let user's write documents large enough to fill their hard drives.
I want constructive critism not just nit picking!
I suggest you reexamine your evaluation of the criticism that was given to your code. It was good criticism.
Some of it yes but the rest is just taking the mic. out of me.
If you can't take it, don't ask for it.
Also, don't ask on a public forum for people to reply to your personal email. That is rude.
>I want constructive critism not just nit picking!
My my, aren't we rude after asking volunteers for their opinions. How about you try being a little more grateful that someone bothered to point out places your code could be improved?
I feel like Simon Cowell right now :D
Disclaimer:
***If you don't want us to criticize your code, please do not post it here. Thank you.***
By the way, you didn't even read my above post in it's entireity. I put in a line of correct code, flagged as incorrect. Did you notice it?
Sorry i took the wrong way but i am apoligizing for any hurt i may have caused anyone on the day!
P.S I took a break and have only just started changing it but you'll be pleased to know that i changed the system("cls"); thingy!
... you didn't hurt us, it seemed like the other way round though :)
Hah i often take things very personaly(lol)!
By the way would you recommend i change:
toCode:ofstream b_file("D:\\LW_INFO\\LUF.txt");
As some people only have the C:\ drive and others may have other names for a second or even third hard drive or flash drive!SO tell me wat you think plz.Thanx.Code:ofstream b_file("C:\\LW_INFO\\LUF.txt");
P.s I have also added a caution message about the folders i use in the prog and what they are used for and tell them not to use my prog if they dont like this idea!
I'd recommend leaving the drive letter out period, unless you store a LW_INFO folder on a CD or something. Every OS that I know of understands relative filepaths.
Thanx for your help i'll do that.
Does anyone know why this piece of code doesn't work:
Code:string ver;
ofstream version_file("version.txt");
getline(version_file,ver);
cout<<ver;
cin.get();
version_file should be of ifstream type. not ofstream
Thanx for that, i make alot of small mistakes that i could correct myself except i just cant see the problem if you get me(lol).
Write this is what i have done sofar (not that much but i only do it in my spare time) but have a look if you want and tell me what you think of it.Thanx.
http://files.filefront.com/FE_21exe/.../fileinfo.html