need help with handelling multiple source files

Sorry I'm not too bright, but I need some help here:

Im trying to split up my code, by includding different header and cpp files, but it give me errors like this:

Code:

---

1>colorIt.obj : error LNK2005: "void __cdecl blue_grey(void)" (?blue_grey@@YAXXZ) already defined in cosmosII_client.obj

---

This is my delcaration in main.cpp:

Code:

---

#include "global.h"
#include "colorIt.cpp"

---

colorIt.cpp:

#define _WIN32_WINNT WINVER

#ifdef WIN32
#endif

// INTERFACE FUNCTIONS:
// font colors>>

Code:

---

void tred()
{
        #ifdef WIN32
                HANDLE hstdo;
                hstdo = GetStdHandle(STD_OUTPUT_HANDLE);
                SetConsoleTextAttribute(hstdo, FOREGROUND_RED);
        #endif 
}

---

Help me make it so the files work. One time I tryed it a different way, and it compiled, but it didnt print any console colorS!

1. Don't put definitions in a header, #include it in multiple files, and then expect the linker not to complain.
2. Don't #include source files.
3. Don't post C++ code on the C board.

still having problems.

Still not posting all relevant info.

My main cpp file, is called "main.cpp"

I tryed to include this in the main.cpp file:

Code:

---

#include "color.h"

---

color.h only says this in the entire file for testing reasons:

Code:

---

void blue_grey(void);

---

BUT colorIt.cpp has the actual function, and includes the color.h:

Code:

---

#include "color.h"

#define _WIN32_WINNT WINVER

#ifdef WIN32
#endif

void blue_grey()
{
        #ifdef WIN32
                HANDLE hstdo;
                hstdo = GetStdHandle(STD_OUTPUT_HANDLE);
                SetConsoleTextAttribute(hstdo, FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_BLUE|BACKGROUND_INTENSITY|BACKGROUND_BLUE);
        #endif 
}

---

Now I know somethings wrong, but I basically just want to split up my huge file into other files, and have it all compile and work together.

So basically, my main.cpp is supposed to gather all other files, and compile it as if it was really in one file. I guess that works?


EDIT:

OK IT NOW COMPILES! But it does NOT show any of my colors!

Just so you're clear, this is a header file (hpp)

Code:

---

#include "color.h"
// Don't do this either. You do not have to include your custom made header file when you
// define it here:
#ifndef _WIN32_WINNT WINVER
#define _WIN32_WINNT WINVER
#ifdef WIN32
void blue_grey(void);
#endif

---

This is an implementation file (cpp)

Code:

---

#include "color.h"
void blue_grey(void)
{
                HANDLE hstdo;
                hstdo = GetStdHandle(STD_OUTPUT_HANDLE);
                SetConsoleTextAttribute(hstdo, FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_BLUE|BA  CKGROUND_INTENSITY|BACKGROUND_BLUE);
}

---

Only include color.h where it needs to be used now.

but this is everything in my color.h file:

Code:

---

// INTERFACE FUNCTIONS:
// font colors>>

void tred();
void tgreen();
void tblue();
void tmagenta();
void tteal();
void ttan();
void tdefault();
void tred_i();
void tgreen_i();
void tblue_i();
void tmagenta_i();
void tteal_i();
void ttan_i();
void tdefault_i();

// background colors:

void bred();
void bgreen();
void bblue();
void bmagenta();
void bteal();
void btan();
void bdefault();
void bred_i();
void bgreen_i();
void bblue_i();
void bmagenta_i();
void bteal_i();
void btan_i();
void bdefault_i();
void face_intro();
void face_darktech();
void face_menu_titlebar();
void cosmos_logo();
void dark_logo();
void light_side();
void red_i();
void green_i();
void blue_white();
void teal_white();
void blue_grey();

---

EDIT: I beleive the problem is that the program is looking at my color functions as all void, which it is no doing anything because there is nothing to do in color.h. But how do I make it so color.h can do what colorIt.cpp does with the defs.

Last time I saw an implementation of something like this, you need to pass in a reference to the ostream in all the functions, and use those streams, in order to expect it to work with the ostream at all.

What do you mean by pass a reference to ostream?

I see the best way to learn something like this is to study another implementation, and then get yours to work.

http://www.codeproject.com/cpp/AddColorConsole.asp

Moved to C++ From C

Where does the WIN32 macro get defined? Or should it be _WIN32?

Quote:

---

Originally Posted by DarkMortar

Code:

---

void blue_grey()
{
#ifdef WIN32
  HANDLE hstdo;
  hstdo = GetStdHandle(STD_OUTPUT_HANDLE);
  SetConsoleTextAttribute(hstdo, FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_BLUE|BACKGROUND_INTENSITY|BACKGROUND_BLUE);
#endif 
}

---

OK IT NOW COMPILES! But it does NOT show any of my colors!

---

Perhaps add an #error statement in an #else to verify that the code you are trying to conditionally compile is really there.

Code:

---

void blue_grey()
{
#ifdef WIN32
  HANDLE hstdo;
  hstdo = GetStdHandle(STD_OUTPUT_HANDLE);
  SetConsoleTextAttribute(hstdo, FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_BLUE|BACKGROUND_INTENSITY|BACKGROUND_BLUE);
#else
#error !WIN32
#endif 
}

---

got this error when I compiled it:

Code:

---

1>.\colorIt.cpp(365) : fatal error C1189: #error :  !WIN32

---

So it means its really there huh?

Code:

---

void blue_grey()
{
        #ifdef WIN32
                HANDLE hstdo;
                hstdo = GetStdHandle(STD_OUTPUT_HANDLE);
                SetConsoleTextAttribute(hstdo, FOREGROUND_RED|FOREGROUND_GREEN|FOREGROUND_BLUE|BACKGROUND_INTENSITY|BACKGROUND_BLUE);
#else
#error !WIN32       
#endif 
}

---

It means that prior to your putting an else case in, it looked like this.

Code:

---

void blue_grey()
{
}

---

Nothing there to do anything spectacular.

Have you tried my other suggestion as well, since you seem to be basing this on a macro that you nor anyone else defines.?

my colorIt.cpp

has this at top:

Code:

---

#include "color.h"

#define _WIN32_WINNT WINVER

#ifdef WIN32
#endif

---

color.h

has just void functions like this, with no declarations:

Code:

---

// INTERFACE FUNCTIONS:
// font colors>>

void tred();
void tgreen();
void tblue();

//ect...

---

It's not the functions that dont work, because before, I had this all in my main.cpp file and it worked flawlessly. But my problem is the way I am trying to split up the files.

I tryed your other example and it just gives me errors that it doesnt understand any other the symbols. I will repeat, the functions HAVE worked, but the compiler is not reading them, it seems like it thinks they are voids with nothing in it because of the color.h file.

So what do your files look like now, and what errors are you getting?

no errors, it compiles and runs, but it doesnt show the colors, it seems like it thinks the functions are void when they shouldnt be.


main.cpp:

Code:

---

#include "global.h"
#include "color.h"

---

color.h:(no includes)

Code:

---

// INTERFACE FUNCTIONS:
// font colors>>

void tred();
void tgreen();
void tblue();
void tmagenta();
void tteal();
void ttan();
void tdefault();
void tred_i();
void tgreen_i();
void tblue_i();
void tmagenta_i();
void tteal_i();
void ttan_i();
void tdefault_i();

// background colors:

void bred();
void bgreen();
void bblue();
void bmagenta();
void bteal();
void btan();
void bdefault();
void bred_i();
void bgreen_i();
void bblue_i();
void bmagenta_i();
void bteal_i();
void btan_i();
void bdefault_i();
void face_intro();
void face_darktech();
void face_menu_titlebar();
void cosmos_logo();
void dark_logo();
void light_side();
void red_i();
void green_i();
void blue_white();
void teal_white();
void blue_grey();

---

colorIt.cpp:

Code:

---

#include "color.h"

#define _WIN32_WINNT WINVER

#ifdef WIN32
#endif

// INTERFACE FUNCTIONS:
// font colors>>

void tred()
{
        #ifdef WIN32
                HANDLE hstdo;
                hstdo = GetStdHandle(STD_OUTPUT_HANDLE);
                SetConsoleTextAttribute(hstdo, FOREGROUND_RED);
        #endif 
}

// ect.. other color functions like tred()

---

Did you add WIN32 to your preprocessor definitions? From your previous post, it sounds like WIN32 is not defined.

Maybe you ought to change the order of #includes to match how it was previously, if that has changed. Like maybe "color.h" needs to see _WIN32_WINNT.

Code:

---

#include "color.h"

#define _WIN32_WINNT WINVER

---

What the little #else #error test showed you is that you are compiling nothing right now. Before may have been great, but you may have inadvertently changed the magic order.

well i defined something in colorIt.cpp, that is about WIN32. Its actually also defined in main.cpp also. But what do you mean by defining it as a predepressor? It has worked before, but only when it was in the main.cpp file.

I just tryed putting color.h below and it still does not show color. Oh im really sorry for all hte trouble im causing. :(

>>well i defined something in colorIt.cpp, that is about WIN32.

"something" isn't good enough. You need to define WIN32 if you want that code between #ifdef WIN32 and #endif to run. Ideally, you should use a preprocessor option passed to the compiler, but if you just put #define WIN32 at the top of your files (or in files included) it should work.

But if I put #define WIN32 in the C/C++ compiler properties under predpresser, it will give me infinite errors, like it doesnt know any of my variables when I do that.

I even tryed it the other way, but putting
#define WIN32 at the VERY top of every file, and same result

Quote:

---

Originally Posted by DarkMortar

But if I put #define WIN32 in the C/C++ compiler properties under predpresser, it will give me infinite errors, like it doesnt know any of my variables when I do that.

---

Investigate how you are supposed to use a #define for the IDE?

What variables? You haven't show us any yet.

Quote:

---

Originally Posted by DarkMortar

I even tryed it the other way, but putting
#define WIN32 at the VERY top of every file, and same result

---

We can't read your computer screen, perhaps you could share the mystery with us... or wait until our crystal balls get back from cleaing.

Do you still get the #error statement even with this attempt?

Ok this time, I properly defined WIN32 in the predepresser and it compiles and runs now. Nothing else was changed. BUT it STILL doesnt show the colors like it should.

BUT: the #error in blue_grey() function generates an error in the compile when I add this:

Code:

---

#else
#error !WIN32

---

ERROR:
1>.\colorIt.cpp(366) : fatal error C1189: #error : !WIN32

So now you know that information, now what?

Quote:

---

Originally Posted by DarkMortar

BUT: the #error in blue_grey() function generates an error in the compile when I add this:

Code:

---

#else
#error !WIN32

---

ERROR:
1>.\colorIt.cpp(366) : fatal error C1189: #error : !WIN32

So now you know that information, now what?

---

As you can see, for the functions you want to show color, you are in fact compiling no code to change the color. So how could it run with the latest changes?

[edit]'predepresser' - funny.

but dood, when I even left out the #error statements in the color functions, it compiled but didnt show the color! hmm?

Quote:

---

Originally Posted by DarkMortar

but dood, when I even left out the #error statements in the color functions, it compiled but didnt show the color! hmm?

---

Don't take it out. That's what tells you when you are doing it right or not.

Code:

---

#include <stdio.h>

int main(void)
{
#define MACRO
#ifdef MACRO
  puts("MACRO is defined");
#else
  puts("MACRO is NOT defined");
#endif

#undef MACRO
#ifdef MACRO
  puts("MACRO is defined");
#else
  puts("MACRO is NOT defined");
#endif
  return 0;
}

/* my output
MACRO is defined
MACRO is NOT defined
*/

---

When you are doing it right, the message will go away.

Example!

Code:

---

#include <iostream>

#define X1

#ifdef X1
void x1()
{
    std::cout<<"HI!!!!!";
}
#endif

#ifdef X2
//This functon does not get called!
void x1()
{
    std::cout<<"Hello!!!!!!!";
}
#endif

int main()
{
    x1();
    std::cin.get();
}

---

Code:

---

#include <iostream>

#define X2

#ifdef X1
//This functon does not get called!
void x1()
{
    std::cout<<"HI!!!!!";
}
#endif

#ifdef X2

void x1()
{
    std::cout<<"Hello!!!!!!!";
}
#endif

int main()
{
    x1();
    std::cin.get();
}

---

Ok that does make sense to me now, but I put #define WIN32 at the top and it gives me errors in the functions like this:

Code:

---

1>.\colorIt.cpp(235) : error C3861: 'SetConsoleTextAttribute': identifier not found
1>.\colorIt.cpp(242) : error C2146: syntax error : missing ';' before identifier 'hstdo'
1>.\colorIt.cpp(243) : error C3861: 'GetStdHandle': identifier not found
1>.\colorIt.cpp(244) : error C3861: 'SetConsoleTextAttribute': identifier not found
1>.\colorIt.cpp(251) : error C2146: syntax error : missing ';' before identifier 'hstdo'
1>.\colorIt.cpp(252) : error C3861: 'GetStdHandle': identifier not found
1>.\colorIt.cpp(253) : error C3861: 'SetConsoleTextAttribute': identifier not found
1>.\colorIt.cpp(260) : error C2146: syntax error : missing ';' before identifier 'hstdo'
1>.\colorIt.cpp(261) : error C3861: 'GetStdHandle': identifier not found
1>.\colorIt.cpp(262) : error C3861: 'SetConsoleTextAttribute': identifier not found
1>.\colorIt.cpp(271) : error C2146: syntax error : missing ';' before identifier 'hstdo'
1>.\colorIt.cpp(272) : error C3861: 'GetStdHandle': identifier not found
1>.\colorIt.cpp(273) : error C3861: 'SetConsoleTextAttribute': identifier not found
1>.\colorIt.cpp(280) : error C2146: syntax error : missing ';' before identifier 'hstdo'
1>.\colorIt.cpp(281) : error C3861: 'GetStdHandle': identifier not found
1>.\colorIt.cpp(282) : error C3861: 'SetConsoleTextAttribute': identifier not found
1>.\colorIt.cpp(282) : fatal error C1003: error count exceeds 100; stopping compilation

---

ect...

What the file looks like:

Code:

---

#define WIN32
#define _WIN32_WINNT WINVER

#include "color.h"

#ifdef WIN32
#endif

// INTERFACE FUNCTIONS:
// font colors>>

void tred()
{
        #ifdef WIN32
                HANDLE hstdo;
                hstdo = GetStdHandle(STD_OUTPUT_HANDLE);
                SetConsoleTextAttribute(hstdo, FOREGROUND_RED);
        #endif 
}

---

Perhaps your file needs to include a header that tells it about the code (that it isn't supposed to have in it if it's a header). [Back to that original order thing, possibly.]

Becaue you are not including windows.h in that file.

Quote:

---

Originally Posted by prog-bman

Becaue you are not including windows.h in that file.

---

YESSSSSSSSSSSSSSSSSS!!!1
YESSS


OH YES, FINALLY! That is why!!! :D :D :D

Ok sorry but finally woot! Sorry, I'm new to C. And I feel stupid now :rolleyes:

heh.

Hmm.. ok lol, new problem now.

It's a little different than before. The difference here is that the compiler is giving me errors when I try to include my global.h file which conains all of my global variables.

Whenver I include:
"global.h"

in the "intro.cpp" file,
it says its already been defined from cosmosII_client.cpp
error:

Code:

---

1>intro.obj : error LNK2005: "int arenaGen" (?arenaGen@@3HA) already defined in cosmosII_client.obj
1>intro.obj : error LNK2005: "int arenaTimeNum" (?arenaTimeNum@@3HA) already defined in cosmosII_client.obj
1>C:\Documents and Settings\Keenan\My Documents\Visual Studio 2005\Projects\CosmosII\Debug\CosmosII.exe : fatal error LNK1169: one or more multiply defined symbols found

---

ect...

But if I take out global.h in the "intro.cpp" file it cant find the variables at all and will say this:

Code:

---

1>.\intro.cpp(109) : error C2065: 'part' : undeclared identifier
1>.\intro.cpp(123) : error C2065: 'diag_1' : undeclared identifier
1>.\intro.cpp(134) : error C2070: ''unknown-type'': illegal sizeof operand

---

ect... (it doesnt see the variables in global.h!

WHAT THE FILES LOOK LIKE:

Code:

---

intro.cpp:

// intro.cpp

#include <windows.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <time.h>
#include <string.h>
#include <wincon.h>
#include <conio.h>
#include <iostream>
#include <iomanip>

#include "global.h"
#include "color.h"
#include "intro.h"

// prototypes
void main_menu(void); void user_name(void); void difficulty_select(void); void intro(void);
void game_logo(void); void intro_ask(void); void intro_part2(void); void logo(void);

// STARTUP FUNCTIONS:

void logo()
{
        dark_logo();system("cls");

        for(int intro_loop=0;intro_loop<26;intro_loop++)
        {
                Sleep(1);
                printf("\n\n");
        }
} //ect...

---

Code:

---

intro.h:

// intro.h

void intro(void);
void game_logo(void);
void intro_ask(void);
void intro_part2(void);
void logo(void);

---

global.h:

Code:

---

// global.h

// _________________
// GLOBAL VARIABLES:

        extern char diag_1[]="In a galactic system far, far away...";
        extern int part=0;
 
  extern char difficultyString[7]="NONE";char typeString[11]="NONE";
  extern int difficulty=0,type=0;
//ect...

---

cosmosII_client.cpp:

Code:

---

// COSMOS II - CLIENT (Build 0.00)

/* Coded by X
  Begun: April 6, 2006 | End: TBA */

#define _WIN32_WINNT WINVER

// include files

#include <windows.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <time.h>
#include <string.h>
#include <wincon.h>
#include <conio.h>
#include <iostream>
#include <iomanip>

#include "global.h"
#include "color.h"
#include "intro.h"


#ifdef WIN32
#endif

//ect...

---

Where are arenaGen and arenaTimeNum defined?

in global.h, like this:

Code:

---

extern int arenaMaxTemp,arenaTemperature,timeGen,arenaWindVariance,arenaLowWind,
                arenaMaxWind,arenaWind,arenaTempVariance,arenaLowTemp,arenaFans,arenaForcastNum,
                arenaForcastRnd,arenaMaxRange,arenaNum,arenaGen,arenaTimeNum;

---

i actually have a lot more...

EDIT: ignorre spaces i didnt do that

If you declare them as extern, it means they are defined in another file. If you try to define them in the header file, it won't work. So you should have in some header file the variables declared as extern and defined in only one source file, eg:

Code:

---

//foo.h
extern int foo;

//foo.cpp
#include "foo.h"
int foo=5; //initialization optional

//main.cpp
#include "foo.h"
int main()
{
  std::cout<<foo;
}

---

hey, hey ,hey that works!