Little help?

Hello, i'm a long time lurker, first time posting...

i have 2 problems really,

This next block of code is part of a sorta, dice roller thats rolls 7 20 sided dice, but only rolls numbers between 10 and 20. what i want is to put each roll into a variable to be used later in the program

Code:

---

                      high = 20;                 
                      cin.get();
                      cout << "Here are your rolls: " << endl;
                      for (int x = 0; x < 7; x++) {
                      die = rand() % (high - 10 + 1) + 10;
                      cout<< die << endl;
                      }
                      cout << endl;

---

my next thing is, for some reason cin.getline(); is not working.. here's the code i used

Code:

---

char backstory[2000];
cout << "Please enter your your character's backstory, if any: ";
cin.getline(backstory, 2000, "/n");

---

the backstory variable is decalred on the top of the code, while the next part is near the end. when i run the program it works fine up to any cin.getline().. it actually skips it and moves on to the next line
it lookes like this:

Code:

---

Please enter your character's first name: [userinput]
Please enter your character's last name: [userinput]
Please enter your character's backstory: [this part is skippped and goes to next line]
Please press any key to continue....

---

Any ideas on both problems?

1. Only the last roll will be stored in the die variable once the for loop breaks; use an array of ints so you can access all the numbers randomly generated.
2. The delimeter for getline() must be a char '\n' not a string "\n". As it is the default delimeter, you don't even need to type it

i tried the std::getline() before you edited, and me type "\n" was a typo here.. in the code, it is '\n'.. std::getline(backstory,2000,'\n') did not work at all said no matching function
The dice rolling worked well, btw

Use cin.get(backstory, 2000);

I'm very sorry, I misread before. :D

Just to confirm, you tried:

Code:

---

std::cin.getline(backstory, 2000);

---

right?

ok, so, it kinda worked, when i went tried when i entered the "user input" part a, it kinda took off the first word

Code:

---

Enter Backstory: {user input} = "This is a long backstory"

it displayed

"  is a long backstory"

---

edit:
yes i did use

Code:

---

std::getline(backstory, 2000);

---

Edit2 ok i see that part where i messed it.. i was missing cin. on the std:: but then i tried that with full line.. and it still skips the first word

Code:

---

    char backstory[2000];
    std::cout << "Please enter your your character's backstory, if any: ";
    std::cin.getline(backstory, 2000, '\n');
    std::cout<<backstory<<"\n";
    std::cin.get();

// OUTPUT:
// Please enter your character's backstory, if any: This is a really long story.
// This is a really long story.

---

I'm using

Code:

---

using namespace std;

---

other than using 'std::' the rest of the code looks exaclty like i have it
with few things in between here and there...

If you haven't guessed already, this a prgram designed to make a RP character sheet faster without having to write it down on paper. just print and done.. but anyway... i realized why it was skiping the first word i had 'cin >> backstory' before the getline code, which brings it back to the problem i was having before, it totally skips the user input part and goes to the next line of code which would be

Code:

---

cout << "Generating Data..." << endl;
system("pause");

---

i'm using the pasue command because the code also wants to skip cin.get()

Ah! now I understand... it sounds to me like you need to flush the input buffer, so just type

Code:

---

cin.ignore(10000, '\n');

---

before the code block you are having problems. Now, it should work, and you don't have to use system("PAUSE");

HA! Thanks alot, that worked perfectly!

Edit: ok, one last thing, after generating data...., and since i don't have to use system pasue.. i do want it to pause for a certain amout of seconds.. and then continue with program.. can this be done?

Yes, but this is rather implementation-specific. The Windows API provides Sleep(). I remember there being a quasi-standard header (<unistd.h> IIRC) containing usleep() which works similiar to Sleep().Or try here.

Code:

---

#include <ctime> // Standard: for clock stuff

void wait (double seconds)
{
  // using namespace std; // when necessary, define the namespace
  clock_t start_time = clock();
  while((clock() - start_time) < seconds * CLOCKS_PER_SEC)
    {
      // do nothing
    }
}

---

Just call that function there. You can wait as long or as short as you like, even down to fractions of seconds. It's a lot more standard than what the person above me was saying.

Thanks, that worked, though now i have ran into another prblem with the program

Code:

---

ofstream cs_file("characters\\"cfullname".html");

---

What thats suppose to do is create a .html file with the 'characters' first and last name combine and will put all the info in that file.. "cfirstname-clastname.html" with other blocks of code after that.. but the problem is that block of code above, won't work. any ides?

Code:

---

string fname;
string lname;
string filename;

cout << "Enter first name: ";
getline(cin,fname);
cout << "Enter last name: ";
getline(cin,lname);

filename = fname + lname + ".txt";
ofstream output(filename.c_str() );

---

If you enter in "Bob" and "Dole" for the first and last names, then the program above will attempt to open a file called "BobDole.txt". That should give you a clue how to proceed.

Code:

---


    char cfirstname[100];
    char clastname[100];
    char cfullname[200];
                      string filename;
                      cfullname[0] = '\0';
                      strcat ( cfullname, cfirstname );   
                      strcat ( cfullname, "-" ); 
                      strcat ( cfullname, clastname );
                      filename = "characters\\" + cfullname +".html";

---

The output file is suppose to go to the folder Characters and atempt to make the first and last name file like "characters\Bob-Dole.html"

when i try to compile it the error reads

Code:

---

invalid operands of types `const char[12]' and `char[200]' to binary `operator+'

--- on # line
(filename = "characters\\" + cfullname +".html";)

---

now thats before the code to create the file

Code:

---

invalid operands of types `const char[12]' and `char[200]' to binary `operator+'

--- on # line
(filename = "characters\\" + cfullname +".html";)

---

You need to use strcat for char arrays, or strings:

Code:

---

(filename = string("characters\\") + cfullname + string(".html");

---

or

Code:

---

filename = "characters";
filename += cfullname;
filename += ".html";

---

Thanks that worked perfectly! i know i think i'm being a bother... and i hate to ask this (hopefully) last question.. as i was continuing on with the program, while waiting for replies i came up with another problem... (( it would seem every 30 lines i run into another problem... ))

I'm back at the dice rolls that were random between 10 and 20... based off the rolls and why i needed them into variables.. depending on the roll i want to add to it.. in a string like:
if roll is a 10 i want to append 10-0 and thats how it would look on the html file and 11 and 12 ... -1 11-1//12-1 ect all the way up to 20-5

so if the rolls are
12
14
11
20
19
16
10

the output would read

12-1
14-2
11-1
20-5
19-5
16-3
10-0

i tried a few pssobilties, but i keep getting the erros cannont covert bewtween char and int.. the char being '-' also those -3, -4 i want to be added like the above, the some of those is '17'... any ideas on this part..

(( i hope this is the last thing wrong with the code...... I'm fairly new to c++ i have worked with it before.. but this is something my friend requested...
i do thank you all for the help.))

I just have a question. Why is it important to format the dice roll this way? Is the second number random like the first? I've not seen a 20-sided die before.

Quote:

---

Originally Posted by citizen

I just have a question. Why is it important to format the dice roll this way? Is the second number random like the first? I've not seen a 20-sided die before.

---

You've obviously not played enough role playing games :D

its just the way we play... it adds to armor... and no that number is not random its acorrding to the first random number if its 10 -0 is appendded to it..
10-0
11 12 -1
13 14 -2
15 16 -3
17 18 -4
19 20 -5

like that...

well here's what I would do. Not sure if you'd like it, but Prelude taught me how to deal with random numbers. You should probably learn about what I'm doing.

Code:

---

#include <iostream>
#include <cstdlib>

using namespace std;

// This function helps seed rand() more properly
unsigned time_seed(void)
{
  time_t now = time ( 0 );
  unsigned char *p = (unsigned char *)&now;
  unsigned seed = 0;
  size_t i;

  for ( i = 0; i < sizeof now; i++ )
    seed = seed * ( UCHAR_MAX + 2U ) + p[i];

  return seed;
}

// This function just makes sure that we don't make other rolls
// occur more common than others
double uniform_distribution (int seed)
{
  return seed * 1. / (RAND_MAX + 1.);
}

int main(void)
{
  const char *die[10] =
  { "10-0", "11-1", "12-1", "13-2", "14-2", "15-3",
    "16-3", "17-4", "18-4", "19-5", "20-5" };

  srand(time_seed());

// Now, the dice roll still works the same, except you are working
// within the bounds of a string array.
  int r =  uniform_distribution(rand()) * 10;
  cout << die[r];

  cin.get();

  return 0;
}

---

There's a much simpler way which doesn't involve translating the dice roll to a string - look at this psuedo-program:

Code:

---

int main ()
{   
    int x = // Some number from 10 to 20;
    x = (x-9)/2;
    cout << x;
}

---

Right Bench! Wow, that was neat... of course there was nothing wrong with my solution, it just looks complex because that's how I learned random numbers. My only criticism is that you overwrote the value for x. Shouldn't it be?

Code:

---

int die = 10 + uniform_distribution(rand()) * (10-20); // some random number 10 to 20;
cout << die << "-" << (die-9)/2 << "\n";

---

Quote:

---

Originally Posted by citizen

. My only criticism is that you overwrote the value for x. Shouldn't it be?

---

Yep, you're right, I should have stored the result in another variable instead of overwriting x. my arithmetic is sometimes better than my programming ;)