Can someone tell me why this doesn't work?

just a simple getinput function that for some reason doesn't work :confused: it just returns empty, can anyone help me out?

Code:

---

string getInput(string data, int limit, bool hidden) {
    int ch, i = 0;
   
    do{
        ch = getch();
        ch = tolower(ch);
       
        if (ch == 8) {
            //TODO: user hit backspace
        } else if (isalnum((char)ch) && i <= limit && ch != 13) {
            data += (char)ch;
            if (!hidden) {
                cout << (char)ch;
            } else {
                cout << "*";
            }
            i++;
        } else if (i <= limit && ch != 13) {
            Beep(350, 75);
        }
    } while (ch != 13);

    return data;
}

---

Parameters of the function cannont be modofied...if you want to modify the parameters of a function....create a macro instead.... , in other words, you can't modify first parameter "data", try to exclude "data", and make a string that was created in the function and return that one instead

Like This:

Code:

---

string getInput(int limit, bool hidden) {
    int ch, i = 0;
    string data;

    do{
        ch = getch();
        ch = tolower(ch);
       
        if (ch == 8) {
            //TODO: user hit backspace
        } else if (isalnum((char)ch) && i <= limit && ch != 13) {
            data += (char)ch;
            if (!hidden) {
                cout << (char)ch;
            } else {
                cout << "*";
            }
            i++;
        } else if (i <= limit && ch != 13) {
            Beep(350, 75);
        }
    } while (ch != 13);

      //Now Here you can return data, with modified content
    return data;
}

---

oooooooooooohhhhh really? wow now I feel dumb, thanks alot I prolly never would've thought of that :p

Actually that's not correct. It makes no difference in this case. It might be better style, but it might also return a different value than the original code.

What parameters are you passing to your function?

Well originally I was doing getInput(data, 9, false); to get a string to be stored into data that was no longer then 10 characters long and didn't show up as hidden, but it wasn't returning what i typed, just random jibberish. After doingt what toonlover said, I can just do like string = getInput(9, false); to achieve the same effect...and it actually works :p

The fix was to use the return value of the function instead of the passed in parameter. The change toonlover made didn't actually change how the function worked, it just forced you to find the real problem. Of course, it is a better idea to use the new code for style reasons, since you apparently aren't intending to pass an initial value to your function, so all is well. I just don't want people thinking that you cannot modify a function parameter because of course you can.

Erm, what would be the best way to convert a char[x] or whatever the length to lower be? tolower() only takes int >.>

A char can be converted to an int automatically. If you need to, cast the return value back to char:

Code:

---

str[x] = static_cast<char>(tolower(str[x]));

---

ahh thanks alot :D