Term does not evaluate to function taking 2 arguments? Bugger.

Working on a program for the Euclidian algorithm, and it's giving me a bit of trouble. I think I have the math and such down, but it's giving me an unusual error. I believe I know what it's trying to tell me, but I can't figure out exactly what I've done wrong for the life of me! :mad:

Ahem. My code so far (not complete, might I add)

Code:

---

#include <iostream>
using namespace std;
void prompt(int&, int&);
int gcf (int, int);
int reduce (int, int);

void main()
{
        int num1 = 0;
        int num2 = 0;
        int gcf = 0;

        prompt (num1, num2);
   
        cout << "Fraction so far: " << num1 << "/" << num2 << endl;
       
        gcf (num1, num2);
}

void prompt(int &a, int &b)
{
        cout << "Enter your numerator: ";
        cin >> a;
        cout << "Enter your denominator: ";
        cin >> b;
}

int gcf (int num1, int num2)
{
  int remainder=1;
  int gcf;

  while (remainder!=0)
  {
  remainder=num1%num2;
  gcf=num2%remainder;
  }
          return gcf;

}

---

The 17th line:

Code:

---

gcf (num1, num2);

---

is giving me trouble. As far as I know, it's correct for my purposes, but the compiler justi sn't happy with it. What have I missed?

> void main()
main returns an int - see FAQ

> int gcf (int, int);
A function

> int gcf = 0;
A variable with the same name, in a nearer scope to the function name.

Guess which one the compiler tries to "call" ?

try renaming the variable int gcf ..... its the same as the name of your function

...D'oh! XD

Gods. Sorry. Running on caffeine and brain fumes. Right. Gonna go change. XD

EDIT: Oh, glorious. Now it bombs when I run it. :p Back to the drawing board.

EDIT AGAIN: Allow me to rephrase that: HELP! DX

The code, editted as per your advice:

Code:

---

#include <iostream>
using namespace std;
void prompt(int&, int&);
int gcf (int, int);
void reduce (int&, int&);

void main()
{
        int num1 = 0;
        int num2 = 0;

        prompt (num1, num2);
   
        cout << "Fraction so far: " << num1 << "/" << num2 << endl;

        reduce (num1, num2);

        cout << "GCF: " << gcf (num1, num2) << endl;

        cout << "reduced: " << num1 << "/" << num2 << endl;
}

void prompt(int &a, int &b)
{
        cout << "Enter your numerator: ";
        cin >> a;
        cout << "Enter your denominator: ";
        cin >> b;
}

int gcf (int num1, int num2)
{
  int remainder=1;
  int gc;

  while (remainder!=0)
  {
  remainder=num1%num2;
  gc=num2%remainder;
  }
          return gc;

}

void reduce (int &n1, int &n2)
{
        n1 = n1/n2;
        n2 = n2/n2;
}

---

Now, it compiles, and even runs for a bit, but it spontaneously erros and dies as soon as it tries to call the gcf function. :(

Code:

---

  remainder=num1%num2;
  gc=num2%remainder;

---

if remainder is 0 that will result in a division by 0 -> bombs.
You should think about the logic of that function.
if num1%num2 is non-zero you have a infinite loop.
Kurt