Create something like php's explode()

Hi again.

I'm trying to make something that will behave somewhat like php's explode(), but im failing to do so.

Here's what I got so far:

Code:

---

#include <stdio.h>
#include <string.h>

/*
  This program is suppsed to take each word from 'string' and add it into
  an array (word_array) so that each word can be accessed via word_array.

  Like, word_array[1] will be 'random', word_array[2] will be 'stupid' and so on. 

*/

int main()
{
    char string[] = "random stupid text and other stuff, even a weird number like 124";
    char word[64]; // will contain one word tempoarly (i.e 'random') before it's added into word_array
    char *word_array[1024]; // will contain an array of words (i.e "random", "stupid")

    int i = 0;
    int a = 0;
    int o = 0;
    size_t x = strlen(string);

    while( i < x )
    {
        if ( string[i] != ' ' )
        {
            word[o] = string[i];
            o++;
        }
        else // We hit a ' ' (space), so that means we (should) have a word in our (word) array. let's add it to word_array;
        {
           
            printf("word = %s\n", word); // debug
            word_array[a] = word;
            /* This is where it's supposed to re-create the 'word'-array
              delete word;
              char word[64]; */
            a++;
            o = '0';
        }
        i++;
       
    }
    printf("%c\n", word_array);
}

---

Any suggestions/ideas/pointers?

1.You never allocate any space for the strings in the word_array.
2. you have to use strcpy to copy word into the word_array.
Kurt

Please read the FAQ

http://faq.cprogramming.com/cgi-bin/...&id=1044780608

Code:

---

printf("word = %s\n", word); // debug

---

You never null terminate word, so this will overflow.

Code:

---

word_array[a] = word;

---

Nope, this wont work. You overwrite the word array for every word, so you basically have every index in word_array pointing to the same exact thing.

You need to do something like this:

Code:

---

word_array[a] = malloc(strlen(word) + 1);
strcpy(word_array[a],word);

---

Code:

---

delete word;

---

First of all, delete is a C++ keyword, not C. Second of all, it only works on dynamically allocated memory which word is not.

Code:

---

o = '0';

---

Not sure why this is here, but take it out as it does nothing.

Code:

---

printf("%c\n", word_array);

---

No. First of all, to print a string, use %s, not %c. Second of all, word_array is NOT a string, it is an array of strings. More appropriate would be:

Code:

---

printf("%s\n", word_array[0]);

---

Alright, thanks guys.

And one other thing:

Code:

---

int i;
size_t x;

while( i < x )

---

On the last line, with full compiler warnings, you might get something like "warning: signed/unsigned type mismatch". To fix that, cast it:

Code:

---

while( (size_t) i < x )

---

better yet, fix the types to be compatible to start with.