Word Jumbling

Ok, I have this code that takes a word from the user and jumbles it up like this...

Code:

---

for(unsigned int m = 0; m != length - 2;m++){
                srand(m);
                text[rand()%length-1] = text[rand()%length];

}

---

But it duplicates letters, how can I stop it form duplicating letters?

Right now, your method is basically to pick an element at random, and replace it with another element picked at random from the entire array. I hope you can see why this is causing duplication, you aren't restricting the domain and range.

Start with the first element, pick another element at random, and swap these two elements. On the next iteration, swap the second element with another element picked at random, but exclude the first element (it has already been "jumbled") from the domain. On the third iteration, swap the third element with another element picked at random, but exclude the first two elements from the domain. Rinse, and repeat.

Also, don't call srand() (the first line in the body of your loop) multiple times. Pull it out of the loop and only call it once. I believe this is a FAQ.

HTH

Look up bubble sorting. Your basically looking to do the same thing... except your really bubble randomizing...

You can do what you want very easily with the C++ Standard Template Library:

Code:

---

#include<iostream>
#include<string> begin(), end()
#include<algorithm> //random_shuffle()
#include<ctime> //time()

using namespace std;

int main()
{
        srand(time(0));
       
        //shuffle the whole string:
        string str = "hello";
        random_shuffle(str.begin(), str.end());
        cout<<str<<endl;

        //shuffle part of the string:
        str = "hello world";
        random_shuffle(&str[6], str.end()); //only shuffles 'world'
        cout<<str<<endl;

        return 0;
}

---

Pssh... random_suffle... what a buzz kill.