single File Pointer to Multiple Files

Code:

---


int main(int argc, char *argv[])
{
int ReadFile=argc-1;
while(ReadFile!=1)
{
      FILE *pPoint = fopen (argv[ReadFile],"r");
      if (pPoint==NULL)
                  return 0;
.
....
.... do something


        fclose (pPoint);                                       
        printf("\n\n");
        ReadFile=ReadFile-1;                                       
        fflush(pPoint);
}

---

it does print the first file, after that it gives blank for other files

forgot to reset variable

Quote:

---

Originally Posted by dayknight

forgot to reset variable

---

What variable?

Anyway, here's my suggestions...

First of all, you shouldn't fflush() a closed pointer or a file that's only opened for reading for that matter. I'm not sure why it's there in the first place anyway. Did you add it in for some sort of troubleshooting?

Secondly, what happens if argc is 1 to start? You'll be looping through all sorts of negative indexes for argv[] which is not good. Use > 0 instead of != 1.

Thirdly, this loop would be a lot more clear if you used for() instead of while(). Did you mean to show the files in reverse order? Try writing it like this instead:

Code:

---

for(ReadFile = argc - 1;ReadFile > 0;ReadFile--)
{
  // open the file
  // process it
  // close it
}

---

Why are you fflush'ing it after you fclose it?
Your question could use some more information too.

> if (pPoint==NULL)
In addition to the the flushing a closed file, how about printing an actual message "could not open file", and perhaps use perror() to tell you why you couldn't open a file.