Gen. Rand. numb.s

I need help creating random numbers, as the title tells (sort of). I am really quite new to C++ and would like some answers for making the numbers. My problem is simple. I am making an sort of D&d/NWN/RPG, if you are familliar with this sort of gameplay, I am sure you will understand what I am doing. I actually have my source code on another computer and am currently trying to find the means to transfer it to this computer but many of you might know how to help me without looking at my code:
My objective is this:
I want to create a random number that is a varible in which I can change over time within my code. Apparently for me it doen't work. For the game I am creating it is essential that I change the code through the time because the random number stands for my dmg while fighting. (Ex. 1d4, or one "roll" of a dice of four) I need this as my character increases in skill and upgrades his weapons.

I also have another problem. In the game I have to also make a roll that it one roll of twenty, i must add this to my attack bonus and use this to see if I make a hit. ( If this all seems confusing, it is from many RPG's, WARNING: you will lose your life if you get these games because you will be so addicted, JK) what I do is i must compare this against my enemy's AC (Armor Class) to see if i hit him. This all works for me, but my enemy seemes to be unable to hit me no matter how low my ac is.

One last problem. when I finally calculate the damage I make (no matter how absurd it may be) I can't find a way to subtract it from my enemy's HP (I do not mean how to display it, just how to acutally subtract the value of the damage from the enemy's HP.

If anyone has ran into these walls and knows how to beat them please tell a new programmer the answers to these petty questions. If you wish to see my source code, I will try to put it up on the forms, ANY help would be greatly apriciated.

oh, I just reread the post, if you can't make sense of this without seeing my code I will get it up Asap. Sorry

Taken from FAQ this should work.

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <ctime>
#include <iostream>

int GetRand(int min, int max);

using namespace std;

int main()
{
  int i, r;
 
  for (i = 0; i < 20; i++)
  {
    r = GetRand(1, 6);//the bounds of the dice
   
    cout<<"Your number is "<<r<<endl;
  }
  int stop;
  cin>>stop;
 
  return 0;
}



int GetRand(int min, int max)
{
  static int Init = 0;
  int rc;
 
  if (Init == 0)
  {
    /*
    *  As Init is static, it will remember it's value between
    *  function calls.  We only want srand() run once, so this
    *  is a simple way to ensure that happens.
    */
    srand(time(NULL));
    Init = 1;
  }

  /*
  * Formula: 
  *    rand() % N  <- To get a number between 0 - N-1
  *    Then add the result to min, giving you
  *    a random number between min - max.
  */ 
  rc = (rand() % (max - min + 1) + min);
 
  return rc;
}

---

:confused: Hmm, I'll look at it, though I'm not sure I totally understand it,
if you have any other suggestions, please tell me, Thanks! :D

I have other suggestions but they are even more complicated.

The mersenne twister is one of my favourites, but unfortunately the example taken from FAQ is about as simple as it gets in c++.

Invariably, other languages have random number utilities which are more straight forward - matlab for example.

However, in c++ its more or less up to the user to construct a random number generator which they are satisfied with. In most cases, as in the example I have given, the random numbers generated are just fine.

However, for more sophisticated methods you have to look else where.

For more information on pseudo random number generators in c++ go google for answers.

You will come across the idea of creating a *seed* and other stuff. My advice would be to just use the example and take it at face value. It's already in a function so it should be easy to use.

When you are more confident perhaps you can start looking to more advanced random number generators.

:confused:

Yeah, apperently thats what I got, because I used a RAND_MAX type way of doing it and the stuff with Srand is the seed. Unfortunately, no matter how much I comnprehended that version of creating numbs it always seemed to have a loophole that I couldn't tell how to fix. (I.E. in my game, when I hit it generates a random numb not between six or four but between the regular randmax
C++ is fairly confusing (for me ) when it comes up to this, but tanks for your help! :)

Post a section of your code perhaps for the board to peruse.

I'm sure someone will be able to help you.

Quote:

---

Originally Posted by treenef

Post a section of your code perhaps for the board to peruse.

I'm sure someone will be able to help you.

---

Thats just the thing I am trying to do, my **** **** *** *** *** **** *** @)(!)*!ing laptop won't even recognise a CD when its in it, So frustrating!
i hope to have it up soon..
thanks

Quote:

---

Originally Posted by Dkunsberg

Thats just the thing I am trying to do, my **** **** *** *** *** **** *** @)(!)*!ing laptop won't even recognise a CD when its in it, So frustrating!
i hope to have it up soon..
thanks

---

oh, and how do you tag code?

Ya know what? I'm gonna write down my code, if you need info from other parts of the code, tell me and I'll give it to you.

Here:

Code:

---

Void Fight (int estrike, int btd, int enemyhp, int hp, int attack, int ac, int enemyattack, int enemyac, int enemydmg, int dmg, int strike, int td, int enemytd)
/* estrike stands for enemy strike, btd= bonus total damage,      hp=health points, ac=armor class, and td =total possible damage.*/
{
cout << "you engage in a fight against the enemy:\n";
while (enemyhp>0 && hp>0
{
cout << "you attack your enemy: "
const int N = 21;
strike = (int) N * rand() / (RAND_MAX + attack);
cout << strike << endl;
cin.get();
if (strike>enemyac)
dmg=(int) td * rand() / (RAND_MAX =btd);
while (dmg>0)
{
dmg--;
enemyhp--;
// to basically subtract damage from the enemy's HP.
}
/*etc, etc, etc, thats basically it, its the same thing for my enemy except with all different varibles. */

{

---

there ya have it, my messy noobish and completely messed up code.
btw... if there are any typo's by pass them, I can ACTUALLY RUN THIS THING :eek: haha, but it doesn't work the way I want it too. :p , uh :) uhh :( opps, i mean :mad: (the progression to the state of madness)
Help me if you can please.
Thanks! keep postin'!

> (RAND_MAX =btd);
Is that = a typo, or is the real code like that?

Also, are you wanting to add btd to the random number? In that case it would be:

Code:

---

dmg=(int) td * rand() / RAND_MAX + btd;

---

Or better would probably be:

Code:

---

dmg=(int) (td * (double) rand() / RAND_MAX + btd);

---

>I can't find a way to subtract it from my enemy's HP (I do not mean how to display it, just how to acutally subtract the value of the damage from the enemy's HP.

Did you try:

Code:

---

enemyhp = enemyhp - dmg;

---

hmm maybe.... I have been thinking, wat if i used the rand()%11 thing to create a function for each weapon I used, thereby being able to change the dice roll as the weapon is upgraded or increased

Quote:

---

Originally Posted by swoopy

> (RAND_MAX =btd);
Is that = a typo, or is the real code like that?

Also, are you wanting to add btd to the random number? In that case it would be:

Code:

---

dmg=(int) td * rand() / RAND_MAX + btd;

---

Or better would probably be:

Code:

---

dmg=(int) (td * (double) rand() / RAND_MAX + btd);

---

>I can't find a way to subtract it from my enemy's HP (I do not mean how to display it, just how to acutally subtract the value of the damage from the enemy's HP.

Did you try:

Code:

---

enemyhp = enemyhp - dmg;

---

---

OK, for starters, Thanks, The subtraction thing works well. I have another problem instead. As you see in my "while" loop the fighting should continue until one of us goes to or below Zero, correct, un fortunately, it stops after a few rounds of fighting. In addition it does seem to do anything random, it will generate numbers but they same numbers come up each time, so now I have four problems

"One step forward, two steps backward."
But anyway thanks alot for the suggestions, and keep 'em comin....

Please!
:D

Thanks
David

> it stops after a few rounds of fighting.
Maybe hp or enemyhp became <= 0. You can cout them to see for yourself.

>it will generate numbers but they same numbers come up each time
You need an srand(time(NULL)) at the beginning of main() to seed the random number generator. See this FAQ entry:

• How do I... (Level 1) Generate random numbers?

Quote:

---

wat if i used the rand()%11 thing to create a function for each weapon I used, thereby being able to change the dice roll as the weapon is upgraded or increased

---

That's a very good idea. One thing though. From what I've read:

Code:

---

rand()%11

---

is not supposed to be quite as random as:

Code:

---

rand()*11/(RAND_MAX+1)

---

But you probably shouldn't worry about that until you get a working game. Then maybe you can tweak the rng.

Quote:

---

Originally Posted by swoopy

> it stops after a few rounds of fighting.
Maybe hp or enemyhp became <= 0. You can cout them to see for yourself.

>it will generate numbers but they same numbers come up each time
You need an srand(time(NULL)) at the beginning of main() to seed the random number generator. See this FAQ entry:

• How do I... (Level 1) Generate random numbers?

That's a very good idea. One thing though. From what I've read:

Code:

---

rand()%11

---

is not supposed to be quite as random as:

Code:

---

rand()*11/(RAND_MAX+1)

---

But you probably shouldn't worry about that until you get a working game. Then maybe you can tweak the rng.

---

cool! Thanks alot! Two things- first, for srand (time(NULL)) I need #include <ctime> right, if not, what do I use.
also, no, apperently, with my old random number generater, it seemingly only did really large (Or should I say really small?) negative numbers. so my my enemy would be getting like 7E10 hp each hit. A little unfair don't you think, I have no idea why it would quit off.
Thanks,
P.S. How do you name char strings? (I mean not the player, but the programmer so I can include the name of my enemy within the fight seceunce by simply naming a char string before hand)
David

>Two things- first, for srand (time(NULL)) I need #include <ctime> right
Right. I just tried it with my borland compiler, and interestingly it compiled without that header, but I think it's better to include it for completeness.

Quote:

---

with my old random number generater, it seemingly only did really large (Or should I say really small?) negative numbers. so my my enemy would be getting like 7E10 hp each hit. A little unfair don't you think

---

To say the least. :D

Quote:

---

P.S. How do you name char strings? (I mean not the player, but the programmer so I can include the name of my enemy within the fight seceunce by simply naming a char string before hand)

---

I would recommend using a string. For example:

Code:

---

string enemy_name = "Dragon";
.
.
cout << enemy_name << " attacks!" << endl;

---

Code:

---

//New Problems now, Fortunately, there are only two left!
cin >> Problems;
switch (Problems)
{
case 1:
cout << "my first problem now is that I nor my enemy can hit each other, and the program just goes on and on ( at least we fixed the end early problem)" << endl;
break;
case 2:
cout <<  "my second problem is that I am unable to seed the first number, and it remains three each time." << endl;
break;
}
cout << " Please help!!!! \nThanks\nDavid" << endl;
/* I'm hoping you will understand this, feel free to correct any errors  :D */

---

Quote:

---

Originally Posted by swoopy

>Two things- first, for srand (time(NULL)) I need #include <ctime> right
Right. I just tried it with my borland compiler, and interestingly it compiled without that header, but I think it's better to include it for completeness.
To say the least. :D

I would recommend using a string. For example:

Code:

---

string enemy_name = "Dragon";
.
.
cout << enemy_name << " attacks!" << endl;

---

---

Great Thanks!!

>my first problem now is that I nor my enemy can hit each other, and the program just goes on and on
The best way to debug this is to print out the values for each variable to determine what's happening. Or you can use a debugger. Or you can post your complete code. Otherwise it's a guessing game.

>my second problem is that I am unable to seed the first number, and it remains three each time.
Make sure that:

Code:

---

srand(time(NULL));

---

is called only once, at the beginning of main().

Quote:

---

Originally Posted by Dkunsberg

New Problems now, Fortunately, there are only two left!

---

Maybe ">>"

Code:

---

cin << problems;

---

Spelling?

Code:

---

switch (Problems)

---

You could have just read the FAQ on random number generation...


Quzah.

first of all, all of what you guys said I either know or have tried. First, I did display my attack and I did get random numbers between 1-20, as I expected, but no matter how high I hit I always missed. Second, that cin thing was a typo and I know, third, I have tried the FAQ and the tutorial but neither of them seem to work when I convert it into my program.
I am still trying to get my code, it will still be on schedule: ASAP.

Thanks!
David!

I think that I have found the source of my problems, if you look on the previous page at the source code I posted, you can see that I wanted to generate a random number between 0-20+ my attack bonus. unfortunately, when I try this, no matter how high I set my AB, the random number is not affected and still cannot beat my enemy's AC no matter how low I set it. It always seems that it takes the second choice, the one where I miss. originally, this worked, but now, after I changed the way the number was generated for the dmg, it no longer lets me hit, How should I resolve this? :confused:

Thanks for everting so far!
David :D

>no matter how high I set my AB, the random number is not affected and still cannot beat my enemy's AC no matter how low I set it
That's because you're dividing by the attack bonus, not adding it.

Code:

---

strike = (int) N * rand() / (RAND_MAX + attack);

---

If you look at one of my previous posts, I pointed this out in your other equation. If you want the attack bonus added to the random number between 0-20, then you want:

Code:

---

strike = N * rand() / RAND_MAX + attack;

---

Or you could also use:

Code:

---

strike = rand()%N + attack;

---

Quote:

---

Originally Posted by swoopy

>no matter how high I set my AB, the random number is not affected and still cannot beat my enemy's AC no matter how low I set it
That's because you're dividing by the attack bonus, not adding it.

Code:

---

strike = (int) N * rand() / (RAND_MAX + attack);

---

If you look at one of my previous posts, I pointed this out in your other equation. If you want the attack bonus added to the random number between 0-20, then you want:

Code:

---

strike = N * rand() / RAND_MAX + attack;

---

Or you could also use:

Code:

---

strike = rand()%N + attack;

---

---

Okay right now I have:

Code:

---

const int N = 21;
strike=rand()%N+attack;
cout << strike<< endl;
cin.get();
if (strike>enemyac)
{
//etc not the problem now
}
if (strike<enemyac)
cout << "You attempt to strike the opposition, but fail to damage your enemy.";

---

thats it for that.
What is happening
BTW, I am recieving no errors so if you find something that won't work it is probably a typo.

>strike=rand()%N= attack;
I hope the second = is a typo.

strike will be some number between 0 and N-1 (20), not counting attack. So if enemyac is less than N-1 (20), at some point the following will become true:

Code:

---

if (strike>enemyac)

---

Quote:

---

Originally Posted by swoopy

>strike=rand()%N= attack;
I hope the second = is a typo.

strike will be some number between 0 and N-1 (20), not counting attack. So if enemyac is less than N-1 (20), at some point the following will become true:

Code:

---

if (strike>enemyac)

---

---

:)
Yes! but it doesn't, and that is why I am so ****ing messed up!
This has been the problem, and as you can see I edited it while you were typing up your message. I don't get why! There is no possible reason why this would happen, is it something I previously did within the code, how would that affect what I am doing.
I think I can get the code up real soon
David

I would recommend making a simple program to print out values of rand().

Code:

---

#include <cstdlib>
#include <iostream>
using namespace std;

const int N = 21;

int main()
{
  srand(time(NULL));

  for (int i=0; i<100; ++i)
  {
      cout << rand() % N << " ";
      if ((i+1)%10 == 0)
        cout << endl;
  }
  return 0;
}

---

That should give you values between 0 and 20. If that works, then you take it a step further. Throw it in a function with the attack bonus, then print that. Take it step by step.

Also make sure you include <cstdlib> for the rand() function.

Finally! got it!
here it is (for what its worth)
please see if this helps you.

Code:

---

#include <cstdlib>
#include <ctime>
#include <iostream>


using namespace std;
void levelup (int level, int spec, int Select, int Dexterity=0, int Strength=0, int Wisdom=0, int Charisma=0, int Intelligence=0,int Constitution=0, int lvlselect=0, int magic=0, int sword=0, int bow=0, int reflex=0, int will=0);
void Fight (int btd, int estrike, int enemytd ,int tdr, int tdh, int tdl, int enemyhp,int hp,int attack,int ac,int enemyattack, int enemyac, int enemydmg, int dmg, int strike);

int main()
{
        char name[256];
                int btd, enemyhp, tdl, tdh, tdr, estrike, enemytd, hp, attack, ac , enemyattack, enemyac, enemydmg, dmg, Select=0, spec=1, strike=0, Dexterity=0, Strength=0, Wisdom=0, Charisma=0, Intelligence=0, Constitution=0, lvlselect=0, level=0, magic=0, sword=0, bow=0, reflex=0, will=0;
        srand(time(NULL));
        cout << "So, what's your name?" << endl;
        cin.getline ( name,256, '\n' );
        cout << "Your name is " << name << ", right?" << endl;
        cout << "Awesome! " << name << ", now we can start!" << endl;
        cout << "it is now time to choose your skills (to level-up press enter)" << endl;
        cin.get();
        level=0; lvlselect=1;
        levelup ( level, Select, Dexterity, Strength, Wisdom, Charisma, Intelligence, Constitution,
                lvlselect, magic, sword, bow, reflex, will, spec); cin.get();
        btd=1; enemytd=4; tdl=1; tdh=10; tdr=(tdh-tdl)+1; enemyhp=70; hp=70; attack=200; ac=10; enemyattack=2; enemyac=10;
        Fight ( btd, estrike, enemytd, tdr,  tdl, tdh, enemyhp, hp, attack, ac, enemyattack, enemyac, enemydmg , dmg, strike);
        return 0;
       

}

void levelup (int level, int Select,  int Dexterity, int Strength,
                          int Wisdom, int Charisma, int Intelligence, int Constitution,
                          int lvlselect,int magic,int sword,int bow,int reflex,int will, int spec)
{
        cout << endl <<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl<<endl;
        cout << "Level Up!" << endl;
        cout << "Welcome to the level up screen! You are now level: "<< level << endl;
        cout << "As you have just leveled up, you are able to increase one basic skill, and gain training in one specific skill.\n";
        cout <<  lvlselect << " point(s) remaining in basic skills:" << endl;
        cout << "1. Increase your Strength."<< endl;
        cout << "2. Increase your Dexterity." <<endl;
        cout << "3. Increase your Constitution.\n";
        cout << "4. Increase your Intelligence.\n";
        cout << "5. Increase your Wisdom.\n";
        cout << "6. Increase your Charisma.\n";
        cin>>Select;
        switch ( Select ) {
        case 1:
                cout << "You have improved your strength"; Strength++;
                --lvlselect;
        if (lvlselect>0)
                levelup ( level, Select, Dexterity, Strength, Wisdom, Charisma, Intelligence, Constitution, lvlselect, magic, sword, bow, reflex, will);
                break;
        case 2:
                cout << "you have improved your dexterity"; Dexterity++;
                --lvlselect;
        if (lvlselect>0)
                levelup ( level, Select, Dexterity, Strength, Wisdom, Charisma, Intelligence, Constitution, lvlselect,magic,sword,bow,reflex,will);
                break;
        case 3:
                cout << "You have improved your constitution"; Constitution++;
                --lvlselect;
        if (lvlselect>0)
                levelup ( level, Select, Dexterity, Strength, Wisdom, Charisma, Intelligence, Constitution, lvlselect,magic,sword,bow,reflex,will);
                break;
        case 4:
                cout << "You have improved your intelligence"; Intelligence++;
                --lvlselect;
        if (lvlselect>0)
                levelup ( level, Select, Dexterity, Strength, Wisdom, Charisma, Intelligence, Constitution, lvlselect,magic,sword,bow,reflex,will);
                break;
        case 5:
                cout << "You have improved your wisdom"; Wisdom++;
                --lvlselect;
        if (lvlselect>0)
                levelup ( level, Select, Dexterity, Strength, Wisdom, Charisma, Intelligence, Constitution, lvlselect,magic,sword,bow,reflex,will);
                break;
        case 6:
                cout << "you have improved your charisma"; Charisma++;
                break;
        default:
                cout<<"Haha, very witty, no skills for you lameo";
                --lvlselect;
        if (lvlselect>0)
                levelup ( level, Select, Dexterity, Strength, Wisdom, Charisma, Intelligence, Constitution, lvlselect,magic,sword,bow,reflex,will);
                break;
        }
        cout << "\nYou are now allowed to train in 1 specific skill:\n";
        cout << "1. Train in Magic\n";
        cout << "2. Train in Swords\n";
        cout << "3. Train in Bows\n";
        if (level>0)
        cout << "4. Train in Will\n";
        if (level>0)
        cout << "5. Train in Reflex\n";
        cin >> spec;
        switch ( spec )
        {
        case 1:
                cout << " You practice with magic and get better at it"; magic++;
                break;
        case 2:
                cout << "You train in swords\n"; sword++;
                break;
        case 3:
                cout << "Your skill with bows has gotten better\n"; bow++;
                break;
        case 4:
                cout << "Your mental willpower has increased\n"; will++;
                break;
        case 5:
                cout << "Your instant reflexes have been improved\n"; reflex++;
                break;
        default:
                cout << "No skills for you now, real funny!";
                break;
        }

                cout << "\nYour skills are currently as follows:\n";
                cout << "Strength: " << Strength << "\n";
                cout << "Dexterity: " << Dexterity << "\n";
                cout << "Constitution: " << Constitution << "\n";
                cout << "Intelligence: " << Intelligence << "\n";
                cout << "Wisdom: " << Wisdom << "\n";
                cout << "Charisma: " << Charisma << "\n";
                cout << "Magic: " << magic << "\n";
                cout << "Swordsmanship: " << sword << "\n";
                cout << "Bowmanship: " << bow << "\n";
                cout << "Will: " << will << "\n";
                cout << "Reflexes: " << reflex << "\n";
}

void Fight (int estrike, int btd, int enemyhp,int hp,int attack,int ac,int enemyattack, int enemyac, int enemydmg, int dmg, int strike, int tdr, int tdl, int tdh, int enemytd)
{
        cout << "You engage in a fight against the enemy!\n";
        while (enemyhp>0 && hp>0)
        {
        cout << "You attack your enemy: ";
        const int N = 21;
                strike=rand()%N + attack;
        cout << strike << endl;
        cin.get();
        if (strike>enemyac)
        {
                dmg= tdl+int(tdr*rand()/(RAND_MAX+btd));
                cout << "A hit!\n";
                cout << "you do " << dmg << "damage.\n";
                enemyhp=enemyhp - dmg;
                        cout << enemyhp << hp;
                cin.get();
        }
        if (strike<enemyac)
                cout << "you attempt to strike the opposition, but fail to damage your enemy." << endl;
        cout << "Your enemy attacks you: ";
                strike=rand()*21/ (RAND_MAX + 200);
        cout << estrike << endl;
        cin.get();
        if (estrike>ac)
        {
                enemydmg = (int) enemytd * rand()/(RAND_MAX +1.0);
                cout << "A hit!\n";
                cout << "your enemy does " << enemydmg << "damage.\n";
                hp=hp-enemydmg;
                cin.get();
        }
        else
                cout << "Your enemy misses you." << endl;
        }
        if (enemyhp==0)
                cout << "You strike down your enemy!" << endl;
        if (hp==0)
        {
                cout << "Your enemy strikes at you, and you fall to the ground and die. Sorry! Nice try!" << endl;
        }
}

---

There it is,
please refer to see if you find any problems
Thanks
David

Your parameters don't seem to match:

Code:

---

Fight ( btd, estrike, enemytd, tdr,  tdl, tdh, enemyhp, hp, attack, ac, enemyattack, enemyac, enemydmg , dmg, strike);
.
void Fight (int estrike, int btd, int enemyhp,int hp,int attack,int ac,int enemyattack, int enemyac, int enemydmg, int dmg, int strike, int tdr, int tdl, int tdh, int enemytd)

---

For example, in Fight(), enemyac is the same as hp in the function call (the 8th parameter), which is 70. Maybe that's what you want, but seems confusing to me.

Yeah, but, the way I see it, my code is perfectly legit. What is causing it to screw up like this? My code works fine but still it is screwed up, sometime i should definititly be able to hit my enemy, and vice-versa. Why did it work before I changed the random number generator inside?

ANYONE who can see my mistake would be increidibly kind to correct me.

Thanks,
David

Quote:

---

Originally Posted by Dkunsberg

Yeah, but, the way I see it, my code is perfectly legit.

---

Yes, but it is probably not your intention?

Quote:

---

Originally Posted by Dkunsberg

What is causing it to screw up like this? My code works fine but still it is screwed up, sometime i should definititly be able to hit my enemy, and vice-versa. Why did it work before I changed the random number generator inside?

---

The previous post has your answer. If not at least something worth pursuing and fixing.

Quote:

---

Originally Posted by Dkunsberg

ANYONE who can see my mistake would be increidibly kind to correct me.

Thanks,
David

---

Ok add this to main just before your call to fight,

Code:

---

        cout << "\n\nIn main!!\n"
                << "btd = " << btd
                << "\nestrike = "<< estrike
                << "\nenemytd = " << enemytd
                <<  "\ntdr = " << tdr
                << "\ntdl = " << tdl
                << "\ntdh = " << tdh
                << "\nenemyhp = " << enemyhp
                << "\nhp = " << hp
                << "\nattack = " << attack
                << "\nac = " << ac
                << "\nenemyattack = " << enemyattack
                << "\nenemyac = "<< enemyac
                << "\nenemydmg = " << enemydmg
                <<  "\ndmg = " << dmg
                << "\nstrike = " << strike << endl;
        Fight ( btd, estrike, enemytd, tdr,  tdl, tdh, enemyhp, hp, attack, ac, enemyattack, enemyac, enemydmg , dmg, strike);

---

Now add this to your function fight,

Code:

---

void Fight (int estrike, int btd, int enemyhp,int hp,int attack,int ac,int enemyattack, int enemyac, int enemydmg, int dmg, int strike, int tdr,  int tdl,  int tdh, int enemytd)
{
        cout << "\n\nIn Fight!!\n"
                << "btd = " << btd
                << "\nestrike = "<< estrike
                << "\nenemytd = " << enemytd
                <<  "\ntdr = " << tdr
                << "\ntdl = " << tdl
                << "\ntdh = " << tdh
                << "\nenemyhp = " << enemyhp
                << "\nhp = " << hp
                << "\nattack = " << attack
                << "\nac = " << ac
                << "\nenemyattack = " << enemyattack
                << "\nenemyac = "<< enemyac
                << "\nenemydmg = " << enemydmg
                <<  "\ndmg = " << dmg
                << "\nstrike = " << strike << endl;
        cout << "You engage in a fight against the enemy!\n";

---

They should have the same output. Do they? If not this might be your problem.