need help with building DLL

This is just one of the functions im making for a 3rd party DLL for a different language.

Code:

---

#ifndef EXPORT
#define EXPORT __declspec (dllexport)
#endif

// MESSAGE BOX OK ////////////////////////////////////////////
EXPORT void XSDKMESSAGEBOX_OK(LPSTR smessage, LPSTR stitle)
{

        if(smessage != "")
        {
                MessageBox(NULL,smessage,stitle,MB_OK);
        }
        else if(smessage == "")
        {
        MessageBox(NULL, "Error Code MBO162: \"LPSTR smessage\" is invalid.",
 "XSDK Error", MB_OK | MB_ICONSTOP);
        }

}

---

Now everything compiles just fine, but when I go to use it, and i enter "" for the message, it is still displaying the normal box and now the error box. Is something wrong with my logic, or something else.

You can't do comparisons like that with char arrays. You can with the STL string class, but that's a different ball game. Try using

Code:

---

smessage[0]!='\0'

---

instead of your first comparison, and then just an else instead of an else if.

ok now how about this one. When the users enters the correct word, it goes to the error screen. If i entered "OK" where smessage goes, it would give me an error.

Code:

---

// MESSAGE BOX //////////////////////////////////////
EXPORT void XSDKMESSAGEBOX(LPSTR smessage, LPSTR stitle, LPSTR sicon, LPSTR stype)
{

        if(smessage != "")
        {
                if (stype == "OK")
                {
                        if(sicon == "EXCLAMATION")
                        {
                                MessageBox(NULL,smessage,stitle, MB_OK | MB_ICONEXCLAMATION);
                        }
                        else if (sicon == "INFORMATION")
                        {
                                MessageBox(NULL,smessage, stitle, MB_OK | MB_ICONINFORMATION);
                        }
                        else if (sicon == "QUESTION")
                        {
                                MessageBox(NULL,smessage, stitle, MB_OK | MB_ICONQUESTION);
                        }
                        else if (sicon == "STOP")
                        {
                                MessageBox(NULL,smessage,stitle, MB_OK | MB_ICONSTOP);
                        }
                        else
                        {
                                MessageBox(NULL,"Error Code MBME160: \"LPSTR sicon\" is invalid.", "XSDK Error", MB_OK | MB_ICONSTOP);
                        }
                }
                else if (stype == "OKCANCEL")
//..... and so on

---

never mind i got it :P

Quote:

---

Originally Posted by Frantic-

never mind i got it :P

---

Well done. Presumably, when you "got it" you realised that you either need to use std::string or compare strings using strcmp().

What you described is a pretty common problem encountered by many beginners. Even though this sort of thing is covered pretty early on in most introductory texts, few beginners seem to read that far before they try cutting code.

ive read my sams teach your self c++ in 24 hours cover to cover, and took a computer programming class and learned c++ for a small part of it, most of it was in JAVA. And if you are infering that I got the code from some where else your wrong, I wrote it my self! :p

I wasn't inferring anything about whether you wrote your code or got it from somewhere else. I was simply noting that you experienced a problem that bites most beginners to C++ (and C), and what the solution is (which presumably you "got", although you didn't say it outright).