Help parsing

Code:

---

#include <stdio.h>
#include <string.h>

char *trim(char *);

int main(void)
{
        int i, j, length;
        char name[20];
        char actors[] = "Kate Winslet, Johnny Depp, Morgan Freeman, Tom Hanks";

        j = 0;
        length = strlen(actors);

        for(i = 0; i < length; i++){
               
                if(actors[i] != ','){
                        name[j] = actors[i];
                        j++;
                }

                else{
                        name[j] = '\0';
                        printf("%s\n", trim(name));
                        j = 0;
                }
        }

        return 0;
}

char *trim(char *array)
{
    int i;
   
    for(; *array == ' '; array++);
   
    i = strlen(array);
   
    while((--i > 0) && (array[i] == ' '))
        array[i] = 0;
   
    return array;
}

---

This code won't display Tom Hank's name. How can i fix it? Thank you.

For this you could use strtok like this. I didn't compile and test it but it should give you an idea.

Code:

---

char *ptr
ptr=strtok(Actors, " ,\n");
while (ptr!=NULL)
{
        while(*ptr==' ')ptr++;
        printf("%s\n", ptr);
        ptr=strtok(NULL, ",\n");
}

---

Edited to fix bug

It worked. Thank you.
I have one question though: why did you use NULL instead of actors when you called strtok inside the while loop?

char actors[] = "Kate Winslet, Johnny Depp, Morgan Freeman, Tom Hanks,";

Tell me what I changed in that string - which caused your program to print "Tom Hanks" :p

xeddiex.

man strtok
caduardo21
When calling strtok the second time I use NULL to specify that I'm still working on the same sting, strtok keeps a static variable with the curent potision in the string.

Quote:

---

Originally Posted by caduardo21

This code won't display Tom Hank's name. How can i fix it? Thank you.

---

Your loop stops after the last char in the string (not the terminating '\0', but the 's' in Hanks). So the last name in the string is not printed.

so you could change the loop expression to this:

Code:

---

for(i = 0; i <= length; i++){

---

Now, in order to recognize the end of the last name in the string, it's not a comma you are looking for, but a '\0'. You could try this so that the else part gets to terminate and print the last name:

Code:

---

        if((actors[i] != ',' ) && (actors[i] != '\0')){
                        name[j] = actors[i];
        else {

---

Regards,

Dave

the array is returned only after you identify the space bar next to a name . so, modify the progam in the following line

Code:

---

char actors[] = "Kate Winslet, Johnny Depp, Morgan Freeman, Tom Hanks, ";

---

Yes, let's not fix the function so it works and is better. Let's instead change the input to it to fit the flawed function. :rolleyes:

Quzah.