[noob] i can't even name the problem

program doesn't end loop =P

Code:

---

#include <stdio.h>

int main(void)
{
        int i,temp;
       
        for (i=1;;i++)
        {
                do {
       
                printf("Enter the temperature for day %d (-300 to end): ",i);
                scanf("%d",&temp);
               
                } while (temp=!-300);
        }
       
        return 0;
}

---

also, i have to print the hottest and the coolest day. but can't figure how to do it. because day number can be any number. just give me tips. i want to do by myself. =P

Code:

---

#include <stdio.h>

int main(void)
{
        int i,temp;
       
        for (i=1; i<=2;i++)
        {
                do {
       
                printf("Enter the temperature for day %d (-300 to end): ",i);
                scanf("%d",&temp);
               
                } while (temp=!-300);
        }
       
        return 0;
}

---

one second for the coolest and hottest day. thinking of a hint:P

Code:

---

(temp=!-300)

---

You realize that that evaluates to temp = 0 right?

I think you're looking for temp != -300 instead.

well if i put i<=2 then it will stop looping. loop have to stop while temp = -300

yea , that took my attention too , but i though i might have been a C dialect ( I'm a C++ programmer ).

Quote:

---

well if i put i<=2 then it will stop looping. loop have to stop while temp = -300

---

Get rid of the for() loop altogether then and just leave the do-while loop and increment i in the loop.

Hello,

A few issues. If you want to use a do-while loop, you can use it without the infinite for loop. Also:

Code:

---

while (temp=!-300)

---

Seems wrong, did you mean to do:

Code:

---

while (temp!=-300);

---

Here's a small hint. Keep i, but don't use a for loop. Just use your do-while loop.


- Stack Overflow

ok i removed for loop. it's unnecessary- i see...

Code:

---

#include <stdio.h>

int main(void)
{
        int i=1;
        int temp;
       
        do {
       
                printf("Enter the temperature for day %d (-300 to end): ",i);
                scanf("%d",&temp);
                i++;
       
        } while (temp!=-300);
       
        return 0;
}

---

but how can i calculate the hottest and the coolest day?.. i also have to take the average.. day number isn't constant.

First i think you have to break from the while loop, otherwise it will keep looping.After this you call the AVG() function that finds the average of the temps the user inputed. For the hottest days, after your break; you could maybe sort the values to get the bigger value thus the hottest day.

Quote:

---

Originally Posted by knoxville

but how can i calculate the hottest and the coolest day?.. i also have to take the average.. day number isn't constant.

---

You need some extra variables to keep track of the hottest and coolest days. Probably a variable that keeps track of the hottest temperature and another to keep track of the i value associated with that temperature (the day associated with the hottest temp) and another set of variables for the coolest. Initialize the hottest temperature with INT_MIN and the coolest temperature with INT_MAX.

Each time through the loop after you get the temperature for the day, check the temp against both the coolest and hottest temperatures. If the temp for the current day is cooler than the coolest temperature, you set the coolest temperature to be equal to the termperature for the current day and set the coolest day equal to whatever i is currently set to. If the temp for the current day if hotter than the hottest temperature, the you set the hottest temperature equal to the temperature for the current day and the hottest day equal to whatever i is currently set to.

You also need another variable to hold the sum of the temperature values (initialized to 0). Each temperature value gets added to this sum. At the end of the program when it comes time to do the average, you simply divide this value by whatever i happens to be at the time since that is the number of days worth of temperature values we have received from the user.

well i extended my code.. but miracle c gives a stupid "C:\Program Files\Miracle C\self\fusun.c: line 17: unrecognised types in comparison
'while (temp!=-300) { counter+=1'
aborting compile" error. =P

Code:

---

#include <stdio.h>

int main(void)
{
        float largest,smallest,average,temp,sum;
        int counter,day,x,y;
       
        smallest=0;
        largest=0;
        sum=0;
        day=1;
        counter=0;
       
        printf("Enter the temperature for day %d (-300 to end): ",day); 
        scanf("%f",&temp);
       
        while (temp!=-300)
        {
                counter+=1;
               
                if (temp>largest)
                {
                        largest=temp;
                        x=day;
                }
               
                if (temp<smallest)
                {
                        smallest=temp;
                        y=day;
                }
       
        ++day;
        sum+=temp;
       
        printf("\nEnter the temperature for day %d (-300 to end): ",day);
        scanf("%f",&temp);
        }
       
        printf("The hottest day is %d and the temperature is %f degrees celcius.\n",x,largest);
        printf("The coolest day is %d and the temperature is %f degrees celcius.\n",y,smallest);
       
        average=(float)sum/counter;
       
        printf("The average temperature over %d days is %f degrees celcius\n",day-1,average);
       
        return 0;
}

---

alright i tweaked a little. one last problem: it counts -300 as temperature. i have to use it to quit.

Code:

---

#include <stdio.h>

int main(void)
{
        int day=1;
        int cool=0,hot=0,sum=0;
        int counter,temp,x,y;
        float avg;
       
        while (temp!=-300)
        {
                printf("Enter the temperature for day %d (-300 to end): ",day);
                scanf("%d",&temp);
               
                day++;
                ++counter;
               
                if (temp>hot)
                {
                        hot=temp;
                        x=day;
                }
               
                if (temp<cool)
                {
                        cool=temp;
                        y=day;
                }
               
                sum+=temp;
        }
       
        avg=sum/day;
       
        printf("The hottest day is day %d and the temperature is %d degrees Celcius.\n",x,hot);
        printf("The coolest day is day %d and the temperature is %d degrees Celcius.\n",y,cool);
        printf("The average temperature over %d day(s) is %f degrees Celcius.\n",day-1,avg);
       
        return 0;
}

---

Code:

---

  for ( ;; )
  {
      printf("Enter the temperature for day %d (-300 to end): ",day);
      scanf("%d",&temp);
      if ( temp == -300 )
      {
        break;
      }
      /* ... */
      sum+=temp;
      ++day;
  }

---

I think you're logic is a little confused, say what you want to do in english (or your native language), take it one step further into pseudo code.

Example:

Code:

---

while temp != -300

/* while temp is not equal to -300 */

---

Which means for the while loop condition to fail, temp has to equal -300

If you want to break out the loop at any given time, you might want to think about testing for an escape character or something. Otherwise, you could always base the while condition on the number of days entered or something.

well obviously the code took -300 also as the temperature
because, it comes under the case

Code:

---

if(temp<cool)

---

so, it is better if you use a seperate statement like

Code:

---

if(temp==-300)
{
          break;
}

---

and make all the other statements else if to this statement
also put the day++ inside the else if blocks
also, while initializing the variables,
you have to put day=0.othrwise an error flags in claculating the error

for your convinience, sorry to say, i am displaying my code

Code:

---

//done in TurboC
//please see the logic
#include <stdio.h>
#include<conio.h>

void main()
{
        int day=0;
        int cool=0,hot=0,sum=0;
        int counter,temp,x,y;
        float avg;

        clrscr();
        while (temp!=-300)
        {
                printf("Enter the temperature for day %d (-300 to end): ");
                scanf("%d",&temp);

                ++counter;
                if(temp==-300)
                {
                        break;
                }

                else if (temp>hot)
                {
                        day++;
                        hot=temp; 
                        x=day;     
                        sum+=temp;
                }

                else if (temp<cool)
                {
                        day++;
                        cool=temp;     
                        y=day;         
                        sum+=temp;
                }


        }

        avg=sum/day;

        printf("The hottest day is day %d and the temperature is %d degrees Celcius.\n",x,hot);
        printf("The coolest day is day %d and the temperature is %d degrees Celcius.\n",y,cool);
        printf("The average temperature over %d day(s) is %f degrees Celcius.\n",day-1,avg);

        getch();
}

---

> but miracle c gives a stupid "C:\Program Files\Miracle C\self\fusun.c: line 17:
Miracle C is the biggest piece of crap on the net - it is NOT a C compiler, it is someone trying to flog their compiler construction homework off as a compiler. It isn't, not by a long way in any shape or form a credible C compiler. Even 20+ years old Turbo-C spanks this lousy excuse for a compiler.

The other point is to not develop your programs in the same directory structure where your compiler is installed. Create a "MyCode" in your own personal area.

You yourself a huge favour and get dev-c++ (www.bloodshed.net) and see what a real compiler will do for you. What's more, it is really FREE, not that nagware P-O-S called miracle-c.

> void main()
Nope - try again. Everyone else was getting it right in this thread.

you realize this would only count the days that are the hottest and coolest , give their average, and say that it is the average for (number of hottest days + number of coldest days -1) days?

Quote:

---

coolshyam

Code:

---

void main()
{
        int day=0;
        int cool=0,hot=0,sum=0;
        int counter,temp,x,y;
        float avg;

        clrscr();
        while (temp!=-300)
        {
                printf("Enter the temperature for day %d (-300 to end): ");
                scanf("%d",&temp);

                ++counter;// this should be initialized and used, or omitted
                if(temp==-300)
                {
                        break;
                }

                else if (temp>hot)
                {
                        day++;
                        hot=temp; 
                        x=day;     
                        sum+=temp;
                }

                else if (temp<cool)
                {
                        day++;
                        cool=temp;     
                        y=day;         
                        sum+=temp;
                }


        }

        avg=sum/day;// this isn't going to be a float
        printf("The hottest day is day %d and the temperature is %d degrees Celcius.\n",x,hot);
        printf("The coolest day is day %d and the temperature is %d degrees Celcius.\n",y,cool);
        printf("The average temperature over %d day(s) is %f degrees Celcius.\n",day-1,avg);

        getch();
}

---

---

The problem is that the variable day doesn't keep track of the total number of days, only days that are hotter than the hottest or cooler than the coolest. Then you use that number to compute the average of the temperatures that were hotter than the hottest or cooler than the coolest. Also, 0 probably isn't the best initial value for 'cool' since you aren't guarranteed to have a freezing day in your sample set. Lastly, when you divide an int by an int, the result is an int, not a float. You can cast it as a float like in one of the previous posts and do it that way if you want.

So, fixing those things, you might end up with something like

Code:

---

#include <stdio.h>

int main(void)
{
        int cool=100, counter=0, hot=0, sum=0, temp=0, x=0, y=0;
        float avg=0;
        while (1)
        {
                ++counter;
                printf("Enter the temperature for day %d (-300 to end): ", counter);
                scanf("%d",&temp);
                if(temp==-300)
                {
                        --counter;
                        break;
                }

                else if (temp>hot)
                {
                        hot=temp;
                        x=counter;
                }

                else if (temp<cool)
                {
                        cool=temp;
                        y=counter;
                }
                sum+=temp;
        }
        if(counter)
        {
              avg=(float)sum/counter;
        }
        printf("The hottest day is day %d and the temperature is %d degrees Celcius.\n",x,hot);
        printf("The coolest day is day %d and the temperature is %d degrees Celcius.\n",y,cool);
        printf("The average temperature over %d day(s) is %f degrees Celcius.\n",counter, avg);
}

---

Your last code entered would compile and generally work if you changed the test to ( temp <= -274.0 ). I don't think you need to worry about any valid entries below absolute zero. The conflict was between int and float variables.

On the other hand if you only want to enter int values, call temp an int - you can add it to a float total without conversion ( total += temp; ) the compiler will convert it for you from int to float and add it in, but it won't compare unlike variable types without you casting them
to be the same. You can also divide a float by an int ( for total/daycount ).

thanks everyone. great community =)