a little help with array to string

Hi, I'm trying to make a function that will extract a range of elements from an array and make a string out of them...program keeps crashing after exacution.... any suggestions?

Code:

---

#include <fstream.h>
#include <iostream.h>
#include <stdlib.h>
#include <string.h>

char * gav (char * arg[], int start, int end) {
    char * z;
    char * x;
    z = new char;
    x = new char;
    while (start < end) {
          z = arg[start-1];
          strcat (z,x);
          start++;
    }
    return x;
}
int main ()
{
    char * mostunleetarray[] = {"workyou"};
    char * value;
    value = gav (mostunleetarray,1,4);
    cout << value << "\n";
    system ("PAUSE");
    return 0;
}

---

> z = new char;
You don't need to allocate this at all, you just set it to point at some element of argv

> x = new char;
You need much more than one char to store a whole string, say for example
x = new char[1000];
Additionally, you need to make sure it's the empty string before you start strcat'ing to it
*x = '\0';

> strcat (z,x);
Read the manual again - your parameters are the wrong way round.

> value = gav (mostunleetarray,1,4);
At least make the parameters consistent with the array you're passing.
As it stands, you're off in no-mans land.

OK, thank you for the help. I changed what you said although i didnt quite understand this part--

Quote:

---

> value = gav (mostunleetarray,1,4);
At least make the parameters consistent with the array you're passing.
As it stands, you're off in no-mans land

---

I supose it has somthing to do with the new problem....

Code:

---

#include <fstream.h>
#include <iostream.h>
#include <stdlib.h>
#include <string.h>

char * gav (char * arg[], int start, int end) {
    char * z;
    char * x;
    x = new char[1024];
    *x = '\0';
    while (start < end) {
          z = arg[start-1];
          strcat (x,z);
          start++;
    }
    return x;
}
int main ()
{
    char * mostunleetarray[] = {"workyou"};
    char * value;
    value = gav (mostunleetarray,1,4); //why does it not take the first 4 charactors? 
    cout << value << "\n";
    //it prints 'workyou' and some oher garble, why not just the charactors 1 to 4? ('work')
    system ("PAUSE");
    return 0;
}

---

Because it takes the first 4 strings, not the first 4 characters

Code:

---

char *foo[] = { "this", "is", "an", "example", "list", "of", "strings" };
value = gav (foo,1,4);

---