check this code out

well
Trying to learn more I take this challenge,
I know its no big deal,
but Im putting in practice the things Ive learned in this bbs
Ive learn (here) more that ever in class :D

Code:

---


          #include<iostream>
          #include<cstdlib>
          #include<conio.h>
 
          using namespace std;

  int main()
                  {
                  {
        int n,data; 
        cout<<"how many  credits?? :  "<<flush;
        cin>>n;
            int sum =0;
system ("cls");  //not quite sure that its the best place
                for (int j=0;j<=n,j++)
                        {
                                cin<<data;
                            sum+=data; 
                        }
  avg = static_cast<float>(sum)/n ;
  cout<<"Ur average is  :  "<<avg<<endl; 
  cout<<"again??  Y / N"<<flush;
  cin>>op;
 system ("pause");
          }while (op!='n');
        return 0;
          }

---

there are all the errors

Code:

---

:\Documents and Settings\Propietario\Mis documentos\C++todo lo que haga\promediogrades.cpp(19) : error C2143: syntax error : missing ';' before ')'
C:\Documents and Settings\Propietario\Mis documentos\C++todo lo que haga\promediogrades.cpp(21) : error C2676: binary '<<' : 'class std::basic_istream<char,struct std::char_traits<char> >' does not define this operator or a conversion to a type acce
ptable to the predefined operator
C:\Documents and Settings\Propietario\Mis documentos\C++todo lo que haga\promediogrades.cpp(24) : error C2065: 'avg' : undeclared identifier
C:\Documents and Settings\Propietario\Mis documentos\C++todo lo que haga\promediogrades.cpp(27) : error C2065: 'op' : undeclared identifier
Error executing cl.exe.

promediogrades.exe - 4 error(s), 0 warning(s)

---

any idea???
thx in adv
love,

Abyssphobia

Perhaps the next thing to learn is how to format code
What did you use to indent your code - a random number generator?

Here are some things to try....



1.) for (int j=0;j<=n,j++)

should be

for(int j = 0; j <= n; j++) //Use ; semicolons in your for loop structure


2.) cin<<data;

should be

cin >> data; //Use the extraction operator ">>" with 'cin'


3.) avg = static_cast<float>(sum)/n ;

could be

int avg = static_cast<float>(sum)/n ; //Declare the variable "avg" (as in integer) and then intialize it

**Also, you should look in your book on how to use "set precision" when you are ready to 'cout' a float type variable. Set precision will determine how many decimal places to display.


cout<<"Ur average is : "<<avg<<endl; //You will need to 'set precision' here.


4.) cin >> op;

could be

char op = 'x'; //delcare the variable and initialize it (to eliminate "garbage data")

cin >> op; //op can now be used since it has been declared.



Also, you should try compiling your code using the preprocessor directive #include<conio> instead of #include<conio.h> The ".h" header suffix has been phased out as a c++ standard.

Hope this helps :cool:

>>The ".h" header suffix has been phased out as a c++ standard.
conio.h is not a standard header, so that change does not apply.

you probably want a do before the second { in the following snippet:

Code:

---

int main()
{
  {

---

This is my program and it run perflectly, thx a lot to everyone

Code:

---

          #include<iostream>
          #include<cstdlib>
          #include<conio.h>
 
          using namespace std;

            int main()
          {
                       
                char x ;
                       
                  do {

                          int n,data; 
               
                                         
                                 
                          cout<<"\n\how many  credits??  "<<flush;
                          cin>>n;
                   
                          int sum =0;
       
                          //    system ("cls");
                       
                                for (int j=1;j<=n;j++)
               
                                        {
                        cout<<"\n grade  "<<j<<"    "; //endl make the grade  be in the line above
                        cin>>dato;
                         
                        sum+=dato; 
                       
                }
                       
                  int avg = static_cast<float>(sum)/n ;
                       
                  cout<<"\n Ur average is  :  "<<avg<<endl; 
                       
                  cout<<"\n again??  Y / N"<<flush;
       
                  cin>>x;
                       
                system ("pause");
                         
                  }while (x!='n');
                return 0;
                  }

---

Developer Error: Confused by earlier indentation, bailing out. :rolleyes:

You really might want to look into that formatting a bit. It'll be worth it in the long run.

Quote:

---

Originally Posted by Zach L.

Developer Error: Confused by earlier indentation, bailing out. :rolleyes:

You really might want to look into that formatting a bit. It'll be worth it in the long run.

---

U r rigth, :D

Code:

---


#include<iostream>
#include<cstdlib>
#include<conio.h>
using namespace std;

int main()

  {

        char x ;
                       
          do {

                  int n,dato,sum =0; 
                          cout<<"\n\nHow much credits :  "<<flush;
                  cin>>n;
                   
                          for (int j=1;j<=n;j++)
               
                        {
                    cout<<"\ngrade/calificacion  "<<j<<"    "; //endl make the grade be in the line above
                  cin>>dato;
                         
                  sum+=dato; 
                       
                }
                       
                int avg = static_cast<float>(sum)/n ;
                       
                cout<<"\n Your average is  :  "<<avg<<endl; 
                       
              cout<<"\n again??  Y / N"<<flush;
       
              cin>>x;
                       
              system ("pause");
              system ("cls");         
          }while (x!='n');
        return 0;
          }

---

looks better???, ur opinion is pretty valuable to me???
regards,
abyss

Gettin' there... Here's my shot at it (clouded with personal preference, of course). ;)

Code:

---

#include<iostream>
#include<cstdlib>
#include<conio.h>

using namespace std;

int main()
{
  char x ;

  do
  {
      int n, dato, sum = 0;

      cout << "\n\nHow much credits :  " << flush;
      cin >> n;
                   
      for (int j = 1; j <= n; j++)
      {
        cout << "\ngrade/calificacion  " << j << "    "; //endl make the grade be in the line above
        cin >> dato;
        sum += dato; 
      }

      int avg = static_cast<float>(sum)/n ;

      cout << "\n Your average is  :  " << avg << endl; 
      cout << "\n again??  Y / N" << flush;

      cin >> x;

      system("pause");
      system("cls");         
  } while(x != 'n');

  return 0;
}

---

OOOH I wanna try

Code:

---

#include<iostream>
#include<cstdlib>
#include<conio.h>

using namespace std;

int main()
{
   
    char x ;

    do {
     
        int n, dato, sum = 0;

        cout << "\n\nHow much credits :  " << flush;
        cin >> n;
                   
        for (int j = 1; j <= n; j++) {

            cout << "\ngrade/calificacion  " << j << "    "; //endl make the grade be in the line above
            cin >> dato;
            sum += dato; 

        }

        int avg = static_cast<float>(sum)/n ;

        cout << "\n Your average is  :  " << avg << endl; 
        cout << "\n again??  Y / N" << flush;

        cin >> x;

        system("pause");
        system("cls");       
 
  }  while(x != 'n');

  return 0;

}

---

Theres my monthly dose of spam :rolleyes: