Interesting Problem: sprintf does not work

Hello All,

This is the code that does not work properly:

Code:

---

char dbszSQL[1024];

IString theStartDate("2004-01-01-00.00.00.000000"), theEndDate("2005-01-01-00.00.00.000000");

sprintf(dbszSQL, " hello %s AND %s ", theStartDate, theEndDate);

cout<< dbszSQL<< endl;

---

This is what gets printed on the screen:

hello ð%2È AND 2004-01-01-00.00.00.000000

This is what I expect:

hello Surinder 2004-01-01-00.00.00.000000 AND 2005-01-01-00.00.00.000000

After the sprintf executes I check the values for the two IString objects which look normal. My IString class is a wrapper around STL:string and I do have a conversion operator defined and this is what it looks like:

Code:

---

IString::operator char*() const
{
  return (char *) buffer.data();
}

---

now buffer is the stl string object. Does anyone know what I might be missing?

Here is the debugger printout for startDate and endDate:

Code:

---

(dbx) p theEndDate                                           
(buffer =
                  _String_base:)
              _String_val<char,std::allocator<char> >:(_Alval = ))
          (npos = 4294967295, _Ptr = "2005-01-01-00.00.00.000000", _Len = 26, _Res = 31))
(dbx) p theStartDate                                         
(buffer =
                  _String_base:)
              _String_val<char,std::allocator<char> >:(_Alval = ))
          (npos = 4294967295, _Ptr = "2004-01-01-00.00.00.000000", _Len = 26, _Res = 31))

---

What's the relationship between buffer.data() and buffer._Ptr
Because I can't see a data() in the dbx debug output.

>sprintf(dbszSQL, " hello %s AND %s ", theStartDate, theEndDate);

This should be:
sprintf(dbszSQL, " hello %s AND %s ", theStartDate(), theEndDate());

Thanks for your response but why should I have to add '()' to the end of the variable.

How do I default the conversion of an IString object to char*?

I want to be able to call sprintf like this:

sprintf(buffer, "hello %s and %s", str1, str2);

where str1 and str2 are IString objects and they automatically get converted to char* through a default conversion operator like:

IString:perator char* cost
{
return buffer.data();
}

I have this operator alongwith other conversion operators defined but it does not automatically convert to char* in the above case.

>Thanks for your response but why should I have to add '()' to the end of the variable.
You shouldn't.

>How do I default the conversion of an IString object to char*?
Try making a function which returns a char *. Like getChar() or something.

>Thanks for your response but why should I have to add '()' to the end of the variable.

It would call this member function which you posted:

Code:

---

IString::operator char*() const
{
  return (char *) buffer.data();
}

---

>How do I default the conversion of an IString object to char*?
Good question. I'm afraid I don't know the answer.

Mr. XSquared,

I want to be able to call sprintf like this:

sprintf(buffer, "hello %s and %s", str1, str2);

so why are you telling me to write another function that returns a char*. All I am asking is how to make the above call work and I know that it is possible.

Thanks!

Post a short example program that doesn't work. That way everyone can compile, test, and stop guessing.

[edit] Nevermind that..

Post the code and I'll take a look. Specifically your IString implementation.

As per popular demand here it is:

The stripped version of my IString class:

Code:

---

///////////////////////////////////////////////////////////////////////
// istring.hpp
///////////////////////////////////////////////////////////////////////
#include <string>
#include <istream>

using namespace std;

class IString
{
        private:
                string buffer;
               
        public:
       
                IString();
                IString (char* str);
                IString(const char* pChar);
                operator char*          ( ) const;
};



///////////////////////////////////////////////////////////////////////
// istring.cpp
///////////////////////////////////////////////////////////////////////
#include <istring.hpp>

IString::IString()
{
}

IString::IString(char * str)
{
        buffer = str;
}

IString::IString(const char* pChar)
{
        buffer = pChar;
}

IString::operator char*() const
{
        return (char *) buffer.data();
}

---

This is the code that calls it:

Code:

---

#include <iostream>
#include <fstream>
#include <istring.hpp>

using namespace std;
using std::ifstream;


int main()
{
char dbszSQL[1024];
IString theStartDate("2004-01-01-00.00.00.000000"), theEndDate("2005-01-01-00.00.00.000000");
sprintf(dbszSQL, " hello IString %s AND %s ", theStartDate, theEndDate);

cout<< dbszSQL<< endl;
cout<<theStartDate<<endl;
cout<<theEndDate<<endl;
return(0);

}

---

This is the output I get:

hello IString D AND 2004-01-01-00.00.00.000000

This is the output I expect:

hello IString 2004-01-01-00.00.00.000000 AND 2005-01-01-00.00.00.000000

Force the conversion with a cast.

Code:

---

sprintf(dbszSQL, " hello IString %s AND %s ", (char *)theStartDate, (char *)theEndDate);

---

And you should also consider using c_str() on this line

Code:

---

return (char *) buffer.data();

---

data() isn't guaranteed to return a valid null terminated string, but c_str() is.

Kip,

I don't want to to do that. I want to be able to call it with the objects.

Quote:

---

Originally Posted by mangoMan

Kip,

I don't want to to do that. I want to be able to call it with the objects.

---

You are calling it with the objects. However, the C I/O functions aren't very smart. They work with what you tell them to work with, and they don't look below the surface to work with what you really wanted. If you want everything to be hidden behind your back then use stringstreams instead of sprintf. Otherwise, you should consider some of the suggestions that have been offered to you because unless I'm mistaken, the code I have works while yours does not. You aren't exactly in a position to be finicky.

Kip,

I appreciate your help. But the problem is that I am working with old code that cannot be changed. I am removing an old IString class, provided by the IBM open class library, and replacing it with a new IString class wrapped around STL string that mimics the functionality of the old IBM IString class. When we use the old class sprinf works like a charm but the new class must be missing something and I can't figure out what even after digging through the IBM source code with is quite complex. Anyhow I am hoping that someone knows how to make this happen.

Thanks!

--m

This is what happens when you call sprintf with the IString object:

Code:

---

void sprintf( char** pstr);
 
//In main
IString istr = "Petter";
sprintf( static_cast<char**>(&istr) );

---

The first four bytes (on Win32) of the IString object becomes a C-style string pointer.

You see the problem? No high-level C++-conversion operators matter.

>> ...and I can't figure out what even after digging through the IBM source code ...
So you couldn't just look at the IString header to see how they did it?

Code:

---

#include <stdio.h>

struct T
{
    char *p;
};//T

int main()
{
    T t;
    t.p = "Hello World\n";

    printf("%s", t);

    return 0;
}//main

---

If you want to use std::string, you'll have to change the implementation so that the "char*" is the first data member of the class. (A horrible idea by the way...)

You shouldn't be using std::string anyways since IString provides tons of unprotected access to the string buffer itself.
std::string only returns constant pointers to the string buffer.

gg