Change a line of text eash first char to uppercase

Write a C program that reads in one line of text from the Standard input, and writes out the line with the following changes:

The first letter of all sentences in uppercase (capitalize the first letter).

There are two spaces between the end of one sentence and the following sentence (except the first sentence).
A sentence is always terminated by either a full stop (.), a question mark (?) or an exclamation mark (!), and then followed by zero or more spaces.

Code:

---

Enter a line for processing:
abc. abc? abc! abc?! abc.abc, abc
Abc. Abc? Abc! Abc?! Abc. Abc, abc

---

This is my work out, does any line in my program is having mistake or any things need to change to make the program ore effiency?

Code:

---

#include <stdio.h>
#include <ctype.h>
#define size 160

void main() {

  char charArray[size];
  int i;
  char firstupper;

  printf("Enter a line for processing:\n");
  scanf("%[^\n]",charArray);

  firstupper=toupper(charArray[0]);  /* Change first char to uppercase*/
  printf("%c", firstupper);      /* Print first char after uppercase*/

    for (i=1; i<=size; i++) {
      if (charArray[i]=='\0')    /* Stop if \n */
          break;

      if ( (charArray[i]=='.' && charArray[i+1]==' ') ||
            (charArray[i]=='!' && charArray[i+1]==' ') ||
            (charArray[i]=='?' && charArray[i+1]==' ') )  /* Check char='! ','? ','. '  or '!','?','.' following by space */
            {  printf("%c ",charArray[i]);
              i=i+2;
                  printf("%c", toupper(charArray[i]));}
        else if  ((charArray[i]=='.') || (charArray[i]=='!') || (charArray[i]=='?'))
            { printf("%c ",charArray[i]);
              i=i+1;
                  printf("%c", toupper(charArray[i]));}
        else
            printf("%c", (charArray[i]));

        }
         
  fflush(stdin);
  getchar();

}

---

> void main()
> fflush(stdin);
Read the FAQ - both these are incorrect 'C' usage.

> for (i=1; i<=size; i++)
Array subscripts for a[N] are 0 to N-1
Since you've already dealt with element 0, it should be
for (i=1; i<size; i++)

On the other hand,
for (i=1; i<strlen(charArray); i++)
would save you having to do this inside the loop

if (charArray[i]=='\0') /* Stop if \n */
The comment does not match the code either

> charArray
Well yeah, I can see that it's a char array simply from looking at the declaration.
Choose a name which reflects it's use, say
char userInputSentence[size];

> (charArray[i]=='.') || (charArray[i]=='!') || (charArray[i]=='?')
You do this twice. A function is starting to look like a nice idea to clean up the code

Code:

---

int isSentenceEnd ( char ch ) {
  return (ch=='.') || (ch=='!') || (ch=='?');
}

---

Your conditions then become say
if ( isSentenceEnd(charArray[i]) && charArray[i+1]==' ' )

Thank for your point out,I am nebie in C for just 3 month.

>I am nebie in C for just 3 month.
I'm curious why so many people say "I'm a newbie. I've only been programming for x months" all of the time in their posts. It doesn't make you look better or worse, and doesn't add anything relevant to the question.

On top of Salem's advice:

>#define size 160
Named constants really should be distinguishable from variables. The accepted convention is to use all caps for macros:

Code:

---

#define SIZE 160

---

>scanf("%[^\n]",charArray);
There's no reason to use scanf in this way. It adds nothing and takes quite a bit away. What if the user enters more than 160 characters before a newline? Fgets is a much better solution:

Code:

---

if ( fgets ( charArray, sizeof charArray, stdin ) == NULL ) {
  fprintf ( stderr, "Bad input\n" );
  /* Try again or exit gracefully */
}

---

>for (i=1; i<strlen(charArray); i++)
>would save you having to do this inside the loop
Of course, it would also be unnecessarily inefficient:

Code:

---

int len;
...
len = strlen ( charArray );
for ( i = 1; i < len; i++ )

---

Quote:

---

Originally posted by Prelude
>I am nebie in C for just 3 month.
I'm curious why so many people say "I'm a newbie. I've only been programming for x months" all of the time in their posts. It doesn't make you look better or worse, and doesn't add anything relevant to the question.

---

Simply no one likes looking like their dumb. Especailly in the midst of talented individuals regardless of the field. A preface of that kind allows us and any other newbie to feel comfortable to make mistakes and feel free to ask any questions without fear of reprecussions.:) but you knew that already. ;)

how can I modify the program to make it stop it the user press 'Enter' when asking for the line input?

> scanf("%[^\n]",charArray);
If you just press enter, what is
the value of strlen(charArray)
the return result of scanf(), which you're presently ignoring.

if I just press the enter key, the o/p is a rubbish ascii code(not alpha char) and the strlen is 3

The only reason I say I am a newbie is if I am wrong I want someone to point it out. I may believe something is true only to find out that I was misinformed or had made some incorrect assumptions.

Experts make mistakes too, but generally a newbie gets more detailed answers to questions because the level of knowledge is known to be weak where an expert is supposed to know better.

>but you knew that already.
Yes, I just wanted to hear someone else say it. :D

>if I am wrong I want someone to point it out
Don't worry, if you're wrong someone will call you on it. In fact, several someones will probably call you on it. In painful detail. With examples. And quotes. And they'll never forget. Especially if you don't often make mistakes. ;)

Quote:

---

Originally posted by Prelude
>if I am wrong I want someone to point it out
Don't worry, if you're wrong someone will call you on it. In fact, several someones will probably call you on it. In painful detail. With examples. And quotes. And they'll never forget. Especially if you don't often make mistakes. ;)

---

Been there, eh Prelude? Do I detect some slapped posts in your past? :)

>Been there, eh Prelude? Do I detect some slapped posts in your past?
Indeed. Some rather embarrassing ones too. ;)

I'd like to see some of those post Prelude:) any links(Don't Worry we know your the best;))

>I'd like to see some of those post Prelude
I couldn't hope to find any of the good ones. If you want to search all of my posts I'm sure you'll see a few. :)

more than 133 pages Wowzers, and to think I would have to go through all of that to find one or two errors!

Quote:

---

Originally posted by linuxdude
more than 133 pages Wowzers, and to think I would have to go through all of that to find one or two errors!

---

I wonder how many Salem has:D

>I wonder how many Salem has
Not nearly as many as he used to. He cleaned out a lot of the old ones some time ago, dropping his post count by several thousand.

damn those moderators. We should rally to have him put them back. Other novices might learn something from those threads.

Wish i could delete my stupid threads, like this one where i had just come from learning python and expected the C language to behave the same. What an eye opener. Nice to see i've improved a little.:D