problems with forward declaration

Thanks in advance for looking over this.

I'm having serious problems with vc++6.

I have 3 vector classes, CVector2, CVector3, and CVector4. each of them reference both others. before any of them are declared I use

Code:

---

class CVector2;
class CVector3;
class CVector4;

---

then I define the functions in CVector2, CVector3, and CVector4 in that order.
Everytime I make reference CVector3 or CVector4 in the code for CVector2 it gives me the following (or similar) error:

error C2027: use of undefined type 'CVector3'
vector.h(33) : see declaration of 'CVector3'

How could the type be undefined if the compiler knows it has been declared? I'm utterly confused...

why don't you just have main reference them and have any cross-referencing done through main?

Quote:

---

Originally posted by major_small
why don't you just have main reference them and have any cross-referencing done through main?

---

:confused:
I'm not sure I entirely understand what you are saying... could you explain this further?

First off, such interdependencies are not a good idea. It makes the system more coupled, and harder to change. I am guessing you are referencing them for vector operations, or something of that nature. If that is the case, then consider removing those functions from the classes, and putting them in a separate namespace.

Now, to the question. From the sound of it, you have something like this:

Code:

---

CVector2;

class CVector3 {
public:
  void foo(CVector2);
};

---

The problem is, to have an instance of the class, you have to have the class defined, not simply declared. For one, the compiler needs to know how much space to reserve. If you had a pointer or a reference, however, this method would work.

Code:

---

CVector2;

class CVector3 {
public:
  void foo(CVector2&);
  void foo(CVector2*);
};

---

I'm beginning to agree that this interdependancy is a bad idea and I will definitely change it.
However, I am curious as to the reasons I'm getting these errors. I am using references.

Code:

---

class CVector2;

class CVector3
{
 
    CVector3(const CVector2& vec) : x(vec.x), y(vec.y), z(0.0)
    { }
...

---

Quote:

---

Originally posted by logicalhippo
I'm beginning to agree that this interdependancy is a bad idea and I will definitely change it.
However, I am curious as to the reasons I'm getting these errors. I am using references.

Code:

---

class CVector2;

class CVector3
{
 
    CVector3(const CVector2& vec) : x(vec.x), y(vec.y), z(0.0)
    { }
...

---

---

Because you are trying to access members of an undefined class. The compiler doesn't know that CVector2 has members called x and y.

You can separate them into header and source files though.

header:

Code:

---

class CVector2;

class CVector3
{
  CVector3(const CVector2&);
...

---

source:

Code:

---

#include "CVector3.h"
#include "CVector2.h"

CVector3::CVector3(const CVector2& vec)
: x(vec.x), y(vec.y), z(0.0 {}
...

---

ah yes. that would do it. Thank you.

Quote:

---

Originally posted by Zach L.

Now, to the question. From the sound of it, you have something like this:

Code:

---

class CVector2;

class CVector3 {
public:
  void foo(CVector2);
};

---

---

Actually, that is legal. Incomplete types (types which are declared but not defined) can be used as references, pointers, parameters, or return types. As long as you're only declaring the method, not defining it, it's OK. In a class definition in which you declare but don't define any methods, you can use an incomplete type for anything except:

1) A base class
2) A member variable

Also, you cannot (obviously) use new or delete to create/destroy incomplete types -- this has implications sometimes for how you code your destructor.