Printable View
My improved version of the previous Battleship. Thank you all for the suggestions.
v1.3 Additions:
-Beep selection mode
-Pause selection mode (for those of you that dispise the "Please Press Any Key to Continue")
-Improved code for more efficiency
-Error messages
-Other things that I forgot
No comments?
game
cool, how long did that take you?
Pretty nice little game. Especially like the incorporated help. As I haven't seen any previous versions, I'm going to ask, does the AI use a default pattern to find the player ship?
you would probably get more comments if you posted this in the game forum....Quote:
Originally posted by luckygold6
No comments?
anywho, good game! im not much of a fan of text based games but this was enjoyable, i like it.
Nice game, but I tried it twice & both times it hung before the game was over.
It took me several weeks to create, debug, and complete the program.
Can you tell me when the program hung up on you? That way, I might be able to narrow down to where I need to search for the error.
Thanks!
I just tried again. 1st game went OK. 2nd & 3rd games hung again. Hung on computer's turn in 9th round. I was purposely avoiding hitting the enemy so game would continue for a while.
It hung after
0- Strategic mode
Difficulty level 0
Beep mode 1
Pause mode 1
Help mode 0
Computer shots 8 Ammo 17
Player shots 9 Ammo 16
(The other stats varied from game to game, but I think the number of shots were the same each time... at least, they were the same both times today, and yesterday it was after about 7,8, or 9 shots but I'm not exactly sure because I wasn't paying attention to that.)
Thanks, I'll check on the problem.
If anyone else has this problem, please post any additional info.
Do you have your vertical columns and horizontal rows mixed up?:confused:
Vertical- up and down
Horizontal- left and right
Is this right?
yup, last time i checked....Quote:
Originally posted by luckygold6
Vertical- up and down
Horizontal- left and right
Is this right?
The strategy I use is actually really simple. Originally, I had actually made it so that the computer tries to locate one of your ships, then it attacks grids around it that would seem most likely for a ship to reside in. This strategy is similar to those used by humans. However, when I first implemented it, I had incesent errors, so I assumed it was that portion of the program. I wiped the strategy out, and started from scratch.
I created a simpler straegy, in which the computer is given the knowledge of where you ships are, and when a certain dice roll is hit, the computer will attack your ships. I realized afterward that the problem I had before was never within the strategy portion of the code, but in the attack portion of the code. I had accidently replaced || with && in my code and it caused the game to malfunction.
Anyway, I haven't had time to revise the strategy, so I'm just keeping it the way it is for the time being. Once I have more time to work on my programs, I will revise it. I also believed that this strategy was more challenging. Because the grid was so small, the computer using the former strategy would have to spend several turns search for a portion of your ship, then try to locate the other portions. This meant that the computer would have been less challeging.
Hope that answers your question.
And about the computer hanging up, I can't seem to locate the error. I haven't yet, but then again, the computer seems to always beat me before I get pass six or seven rounds. I think the cause might be that the computer is randomizing attacks that are on ships or areas it has attacked before. This means that it will have to re-randomize until it has a valid attack. As less spots are available, it will take longer to strike a number because the probability of hitting blanks become less and less. I'm trying to implement a code to prevent this.
Paragraph III:
...several turns searching for a portion of your ship, then try to locate the other...
Paragraph VI:
...I haven't encountered yet, but then again, the computer seems to always...
I appologize for my errors.
Oddly enough, my improvements seems to make the game worse...?
i have a suggestion for this.Quote:
Originally posted by luckygold6
And about the computer hanging up, I can't seem to locate the error. I haven't yet, but then again, the computer seems to always beat me before I get pass six or seven rounds. I think the cause might be that the computer is randomizing attacks that are on ships or areas it has attacked before. This means that it will have to re-randomize until it has a valid attack. As less spots are available, it will take longer to strike a number because the probability of hitting blanks become less and less. I'm trying to implement a code to prevent this.
i created a randomization program once (for the calc, but i ported it to the puter, and it's really simple) where you simply do this, i'll write it in pseudo code
hmm, that's almost more confusing than actual code....i'll try some real code too, lolCode:create a boolean value and set it to false
for loop count from 1 to the number of tries you want to do (IE: 4)
do testing/random stuff to pick the positions
if it was a spot that wasn't empty
set the boolean value to true
break to save time
otherwise just keep continuing the loop
once you are out of the loop:
test if the boolean value is not true (meaning we didn't find a spot that hasn't been fired on yet)
run a for loop through all the possible points until you hit the first empty one
once you hit it, set those points to the x,y coords that you need to try
so, in essence, what you do is you do a few random guesses, and if you can't find it within those few random guesses, then just do a loop through all the possible choices until you find a valid guessCode:
bool empty=false; // Create the boolean variable
COORD try; // The testing coordinates
for(int a=0;a<4;a++)
{
try.X=rand()%5; // 5 is the width of the level
try.Y=rand()%5; // and again, 5 is the height
if(Map[try.Y] [try.X]>0) // Test if the spot on your map matrix has been shot yet. I dont' know exactly how it works on your game, but i'm assuming that you are using a matrix.....
{
empty=true; // Set the bool value to true
break; // Break out of the loop to save time
}
}
if(!empty) // If we couldn't find a spot.....
{
for(int b=0;b<5;b++) // Run through the whole map
{
for(int c=0;c<5;c++)
{
if(Map[b] [c]>0)
{
empty=true;
try.X=b;
try.Y=c;
break;
}
}
}
if(!empty) // If we STILL haven't found a spot.....
// We have to have hit everything if we STILL haven't found a spot by now
}
// if we make it this far, then we're good to go, and you can just pass the try coordinate to whatever you use to test, and VOILA!
IM me if you're still confused :)
I hope this helps!
error.....one hit away too, damit :D
hmmm...it is in the game forum.Quote:
Originally posted by Perspective
you would probably get more comments if you posted this in the game forum....
it got moved to the game forum, it was in the c++ forum.Quote:
Originally posted by blackrat364
hmmm...it is in the game forum.
Really cool game. Freezes on me too, seems like random times, but always when the enemy moves. I think it happens more when you have beeps turned on... :confused:
Either way, I think it's good. :D
(btw, why did you block out the people who helped you names out?)
the ai isnt that good because it hit one of my ships and didnt even shoot where it could possibly be the next shot, when a person gets a hit they normally go above below or to either side not like a couple away. And there is too much text at begining, by looking at ur post u like to write essays but people playing games dont like to read essays so id say shorten the text at the top.
I just blocked the names for privacy reasons. I didn't want them to get angry at me for posting them on the internet. If you want to know though, I'm sure they wouldn't mind. Especially me... hehe.
Also, a note about the AI. I previously did create one that worked, however, I deleted it thinking that it was causing one of my errors. Later, I realized that one of my if() statements used the && instead of the ||, causing runtime errors. So currently, I'm implementing a very simple strategy. I'll improve it later on. Sorry about any inconvenience.