What's wrong with this???

Can somebody please explain me what's wrong with this code???
getline() here supposed to read a whole line at a time.... right...???
but doesn't do anything... s1 doesn't have any value when you feed it a whole line...
s reads a word terminated by '\0'... that's fine but s1 doesn't ...

<code>
#include <iostream>
#include <string>

using namespace std;

int main(void)
{
cout << "Enter a word:" << endl;
string s, s1;
cin >> s;
cout << "You Entered " << s << '\n';
cout << "Enter a sentence: \n";
getline(cin, s1);
cout << "You Entered " << s1 << '\n';
return 0;
}
</code>

Thanks
RamBUS.net

I'm using Visual Studio 6.

Try this out. I dont preferably use strings i like char better but see if it helps.

Code:

---

#include <iostream>
#include <conio.h> //for compiler

using namespace std;

int main()
{
cout << "Enter a word:" << endl;
char s[50];
cin >> s;
cout << "You Entered " << s << '\n';
cout << "Enter a sentence: \n";
char s1[150];
cin >>s1;
cout << "You Entered " << s1 << '\n';
getch(); // for compiler
return 0;
}

---

NOTE its [code] not <code>

Personally i dislike using string variables and use charracter arrays instead

To see what an array is visit the tutorial(this will help the understanding of using the array).
. But for this purpose s is a string with a limit of 50 characters, and s1 is a string with a limit of 150 characters.

See what happens with it like this.

The person who posted above used cin to input the sentence. Cin does not read null characters(any type of space like a space or an enter).

Code:

---

--------------------------------------------------------------------------------
#include <iostream>
#include <conio.h> //for compiler

using namespace std;

int main()
{
cout << "Enter a word:" << endl;
char s[50];
cin >> s;
cout << "You Entered " << s << '\n';
cout << "Enter a sentence: \n";
char s1[150];
cin.getline(s1,150,'/n'); //reads spaces with getline and stops inpt
//when it reaches a '\n' (aka enter) the 150 is the max amount of
//chars that can be inputted
cout << "You Entered " << s1 << '\n';
getch(); // for compiler
return 0;
}

---

Thanks guys...

so.. does it mean that this is wrong...???

http://www.research.att.com/~bs/bs_faq2.html

Anyways... i tried both of your ways.... but didn't work for me..

I don't know if it runs fine with your compiler...

I know that
file.getline(var, len, delimeter);
works fine for reading sentence from a file but had never tried reading string from the keyboard...

hum... I don't know...!!!

The problem is that your call to cin results in a newline character being left in the input stream. Since getline stops reading at a newline character, it reads the leftovers of cin and nothing else, resulting in an empty string. To solve the problem, flush the input stream with cin.ignore():

Code:

---

#include <iostream>
#include <string>

using namespace std;

int main(void)
{
  cout << "Enter a word:" << endl;
  string s, s1;
  cin >> s;
  cin.ignore(); // Eat the newline
  cout << "You Entered " << s << '\n';
  cout << "Enter a sentence: \n";
  getline(cin, s1);
  cout << "You Entered " << s1 << '\n';
  return 0;
}

---

-Prelude

dope!!

Yea they got it. You gotta clear the buffer. I geuss their way would work. You can also getline the leftover'\n' into a dummy variable.

>Yea he got it. You gotta clear the buffer. I geuss his way would work.
Welcome to cprogramming btw. ^_^

-Prelude

Quote:

---

Originally posted by Prelude
>Yea he got it. You gotta clear the buffer. I geuss his way would work.
Welcome to cprogramming btw. ^_^

-Prelude

---

You're just going to let that slide? Cmon!

>You're just going to let that slide? Cmon!
I'm in a good mood tonight. ;)

-Prelude

Thnaks Prelude!
It did work that way....:)
However, it requires 2 return keys to get the output written on the screen... That is little too interesting to me... :-) I'm not sure..
I tried to play around with the codes but still needs you to enter "enter" twice to get the s1 printed out on the console.
Any further little explanation would be great to clear my little brain.

Thank you in advance!

>Any further little explanation would be great to clear my little brain.
I would wager that you use MS Visual C++ 6. That compiler has a bug in getline that requires you to press return twice. The MS web site has a fix here if it really bothers you.

-Prelude

That clears it up!:))
Thanks a lot Prelude!