hangman game, copied staight from book.. 31 errors?!?!?!?!

WHY WON'T IT WORK?!?!?!

Code:

---

#include <iostream>
#include <cstdlib>
#include <string>
#include <ctime>
#include <type.h>
using namespace std;
const int NUM = 2;
const string wordlist[NUM] = {"apiary", "cereal};
int main()
{
srand(time(0));
char play;
char gen;
cout << "Are you a sir or mam?\n";
cin gen;
cout << "Okay, ";
cout << gen;
cout << "Play my wordgame? <y/n> ";
cin play;
play = tolower(play);
while (play == 'y')
{
string target = wordlist[rand() % NUM];
int length = target.length();
string attempt(length, '-');
string badchars;
int guesse = 6;
cout << "Guess my secret word. It has " << length
    << " letters, and you guess\n";
    << "one letter at a time. You get " << guesses
    << " wrong guesses.\n";
cout << "Yor word: " << attempt << endl;
while (guesses > 0 && attempt != target)
{
char letter
cout << "Guess a letter: ";
cin letter;
if (badchars.find(letter) != string::npos
    || attempt.find(letter) != string::npos)
    {
    cout << "You already guessed that!\n";
        continue;
    }
    int loc = target.find(letter);
    if (loc == string::npos)
    {
    cout << "Oh! Bad luck, and guess!\n";
    --guesses;
    badchars += letter;
    }
    else
    {
    cout << "Good choice, ";
    cout << gen;
    attempt[loc]=letter;
    loc = target.find(letter, loc + 1);
    while (loc != string::npos)
    {
    attempt[loc=letter;
    loc = target.find(letter, loc + 1);
    }
}
cout << "Your word: " << attempt << endl;
if (attempt != target)
{
if (badchars.length() > 0)
  cout << "Bad chaoices: " << badchars << endl;
 cout << guesses << " bad guesses left.\n";
}
}
if (guesses > 0)
    cout << "Correct!\n";
else
    cout << "Nope! The word is: " << target << ".\n";

cout << "Will you play another?: ";
cin >> play;
play = tolower(play);
}



cout << "Bye!\n";

system ("PAUSE");
return 0;
}

---

AAARGH!

it's supposed to look like this:

Are you a sir or mam?
sir
Okay, sir.
Play my word game?y
<instructions>
Your yord: -----
Guess a letter:
l
Oh, bad choice!
etc

Check for typos:

const string wordlist[NUM] = {"apiary", "cereal};
should be
const string wordlist[NUM] = {"apiary", "cereal"};

int guesse = 6;
should be
int guesses = 6;

char letter
should be
char letter;

cin letter;
should be
cin >> letter;

These are just the ones I see the first way through. Compare with the program in your book, checking every character.

::Edit::

Nevermind, Prelude is correct.

This code works (modified yours) :

Code:

---

#include <iostream>
#include <stdlib>
#include <string>
#include <time>
using namespace std;
const int NUM = 2;
const string wordlist[NUM] = {"apiary", "cereal"};

int main()
{
  srand(time(0));
  char play;
  char gen;
  cout << "Are you a sir or mam?\n";
  cin >> gen;
  cout << "Okay, ";
  cout << gen;
  cout << "Play my wordgame? <y/n> ";
  cin >> play;
  play = tolower(play);
  while (play == 'y')
  {
    string target = wordlist[rand() % NUM];
    int length = target.length();
    string attempt(length, '-');
    string badchars;
    int guesses = 6;
    cout << "Guess my secret word. It has " << length
            << " letters, and you guess\n"
            << "one letter at a time. You get " << guesses
            << " wrong guesses." << endl;
    cout << "Yor word: " << attempt << endl;
    while (guesses > 0 && attempt != target)
    {
          char letter;
          cout << "Guess a letter: ";
          cin >> letter;

          if (badchars.find(letter) != string::npos
        || attempt.find(letter) != string::npos)
        {
        cout << "You already guessed that!\n";
        continue;
        }
    int loc = target.find(letter);
    if (loc == string::npos)
    {
          cout << "Oh! Bad luck, and guess!\n";
          --guesses;
          badchars += letter;
    }
    else
    {
        cout << "Good choice, ";
        cout << gen;
        attempt[loc]=letter;
        loc = target.find(letter, loc + 1);
        while (loc != string::npos)
    {
    attempt=loc=letter;
    loc = target.find(letter, loc + 1);
    }
}
cout << "Your word: " << attempt << endl;
if (attempt != target)
{
    if (badchars.length() > 0)
    cout << "Bad chaoices: " << badchars << endl;
    cout << guesses << " bad guesses left.\n";
}
}
if (guesses > 0)
    cout << "Correct!\n";
else
    cout << "Nope! The word is: " << target << ".\n";

cout << "Will you play another?: ";
cin >> play;
play = tolower(play);
}

cout << "Bye!\n";

system ("PAUSE");
return 0;
}

---

Quote:

---

Replace: system ("PAUSE");

With: system("PAUSE");

---

>system ("PAUSE");
>system("PAUSE");
It's late and I'm tired, but it looks like the only difference is the space between the opening paren and the function name. Both forms are perfectly legal, otherwise my style would be totally obscene:

system ( "PAUSE" );

C++ is a free form language. This means that you can put whitespace just about anywhere as long as it doesn't change the semantics of the statement. Two examples are putting a space between an identifier:

int my num = 10; // error!

And breaking a string literal with a newline:

std::cout<<"This is
a test"<<std::endl; // error!

There are a few other situations, but for the most part you can format code however you want. "However you want" should be a synonym for "As readable as possible" by the way. ;)

-Prelude

Heh, yup your right. I don't usually use system("PAUSE") to pause though :p

>I don't usually use system("PAUSE") to pause though
It's just like any other function, but I don't blame you for not using it, system is way slow and something like this is just as effective:

Code:

---

std::cout<<"Press return to continue"<<std::flush;
std::cin.get();

---

-Prelude

Quote:

---

std::cout<<"Press return to continue"<<std::flush;
std::cin.get();

---

Or just plain old : "getch();"

>Or just plain old : "getch();"
Only if you use DOS or Windows, getch is nonstandard and often not implemented on POSIX systems. It sure is a waste to kill your portability for a simple pause at the end of the program.

-Prelude

True...True. :rolleyes: