Array of srtings

I need some help. I was trying to create an array of strings. I used this code:

#include <iostream>
#include <fstream>

using namespace std;

int main()
{
char Line1[20] = "Hello Wazzup??";
char Line2[20] = "Hello There!!";

char * Index[2];

Index[0] = &Line1[20];
Index[1] = &Line2[20];

cout << Index[0] << endl;
cout << Index[1] << endl;

return 0;
}

however when i compile Index[0] gives some strange ascii values and Index[1] contains &Line2... can someone tell me what i did wrong???

There's an easier way to do this, you could use a 2D array, but that's just a pain so an array of char *'s or an array of strings would be better.

Code:

---

#include <iostream>
#include <string>
using namespace std;

int main()
{
        // These strings can't be changed.
        char *arr_str[2] = {
                "Hello Wazzup??",
                "Hello There!!",

        };

        // These strings can be changed.
        string arr_str2[2] = {
                "Hello Wazzup??",
                "Hello There!!",
        };

        return 0;
}

---

The problem with your code was that you were giving the Index array the address of the 20th element of each array, this is out of bounds for both arrays so you get junk. This is your working code.

Code:

---

#include <iostream>
#include <fstream>

using namespace std;

int main()
{
        char Line1[20] = "Hello Wazzup??";
        char Line2[20] = "Hello There!!";
       
        char * Index[2];
       
        Index[0] = Line1;
        Index[1] = Line2;
       
        cout << Index[0] << endl;
        cout << Index[1] << endl;
       
        return 0;
}

---

Index[0] = Line1;
Index[1] = Line2;


should be

strcpy(Index[0], Line1);
strcpy(Index[0], Line2);

as they are Cstyle strings, not STL strings. The assignment operator works on the latter, not the former. I know it was an oversight but mixing Cstyle strings with STL strings in the same post or the same program frequently leads to this type of error, much to my chagrin.

Quote:

---

Originally posted by elad
Index[0] = Line1;
Index[1] = Line2;


should be

strcpy(Index[0], Line1);
strcpy(Index[0], Line2);

as they are Cstyle strings, not STL strings. The assignment operator works on the latter, not the former. I know it was an oversight but mixing Cstyle strings with STL strings in the same post or the same program frequently leads to this type of error, much to my chagrin.

---

Wrong! He's not copying the strings, he simply makes the pointers (in the array) point to the strings.

Using strcpy like you suggest would try to copy the data to a random point in memory (the pointers in the array are undefined) and would most likely cause an access violation.