Do constructors get inherited?

I mean do they? It doesn't seem that they do, that's just silly

Code:

---

class Human : public Parent {
public:
        Human(string name);


private:


};

Human::Human(string name) {
        Name = name;
}

---

Human is a derived class of Parent. parent is technically a human as well.

I get this error:
[error]
Compiling...
human.cpp
C:\human.cpp(162) : error C2512: 'Parent' : no appropriate default constructor available
Error executing cl.exe.

human.exe - 1 error(s), 0 warning(s)
[/error]

that is really silly, I mean more silly than silly can possibly be!

yes they do. the base class constructor is called first, then the derived class.

So before you construct Human, you must construct Parent...
(shouldn't Parent be derived from Human? :D)

Quote:

---

Originally posted by BMJ
So before you construct Human, you must construct Parent...
(shouldn't Parent be derived from Human? :D)

---

No, he got it right. lol

parent in this case should absolutely not be derived from human, because each human must be created from two parents

Make the partent constructor virtual if I remember correctly.

This is my parent constructor so far (emphasize SO FAR)

Code:

---

Parent::Parent(string name) {

        Name = name;
       
        SkinColor = rand()%5;

        HairColor = rand()%5;

        EyeColor = rand()%5;

        Height = (rand()%36) + 36; //mexico sucks

        Weight = (rand()%200) + 70;

        Intelligence = rand()%5;


       
};

---

Here is my human constructor so far

Code:

---

class Human : public Parent {
public:
        Human(string name);


private:


};

---

Can you see in those two constructors why I might be getting that error? I'll post the error again
Compiling...
human.cpp
C:\human.cpp(162) : error C2512: 'Parent' : no appropriate default constructor available
Error executing cl.exe.

human.exe - 1 error(s), 0 warning(s)

The error points to the Human::Human constructor
should I change it to Parent::Human or something...frig

You can't make constructors virtual!!!!!!!!!!!!!!

yep :)

You Should pass arguements to the Parent Constructor from the Human Class Constructor. So, You should define the Human Constructor like this.

Human::Human(string ParentString, string HumanString)
{
Parent(ParentSring);
name = HumanString;
}

Ok well I don't even need to define a Human Constructor, because the Parent constructor does all that I need. However, when I don't do that I get the following errors:
[error]
--------------------Configuration: human - Win32 Debug--------------------
Compiling...
human.cpp
C:\human.cpp(170) : error C2664: 'Human::Human' : cannot convert parameter 1 from 'char [8]' to 'const class Human &'
Reason: cannot convert from 'char [8]' to 'const class Human'
No constructor could take the source type, or constructor overload resolution was ambiguous
C:\human.cpp(172) : error C2664: 'Human::Human' : cannot convert parameter 1 from 'char [8]' to 'const class Human &'
Reason: cannot convert from 'char [8]' to 'const class Human'
No constructor could take the source type, or constructor overload resolution was ambiguous
C:\human.cpp(174) : error C2664: 'Human::Human' : cannot convert parameter 1 from 'char [4]' to 'const class Human &'
Reason: cannot convert from 'char [4]' to 'const class Human'
No constructor could take the source type, or constructor overload resolution was ambiguous
C:\human.cpp(176) : error C2664: 'Human::Human' : cannot convert parameter 1 from 'char [6]' to 'const class Human &'
Reason: cannot convert from 'char [6]' to 'const class Human'
No constructor could take the source type, or constructor overload resolution was ambiguous
C:\human.cpp(178) : error C2664: 'Human::Human' : cannot convert parameter 1 from 'char [5]' to 'const class Human &'
Reason: cannot convert from 'char [5]' to 'const class Human'
No constructor could take the source type, or constructor overload resolution was ambiguous
C:\human.cpp(180) : error C2664: 'Human::Human' : cannot convert parameter 1 from 'char [7]' to 'const class Human &'
Reason: cannot convert from 'char [7]' to 'const class Human'
No constructor could take the source type, or constructor overload resolution was ambiguous
Error executing cl.exe.

human.exe - 6 error(s), 0 warning(s)
[/error]

Those errors are called everytime I make an instance of a human and try to assign it a name
i.e

Human Rachel("Rachel");

If your base class has a non default constructor then
the devived class has to call it like this

Code:

---

class A  {
public:
      A(int n);
};

class B : public A {
public:
        B() : A(4) { }
};

---

Quote:

---

Originally posted by Troll_King
Make the partent constructor virtual if I remember correctly.

---

nope. you're thinking destructors

So, You don't want to do anything with the Base Class Constructor(Parent) , then include default constructor in the Base class.

class Parent

public:

So, You don't want to do anything with the Base Class Constructor(Parent) , then include default constructor in the Base class.

class Parent
{

public:
Parent()
{
}
Parent(string Name)
{
name = Name;
}
}

Quote:

---

Originally posted by FillYourBrain

nope. you're thinking destructors

---

I was looking at facemasters code.

http://www.cprogramming.com/cboard/s...threadid=23779

Personally I have not used classes in about 6 months. I'm reading some c++ stuff but the book doesn't deal with classes until about page 200.

I have a default constructor in the base class...and it still doesn't work. I'm just going to post my ENTIRE source code for this because I'm bumming and I don't see what is wrong....it is more than likely simple and I will feel silly for not noticing it

Code:

---

//This is the human program
//The class is class human
//Here is a list of different attritutes to be included:
/*
physical attributes
[pa]
        Hair color, eye color, height, weight, skin color,

*/


//I want to create parents.  And then each human will have two parent humans
//Each attribute needs to be mostly affected by the two parent's attributes, but also by chance
//


#include <windows.h>
#include <iostream>
#include <string>
#include <conio.h>
#include <time.h>
#include <fstream>



using namespace std;

ofstream fout;                //used for outputting all of the data

class Parent{
public:
       
        Parent(string Name);
        //static void Randomize(void) {srand(GetTickCount());}

void Synopsis();

void OutPutData();

protected:
                //physical attributes
                string Name;
                int SkinColor,
                HairColor,
                EyeColor,
                Height,
                Weight,

                Intelligence,
                Temper,
                SelfEsteem,
                Reasonableness;
};






Parent::Parent(string name) {

        Name = name;
       
        SkinColor = rand()%5;

        HairColor = rand()%5;

        EyeColor = rand()%5;

        Height = (rand()%36) + 36; //mexico sucks

        Weight = (rand()%200) + 70;

        Intelligence = rand()%5;


       
};

void Parent::OutPutData()        {
        fout << endl;

        fout << "Here are the attributes for " << Name << endl;
        cout << "Here are the attributes for " << Name << endl;

        fout << "SkinColor " << SkinColor << endl;
        cout << "SkinColor " << SkinColor << endl;

        fout << "HairColor " << HairColor << endl;
        cout << "HairColor " << HairColor << endl;

        fout << "EyeColor " << EyeColor << endl;
        cout << "EyeColor " << EyeColor << endl;

        fout << "Weight " << Weight << " pounds " << endl;
        cout << "Weight " << Weight << " pounds " << endl;

        fout << "Height " << Height << " inches," << (Height/12) << " feet" <<  endl;
        cout << "Height " << Height << " inches," << (Height/12) << " feet" <<  endl;

        fout << "Intelligence " << Intelligence << endl;
        cout << "Intelligence " << Intelligence << endl;

        fout << endl;


        };

void Parent::Synopsis() {
        switch(SkinColor) {
        case 0:
                {
                        cout << Name << " has a very light skin color" << endl;
                        break;
                }

        case 1:
                {
                        cout << Name << " has a light skin color" << endl;
                        break;
                }
        case 2:
                {
                        cout << Name << " has a somewhat light skin color" << endl;
                        break;
                }
        case 3:
                {
                        cout << Name << " has a somewhat dark skin color" << endl;
                        break;
                }
        case 4:
                {
                        cout << Name << " has a dark skin color" << endl;
                        break;
                }
        case 5:
                {
                        cout << Name << " has a very dark skin color" << endl;
                        break;
                }
        default:
                {
                        cout << "I honestly don't know how you got her, but somehow you did, and you suck for it" << endl;
                }
        }
}

               
       

class Human : public Parent {
public:

private:


};


               
int main(void) {
        fout.open("Generated.txt");


srand(GetTickCount());

        Human Charles("Charles");

        Human Jessica("Jessica");

        Human Bob("Bob");

        Human Frank("Frank");

        Human Emmy("Emmy");

        Human Rachel("Rachel");

        Charles.OutPutData();
        Charles.Synopsis();
        getch();
        system("cls");

        Jessica.OutPutData();
        Jessica.Synopsis();
        getch();
        system("cls");


        Bob.OutPutData();
        Bob.Synopsis();
        getch();
        system("cls");

        Frank.OutPutData();
        Frank.Synopsis();
        getch();
        system("cls");

        Emmy.OutPutData();
        Emmy.Synopsis();
        getch();
        system("cls");

        Rachel.OutPutData();
        Rachel.Synopsis();
        getch();
        system("cls");
        fout.close();


        return 0;
}

---

It really is a lot

edit
there are many logical problems but those aren't what is stopping the program for working, i.e I don't have all the protected member varialbes initialized in the constructor when I planned on having them all be initialized. I also didn't include a synopsis for all of the variables, so far just skin color
edit

Code:

---

class Human : public Parent {
public:
        Human(string name) : Parent(name) {}

private:


};

---

Bada boom

Well I'll be a monkeys uncle.

Uhh it compiles but crashes when I run it with that modification

I'd put some destrutors in my classes.

that's not necessary at the moment I just can't figure out why it doesn't run

Funny, it worked perfectly for me (it generated the randon stats, sent them to the file, all formatted and everything)

I just added that one line from the code you posted before... and it worked fine

What compiler are you using?

WHAT? you've gotta be joking...I'm using visual studio right now

As soon as I execute it, it crashes

Sweetness, I started a new project and it works...hey thanks for helping me, I hope you don't think I'm too much of a turd...I'm really only a small turd with bigger problems.

I'm using VC++ as well, I was about to tell you to 'clean' the project, but... you fixed it :)

N/P btw

It compiled and ran under g++ after I got rid of all the non standard proprietry code.