Common Dialog Boxes problem

Try this code and try to select "save as txt" from the file menu. Every time you try this the program crashes. Why is this?

You fail to init the file name before adding the .txt to the end of it.

Also make sure you check the length of the string before adding to it.

Try
sprintf(filename,"Roster for %s.txt",date);
(but ensure that there are no punctuation characters)

Something like

Code:

---

char    *pDate=NULL,*pNewDate=NULL,sNewDate[64];
pDate=date;//set the pointers to the begining of the strings
pNewDate=sNewDate;

while(*pDate != '\0')
{
    while(ispunct(*pDate))        *pDate++;
    //while(isspace(*pDate))        *pDate++;
    *pNewDate++=*pDate++;
}
pNewDate++='\0';//set terminator

---

Make sure the path and filename variables in your Ouput function are initialized:

Change:

Code:

---

char path[MAX_PATH];
char filename[MAX_PATH];

---

To

Code:

---

char path[MAX_PATH] = "";
char filename[MAX_PATH] = "";

---

I think this will solve your problem.

Thanks for replying, the problem was that I hadn't initialised the two arrays (path and filename), but I still have a problem: It still doesn't actually save the file. Is there something I'm doing wrong with the file output?

That's because the path variable automatically includes the filename. If you add the filename to the path your path will look like this:

Code:

---

C:\Temp\Roster\test.txt\test.txt.txt

---

Remove the next 3 lines and it will work:

Code:

---

strcat(filename, ".txt");
strcat(path, "\\");
strcat(path, filename);

---

B.t.w. Are you using Visual Studio? If so, why don't you place some beakpoints and debug the stuff?

I didn't actual compile the code. But I think I see the problem. Doesn't GetSaveFileName() give you a full path? If so you are appending the full path to the path, then adding a second extension to it. Double check that.

Ah, thankyou that worked.