Trouble getting file size...

Whenever I attempt to use the following code, it returns an invalid length if I try to open a BMP or other binary file, but it works fine with text files. Any ideas why?

PHP Code:

---

#include <stdio.h>
#include <conio.h>
#include <fstream.h>

long GetFileLen(const char *);

long GetFileLen(const char *FilePath)
{
     long RetVal = 0;
    unsigned char TempChar;
    ifstream TheFile;
    TheFile.open(FilePath);
    while(!TheFile.eof())
    {
        TheFile.get(TempChar);        
        RetVal++;
    }
    TheFile.close();
    return RetVal;
}

int main()
{
    long FileLen;        
    FileLen = GetFileLen("C:/asdf.bmp");
    printf("%ld",FileLen);
    getch();
    return 0;
} 


---

Never mind, figured it out.

PHP Code:

---

#include <stdio.h>
#include <conio.h>
#include <fstream.h>

long GetFileLen(const char *);

long GetFileLen(const char *FilePath)
{
     long RetVal = 0;
    unsigned char TempChar;
    ifstream TheFile(FilePath,ios::binary); //Forgot to open in binary
    while(!TheFile.eof())
    {
        TheFile.get(TempChar);        
        RetVal++;
    }
    TheFile.close();
    return RetVal;
}

int main()
{
    long FileLen;        
    FileLen = GetFileLen("C:/asdf.bmp");
    printf("%ld",FileLen);
    getch();
    return 0;
} 


---

in your signiture you shoudl sya what compiler you use os when you ask problems invlolving codes people can look at your sig and know if they have to same compiler and help you or how to help you

because a BMP or binary can actually contain many EOF values, so EOF is not unfortunatly a valid way to find the files end.

and since i don't think there's a standard way of doing this,

there are three options as i see it others will no doubt add to them,

1. see if your compiler has the sys/stat.h include file, and use the stat function to get the filesize.

2. find the file format, and use its internal value

3. snake it with something like this...

im not exactly sure how you'd do this with C++ File streams but i'll give it a go.

Code:

---


long GetFileLen(const char *FilePath)
{
    ifstream TheFile;
TheFile.open(FilePath);

    TheFile.seekp(0,ios::end); // seek to the end of the file.
    return TheFile.tellp(); // return the size of the file.
}

---

Actually, it works fine now that i changed the open line to 'fstream TheFile("c:/asdf.bmp",ios::binary);'. It returns the correct size and everything.

I too have problems with binary files ::binary does not seem to work..