what is wrong with this way in saving struct...,

Code:

---


typedef struct _INFO
{
        char *id;
        int height, width;
}INFO;

void Save()
{
INFO info;

char id[] = "hello";
info.id = new char[sizeof(id)];
// filling the structure
strcpy(map.id, id);
info.width = 640;
info.height = 480;

       
// saving routine
ofstream saveinfo;
saveinfo.open("info.dat", ios::binary);
saveinfo.write((const char *)&info, sizeof(info));

---

okey when i tried to read this struct, i get garbage on the id part... why?

thanks,

I think it involves the fact that you are saving the value of a pointer, which may or may not still be valid when you load it again. You should probably think of some better way to save them, like either all the chars or a formatted data file.

Quote:

---

Originally posted by mickey

okey when i tried to read this struct, i get garbage on the id part... why?

---

Which struct variable, map or info?

Why did ya do this:

Code:

---

info.id = new char[sizeof(id)];
// filling the structure
strcpy(map.id, id);

---

Is that what you meant to do, or is it a typo?

Code:

---

strcpy(map.id, id);

---

You cant use strcpy to copy stuff into pointers.
Just use the mysterious = operator

did you write garbage to the file in the first place?

what happens if you write a pointer variable to a file? You write an address to the file, correct? The address is probably meaningless when you read it back in. Don't write pointers to file, write the value pointed to by the pointer to file. Then read the value back to a pertinent variable and assign the address of the variable to the pointer in the struct.

whoops that was a typo error sorry,

map.id is supposed to be info.id

anyway, so that's why it doesn't work? coz i'm saving a pointer in which it points too? but before i save it, i did this,

cout << *info.id;

which correctly outputs the right string..., so what should i do then?

use this id instead of the info.id to save/put it on the file?

thanks,

I would not use read() or write() to deal with the file. I would do it the old fashioned way.

//write data to file in comma separated format
ofstream fout(ios::app | ios binary);
fout.open("filename.dat");
fout << *info.id << ' ' << info.height << ' ' << info.width;

//read data from file
ifstream fin(ios::binary);
fin("filename.dat");
char dummy[80];
fin >> dummy;
fin >> info.height;
fin >> info.width;

//translate data into struct member format
info.id = new char[strlen(dummy) + 1);
strcpy(info.id, dummy);

You could think about wrapping this up in overloaded << and >> operators for the struct/class if you want. You need to use C++ style structs/classes to do this though.

>map.id is supposed to be info.id

If you make this change, your code should work fine. If not, repost.

Also you may need to close the file when finished writing if you use a different stream when you read the file.

saveinfo.close();

unregistered, why would you want to do it that way? that would be very tedious, using read and write would automatically put everything and read everything at once?

:)