Printable View
greetings I am trying to insert various different integers in different locations within a character array.
sprintf_s works fine but only to insert at the start of the array.
I can't for example use array[6] to point where I want the integer to be inserted in the first parameter.
What can I use to point to the location within the array and have an integer placed there?
Thanks for you time.
Why not?
sprintf(&array[6], "%d", myInt );
should be fine.
Maybe I should have included I am working on a Dialog based app under MFC if it makes any difference but using sprintf causes the following error message...
error C4996: 'sprintf': This function or variable may be unsafe. Consider using sprintf_s instead
If I try to use sprintf_s I the get the following error message...
error C2664: 'int sprintf_s(char *,size_t,const char *,...)' : cannot convert parameter 2 from 'const char [3]' to 'size_t'
?
Yeah, okay. sprintf() is specified in the C standard. sprintf_s() is a Microsoft proprietary "safe" alternative.
Microsoft provided an ostensibly safe alternative as sprintf_s(), and configured their compilers to complain about sprintf() as you are seeing. sprintf_s() works essentially like sprintf(), except that the second parameter is the maximum length of buffer being written to (the first argument), there is a bit more checking of the format string.
Similar things have been done with several other functions in the C standard library.
I use the words "ostensibly safe" because it is still possible to get into trouble with the Microsoft safe functions, albeit it is more difficult, and I have seen programmers get over-confident because they are using them (and make other simple mistakes that they don't check for, and therefore never detect).
Some other vendors have also provided their own "safe" versions of C standard functions - albeit with different names and different behaviours than the Microsoft ones.
Microsoft's error message about deprecation is incorrect, at least in terms of the standard. Deprecation is a term defined in the standard that means essentially "scheduled for removal from a future version of this standard". That is not the case here. Microsoft are using the word "deprecate" in the sense that they encourage using an alternative (so it is deprecated as far as Microsoft is concerned, and developers who are willing to be locked into Microsoft development products, but not for anyone else).
Given that you are using MFC (which is a vendor specific product from Microsoft) I can guess you are happy to be limited to Microsoft's development environments. In that case, it is up to you whether you use the C standard functions (such as sprintf()) or the Microsoft safe versions (such as sprintf_s()). If you care at all about portability (being able to build your code with a different compiler, on a different operating system) you will need to stick to sprintf() .... with all its warts.
Appreciate your time mate but quite honestly I don't give a toss on what I use I just want to do the job.
I stick to Assembly language mostly no headaches like this but turn to MFC Dialog based apps as a quick (normally) way to get something done at the end of a project.
A quick and easy way (I don't care if it is dirty) to stuff integer values into a character string array and stop the compiler whinging would be excellent.
Thanks again for your time.
Success this is how I did it.
I would very much appreciate any tips on improvements as I know my coding is pretty sloppy
thanks in advance
Code:
char name[81], second_digit[4], third_digit[4], final_key[80];
int len = 0x0, init_num;
GetDlgItemText(IDC_EDIT1, name, 80);
len = strlen(name);
init_num = len + 6;
sprintf_s(final_key, "%d", init_num);
strcat_s(final_key, "-");
sprintf_s(second_digit, "%d", len);
strcat_s(final_key, second_digit);
if (len < 16)
{
strcat_s(final_key, "--");
sprintf_s(third_digit, "%d", 15-len);
strcat_s(final_key, third_digit);
strcat_s(final_key, "-");
}
else
{
strcat_s(final_key, "-");
sprintf_s(third_digit, "%d", len-15);
strcat_s(final_key, third_digit);
strcat_s(final_key, "-");
}
strcat_s(final_key, name);
strcat_s(final_key, "-Art");
SetDlgItemText(IDC_EDIT2, final_key);
That's not our problem. You were given explanations and advice on what you use, so it's your job to interpret that and choose the best solution for you.Quote:
Originally Posted by ice_cracked
Assembly? In 2013? For programs, and not some optimized algorithm? I want to smack you.Quote:
I stick to Assembly language mostly no headaches like this but turn to MFC Dialog based apps as a quick (normally) way to get something done at the end of a project.
You need to get off your high horse and learn C or C++, whichever suits your purposes more.
But I seriously fail to understand why the heck you are using MFC with C. You are using a C++ framework, so why the heck not use C++?
If you insist on sticking with C, then why don't you get a C library?
You do code in a strange mix of C / C++. Reminds me of the digital image processing code I worked on in the 90's.
Why not something like...
Code:len = strlen(name);
if(len < 16)
{
_snprintf( final_key, 79, "%d-%d--%d-%s-Art",(len+6) ,len ,(15-len), name );
}
else
{
_snprintf( final_key, 79, "%d-%d-%d-%s-Art",(len+6) ,len ,(len-15), name );
}
SetDlgItemText(IDC_EDIT2, final_key);
No high horse I assure you and no one here to try and impress I just enjoy assembler and have for years.Quote:
Originally Posted by Elysia
No reason I just always have and don't know any better and no one to teach me except books and online resources?Quote:
Originally Posted by Elysia
Is there one available which includes a resource editor to knock out dialogs etc quickly?Quote:
Originally Posted by Elysia
If so any suggestions are most welcome and I will check them out.
Also as I am not doing anything for DOS only Windows should I stick to C or C++?
I very much like that thanks a lot.Quote:
Originally Posted by novacain