Sorting this in C language.

hi, im new to C and wondering how i would be able to sort certain data so it goes from highest to lowest. such as :

9 8 7 6 5 when inputted using a compiler.

what would be the best way and how would i do it using source code?

If someone wil be able to help, let me know and ill send my code !

Many thanks! MF

The standard way in C is to use the qsort function. To sort from highest to lowest you would do it something like this

Code:

---

int int_compar_desc(const void *a, const void *b) {
    const int *ia = a;
    const int *ib = b;
    if (*ia > *ib)
        return -1;
    return (*ia < *ib);
}

int main()
{
    int data[8] = {20, 1, 23, 4, 54, 23, 24, 97};
    qsort(data, 8, sizeof *data, int_compar_desc);
    return 0;
}

---

what about using bubblesort? and what about if you have letters value? can i send u an example of my code in a private message?

You need to learn what a compiler is, and what it does, first by the sounds of it. Presumably you intend to use scanf or fgets to get the values from the user?
Then you'd use the function called qsort, searching the web for how to use it.
Finally, you'd post your attempt at this here, for everyone to see.

If your input is letters, then you modify the compar function to compare letters. It is basically the same as for numbers, but you have to decide whether 'A' and 'a' are the same, etc.

Other duplicates of this thread:
http://cboard.cprogramming.com/c-pro...need-help.html
http://cboard.cprogramming.com/c-pro...-language.html

> If someone wil be able to help, let me know and ill send my code !
Yes, post it here, and lots of people will be able to help you.

> what about using bubblesort?
Sure, it's good enough on small arrays.

> and what about if you have letters value?
'a' < 'b' works too.

> can i send u an example of my code in a private message?
No - post it here.

So sorry people, im new to this forum!

this is my code, i hope you will be able to help!

#include <stdio.h> #include <stdlib.h> #include <string.h> typedef struct - Pastebin.com

Link is in the above reply (: i really need help on this.

It seems incomplete. Can't you post the code here? Use the code tag and paste it inbetween them

Code:

---

1. #include <stdio.h>
2. #include <stdlib.h>
3. #include <string.h>
5. typedef struct {
6.   char* shortValue;
7.   char shortSuit[1];
8.   char value[20];
9.   char suit[20];
10. } CARD;
12. CARD cards[5];
13. int score;
14. int failed;
17. int main(void){
19. /* Putting space between the lines makes it look "Tidy" or "Professional" */
21.     printf("Welcome to Poker Game.\n\n");
23.     printf("Lets Start.\n\n");
25.     printf("Draw Your Cards.\n\n");
27.     for(int i = 0; i < 5; i++){
28.       cards[i].shortValue = calloc(1, sizeof(char));
29.         }
31.   scanf("%c%c %c%c %c%c %c%c %c%c", cards[0].shortValue, cards[0].shortSuit, cards[1].shortValue, cards[1].shortSuit, cards[2].shortValue, cards[2].shortSuit, cards[3].shortValue, cards[3].shortSuit, cards[4].shortValue, cards[4].shortSuit);
33.   /* Use of switch command for long if statement */
34.   /* Use value of 0 as Ten */
35.   /* For each card in input, run check to determine number/letter in word form */
37.     for(int i = 0; i < 5; i++){
39.       switch(cards[i].shortValue[0])
40.       {
42.         case '2':
43.           sprintf(cards[i].value, "Two");
44.           break;
47.         case '3':
48.           sprintf(cards[i].value, "Three");
49.           break;
52.         case '4':
53.           sprintf(cards[i].value, "Four");
54.           break;
57.         case '5':
58.           sprintf(cards[i].value, "Five");
59.           break;
62.         case '6':
63.           sprintf(cards[i].value, "Six");
64.           break;
67.         case '7':
68.           sprintf(cards[i].value, "Seven");
69.           break;
72.         case '8':
73.           sprintf(cards[i].value, "Eight");
74.           break;
77.         case '9':
78.           sprintf(cards[i].value, "Nine");
79.           break;
82.         case '0':
83.           sprintf(cards[i].value, "Ten");
84.           break;
87.         case 'J':
88.           sprintf(cards[i].value, "Jack");
89.           cards[i].value[5] = "11";
90.           score += 1;
91.           break;
94.         case 'Q':
95.           sprintf(cards[i].value, "Queen");
96.           cards[i].value[5] = "12";
97.           score += 1;
98.           break;
101.         case 'K':
102.           sprintf(cards[i].value, "King");
103.           cards[i].value[5] = "13";
104.           score += 1;
105.           break;
108.         case 'A':
109.           sprintf(cards[i].value, "Ace");
110.           cards[i].value[5] = "14";
111.           score += 1;
112.           break;
115.         default:
116.             printf("Invalid value character for card #%d. \n", i+1);
117.             failed = 1;
118.             break;
119.         }
120.     }
122.     /* Run check for all short suits in input */
124.   for(int i = 0; i < 5; i++)
125.   {
126.       switch(cards[i].shortSuit[0])
127.       {
129.       case 'C':
130.         sprintf(cards[i].suit, "Clubs");
131.         break;
134.       case 'D':
135.         sprintf(cards[i].suit, "Diamonds");
136.         break;
139.       case 'H':
140.         sprintf(cards[i].suit, "Hearts");
141.         break;
144.       case 'S':
145.         sprintf(cards[i].suit, "Spades");
146.         break;
149.       default:
150.         printf("Invalid suit character for card #%d.\n", i+1);
151.         failed = 1;
152.         break;
153.       }
154.   }
156.     if(failed == 1){
157.       printf("Invalid value or suit character. Program exiting.\n");
158.       return 0;
159.   }
162.     for(int i = 0; i < 5; i++)
163.       printf("%s of %s\n", cards[i].value, cards[i].suit);
165.       printf("\n");
     
     } 

---

This line is not correct:

Code:

---

sprintf(cards[i].value, "Queen");
          cards[i].value[5] = "12";

---

You have a few more where you do something similar. What are you trying to do here? You store "Queen" into the character buffer `value' and then you want to tack on a "12" at the end?? I think it would make more sense to make a different member of your struct and then do something like this

Code:

---

sprintf(cards[i].value, "Queen");
cards[i].valueAmount = 12;

---

i have a 5 card input like 5H 6D 8C 7S 4H and when i put them in, i want it to sort them in a list like this:

4H
5H
6D
7S
8C

but when i display them, it will print the names and of and then the suit. i want to be able to sort the data in order to make it go in order Highest value first to the lowest value :)

Fix the errors in your code first. I mentioned it above. Fixing errors should be a prerequisite to adding anything more to the code.

well i tried doing that but i kept getting error messages. do u have teamviewer 8 so i can possibly show you what i am doing so you can provide me with an answer and see for yourself? :)

I already mentioned a solution. Here:

valueAmount
suitAmount

add two members of type `int' to your CARD structure. These should just store a plain integer that represents how valuable (numerically) a certain card is. For example, if it's a five of clubs, you could say valueAmount is 5 (i.e. the card with face value "5" has a numerical value of 5) and suitAmount is 4 (i.e. Clubs has a numerical value of 4-- I think this one is really up to you, I'm not an expert on cards)

Something like this?

Code:

---

int valueAmount[13];
 
 valueAmount[0] = "2";
 valueAmount[1] = "3";
 valueAmount[2] = "4";
 valueAmount[3] = "5";
 valueAmount[4] = "6";
 valueAmount[5] = "7";
 valueAmount[6] = "8";
 valueAmount[7] = "9";
 valueAmount[8] = "0";
 valueAmount[9] = "11";
 valueAmount[10] = "12";
 valueAmount[11] = "13";
 valueAmount[12] = "14";
 
 int valueSuit[4];
 
 valueSuit[0] = "1";
 valueSuit[1] = "2";
 valueSuit[2] = "3";
 valueSuit[3] = "4";

---

"2", "3", "4", etc are not integers. 2, 3, 4 are integers. Also, make them part of your CARD struct, i.e.

Code:

---

cards[i].valueAmount = 2;
// etc...

---

Like this?

[code]

case '2':
sprintf(cards[i].value, "Two");
cards[i].valueAmount[0] = 2;
break;


case '3':
sprintf(cards[i].value, "Three");
cards[i].valueAmount[1] = 3;
break;

[\code]

It depends on how you define valueAmount. Rather than ask if it's correct, why not try it out first and see if it works? Compile with warnings turned on and fix them first. If you need help fixing an error or warning, post that information here and you will be more likely to get something helpful.

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
 
 typedef struct {
  char* shortValue;
  char shortSuit[1];
  char value[20];
  char suit[20];
 } CARD;
 
 CARD cards[5];
 int score;
 int failed;
 
 int valueAmount[13];
 
 valueAmount[0] = 2;
 valueAmount[1] = 3;
 valueAmount[2] = 4;
 valueAmount[3] = 5;
 valueAmount[4] = 6;
 valueAmount[5] = 7;
 valueAmount[6] = 8;
 valueAmount[7] = 9;
 valueAmount[8] = 10;
 valueAmount[9] = 11;
 valueAmount[10] = 12;
 valueAmount[11] = 13;
 valueAmount[12] = 14;
 
 int valueSuit[4];
 
 valueSuit[0] = 1;
 valueSuit[1] = 2;
 valueSuit[2] = 3;
 valueSuit[3] = 4;
 
 int main(void){
 
 /* Putting space between the lines makes it look "Tidy" or "Professional" */
 
    printf("Welcome to Poker Game.\n\n");
 
    printf("Lets Start.\n\n");
 
    printf("Draw Your Cards.\n\n");
 
    for(int i = 0; i < 5; i++){
      cards[i].shortValue = calloc(1, sizeof(char));
        }
 
  scanf("%c%c %c%c %c%c %c%c %c%c", cards[0].shortValue, cards[0].shortSuit, cards[1].shortValue, cards[1].shortSuit, cards[2].shortValue, cards[2].shortSuit, cards[3].shortValue, cards[3].shortSuit, cards[4].shortValue, cards[4].shortSuit);
 
  /* Use of switch command for long if statement */
  /* Use value of 0 as Ten */
  /* For each card in input, run check to determine number/letter in word form */
 
    for(int i = 0; i < 5; i++){
   
      switch(cards[i].shortValue[0])
      {
     
        case '2':
          sprintf(cards[i].value, "Two");
          cards[i].valueAmount[0] = 2;
          break;
                 
       
        case '3':
          sprintf(cards[i].value, "Three");
          cards[i].valueAmount[1] = 3;
          break;
                 
       
        case '4':
          sprintf(cards[i].value, "Four");
          cards[i].valueAmount[2] = 4;
          break;
                 
     
        case '5':
          sprintf(cards[i].value, "Five");
          cards[i].valueAmount[3] = 5;
          break;
                 
     
        case '6':
          sprintf(cards[i].value, "Six");
          cards[i].valueAmount[4] = 6;
          break;
                 
     
        case '7':
          sprintf(cards[i].value, "Seven");
          cards[i].valueAmount[5] = 7;
          break;
                 
       
        case '8':
          sprintf(cards[i].value, "Eight");
          cards[i].valueAmount[6] = 8;
          break;
       
   
        case '9':
          sprintf(cards[i].value, "Nine");
          cards[i].valueAmount[7] = 9;
          break;
       
   
        case '0':
          sprintf(cards[i].value, "Ten");
          cards[i].valueAmount[8] = 10;
          break;
                 
     
        case 'J':
          sprintf(cards[i].value, "Jack");
          cards[i].valueAmount[9] = 11;
          score += 1;
          break;
                 
   
        case 'Q':
          sprintf(cards[i].value, "Queen");
          cards[i].valueAmount[10] = 12;
          score += 1;
          break;
                 
     
        case 'K':
          sprintf(cards[i].value, "King");
          cards[i].valueAmount[11] = 13;
          score += 1;
          break;
   
     
        case 'A':
          sprintf(cards[i].value, "Ace");
          cards[i].valueAmount[12] = 14;
          score += 1;
          break;
       
     
        default:
            printf("Invalid value character for card #%d. \n", i+1);
            failed = 1;
            break;
        }
    }
 
    /* Run check for all short suits in input */
 
  for(int i = 0; i < 5; i++)
  {
      switch(cards[i].shortSuit[0])
      {
       
      case 'C':
        sprintf(cards[i].suit, "Clubs");
        cards[i].valueSuit[0] = 1;
        break;
             
   
      case 'D':
        sprintf(cards[i].suit, "Diamonds");
        cards[i].valueSuit[1] = 2;
        break;
             
   
      case 'H':
        sprintf(cards[i].suit, "Hearts");
        cards[i].valueSuit[2] = 3;
        break;
             
   
      case 'S':
        sprintf(cards[i].suit, "Spades");
        cards[i].valueSuit[3] = 4;
        break;
             
   
      default:
        printf("Invalid suit character for card #%d.\n", i+1);
        failed = 1;
        break;
      }
  }
 
    if(failed == 1){
      printf("Invalid value or suit character. Program exiting.\n");
      return 0;
  }
 


    for(int i = 0; i < 5; i++)
      printf("%s of %s\n", cards[i].value, cards[i].suit);
     
      printf("\n");
}

---

i keep getting duplicate error for valueAmount

Quote:

---

Originally Posted by MF1991

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
 
 typedef struct {
  char* shortValue;
  char shortSuit[1];
  char value[20];
  char suit[20];
 } CARD;
/*...*/
          case '2':
          sprintf(cards[i].value, "Two");
          cards[i].valueAmount[0] = 2;
          break;

---

i keep getting duplicate error for valueAmount

---

valueAmount should be a member of your CARD structure. Also it's not an array so you don't need brackets.

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
 
 typedef struct {
  char* shortValue;
  char shortSuit[5];
  char value[20];
  char suit[20];
  char valueAmount[13];
 
 } CARD;

 case '2':
          sprintf(cards[i].value, "Two");
          cards[i].valueAmount[0] = 2;
          break;
                 
       
        case '3':
          sprintf(cards[i].value, "Three");
          cards[i].valueAmount[1] = 3;
          break;
                 
       
        case '4':
          sprintf(cards[i].value, "Four");
          cards[i].valueAmount[2] = 4;
          break;
                 
     
        case '5':
          sprintf(cards[i].value, "Five");
          cards[i].valueAmount[3] = 5;
          break;
                 
     
        case '6':
          sprintf(cards[i].value, "Six");
          cards[i].valueAmount[4] = 6;
          break;
                 
     
        case '7':
          sprintf(cards[i].value, "Seven");
          cards[i].valueAmount[5] = 7;
          break;
                 
       
        case '8':
          sprintf(cards[i].value, "Eight");
          cards[i].valueAmount[6] = 8;
          break;
       
   
        case '9':
          sprintf(cards[i].value, "Nine");
          cards[i].valueAmount[7] = 9;
          break;
       
   
        case '0':
          sprintf(cards[i].value, "Ten");
          cards[i].valueAmount[8] = 10;
          break;
                 
     
        case 'J':
          sprintf(cards[i].value, "Jack");
          cards[i].valueAmount[9] = 11;
          score += 1;
          break;
                 
   
        case 'Q':
          sprintf(cards[i].value, "Queen");
          cards[i].valueAmount[10] = 12;
          score += 1;
          break;
                 
     
        case 'K':
          sprintf(cards[i].value, "King");
          cards[i].valueAmount[11] = 13;
          score += 1;
          break;
   
     
        case 'A':
          sprintf(cards[i].value, "Ace");
          cards[i].valueAmount[12] = 14;
          score += 1;
          break;

---

Ive done as you said, so how would i implement this into sorting my values? :)

Quote:

---

Originally Posted by MF1991

Code:

---

  typedef struct {
  char* shortValue;
  char shortSuit[5];
  char value[20];
  char suit[20];
  char valueAmount[13];
 
 } CARD;
/*...*/
 case '2':
          sprintf(cards[i].value, "Two");
          cards[i].valueAmount[0] = 2;
          break;

---

Ive done as you said, so how would i implement this into sorting my values? :)

---

I don't see how it could work this way. You need a single item (not an array) that can tell you what the value of a card is. For example, suppose you compare card N and card M. Which one comes first? I.e.. You need to be able to say something like

Code:

---

if (card[N].valueAmount < card[M].valueAmount)
    printf("card N is lower\n");

---

In other words, get rid of the brackets on valueAmount

can you give me an example on how i can implement and place it within my code plz? :)

Quote:

---

Originally Posted by MF1991

can you give me an example on how i can implement and place it within my code plz? :)

---

Yes, get rid of the brackets and then use the if statement in the previous post

Code:

---


 case '2':
          sprintf(cards[i].value, "Two");
          cards[i].valueAmount = 2;
          break;
                 
       
        case '3':
          sprintf(cards[i].value, "Three");
          cards[i].valueAmount = 3;
          break;
                 
       
        case '4':
          sprintf(cards[i].value, "Four");
          cards[i].valueAmount = 4;
          break;
                 
     
        case '5':
          sprintf(cards[i].value, "Five");
          cards[i].valueAmount = 5;
          break;
                 
     
        case '6':
          sprintf(cards[i].value, "Six");
          cards[i].valueAmount = 6;
          break;
                 
     
        case '7':
          sprintf(cards[i].value, "Seven");
          cards[i].valueAmount = 7;
          break;
                 
       
        case '8':
          sprintf(cards[i].value, "Eight");
          cards[i].valueAmount = 8;
          break;
       
   
        case '9':
          sprintf(cards[i].value, "Nine");
          cards[i].valueAmount = 9;
          break;
       
   
        case '0':
          sprintf(cards[i].value, "Ten");
          cards[i].valueAmount = 10;
          break;
                 
     
        case 'J':
          sprintf(cards[i].value, "Jack");
          cards[i].valueAmount = 11;
          score += 1;
          break;
                 
   
        case 'Q':
          sprintf(cards[i].value, "Queen");
          cards[i].valueAmount = 12;
          score += 1;
          break;
                 
     
        case 'K':
          sprintf(cards[i].value, "King");
          cards[i].valueAmount = 13;
          score += 1;
          break;
   
     
        case 'A':
          sprintf(cards[i].value, "Ace");
          cards[i].valueAmount = 14;
          score += 1;
          break;
       
     
        default:
            printf("Invalid value character for card #%d. \n", i+1);
            failed = 1;
            break;
        }
    }

---

Would i put the if statements under here and how many? or would it be under every case?

Quote:

---

Originally Posted by MF1991

Would i put the if statements under here and how many? or would it be under every case?

---

Put the if statements in your compar function. It should look like this:

Code:

---

int compar(const void *a, const void *b) {
        const CARD *carda = a;
        const CARD *cardb = b;

if (...)  // then carda comes before cardb
  return -1;
if (...)  // then carda comes after cardb
  return 1;

// otherwise carda and cardb are the same
return 0;
}

---

Fill in the if statements so that the function returns -1 when a comes before b, 1 when a comes after b, and 0 when a and b are the same.

Since carda and cardb are pointers, you access the members with the -> operator rather than the . operator.