Floating point exception( core dump) error in my program..

i m stuck at one problem...this is the program to print the given integer in words...plzz hep me to solve,,,,

Code:

---

#include<stdio.h>
main()
{
 int num,temp1,temp2,cnt,temp3,temp4,a;
 printf("Enter the number=");
 scanf("%d",&num);
 temp1=1;
 cnt=-1;
 temp3=num;
 while(temp3)
 {
  temp2=temp3;
  while(temp2)
 {
  temp2=temp2/10;
  cnt++;
 }
 a=cnt;
 while(a)
 {
  a--;
  temp1=temp1*10;
 }
 temp4=temp3/temp1;
 switch(temp4)
 {
  case 1:
  printf("one ");
  break;
  case 2:
  printf("two ");
  break;
  case 3:
  printf("three ");
  break;
  case 4:
  printf("four ");
  break;
  case 5:
  printf("five ");
  break;
  case 6:
  printf("six ");
  break;
  case 7:
  printf("seven ");
  break;
  case 8:
  printf("eight ");
  break;
  case 0:
  printf("nine ");
  break;
  default:
  printf("zero ");
 }
 
 temp3=temp3%temp1;
 }
}

---

Wow man. Try to wright your program with indents, and with proper new lines. This is hardly readable. Try like this:

Code:

---

int num,temp1,temp2,cnt,temp3,temp4,a;
   
    printf("Enter the number=");
    scanf("%d",&num);
   
    temp1=1;
    cnt=-1;
    temp3=num;
   
    while(temp3)
    {
        temp2=temp3;
        while(temp2)
        {
            temp2=temp2/10;
            cnt++;
        }
        a=cnt;
        while(a)
        {
            a--;

---

and so on.
Do you even now what you wrote in your program?

Can you please copy paste the error you get?

However if I input zero, no output will be produced.

Try to use do while instead of while, because if user inputs zero program will evaluate condition in while as false and skip while loop.

i cannot use do while loop because this is my assignment using while loop......can anyone give me solution of this error..

Your case 0 says "nine"

But beside that, you are getting that error when temp1 is 0 and you try to divide something by it.

3 lines from end you are using the "%" operator; why?

Code:

---

temp3=temp3%temp1;

---

Tim S.

Quote:

---

Originally Posted by stahta01

3 lines from end you are using the "%" operator; why?

Code:

---

temp3=temp3%temp1;

---

Tim S.

---

dude i m using logic here
let take example with num=456
and i need at output is four five six
first i divide 456/100=4 then print
now i need 56/10=5
thats why i use 456%100=56
after that agai loop
thats why i use

Code:

---


temp3=temp3%temp1;

---

Quote:

---

Originally Posted by Click_here

Your case 0 says "nine"

But beside that, you are getting that error when temp1 is 0 and you try to divide something by it.

---

dude temp1 can never be zero because i initialize temp1=1....

Edited: Changed the word "logic" to "implementation"; because logic was OK. Coding was not OK.
No you are using poor implementation here.

These lines to initialize the vars for the while loops are only done once!!

temp1=1;
cnt=-1;

They need to be done in the correct place!

If you describe the problem or used real descriptive variable names it would be easier to figure out your issue.

I suggest adding these lines before the line your change temp3; or use a debugger.

Code:

---

        printf("temp1:= %d \n", temp1);
        printf("temp2:= %d \n", temp2);
        printf("temp3:= %d \n", temp3);
        printf("temp4:= %d \n", temp4);

---

Edit: After I fixed the other mistakes this line did work OK "temp3=temp3%temp1;" but till I fixed the temp1 calculation it was an endless loop.

Tim S.

Well line 51 is an obvious mistake.

Other than that, the main problem here is your lack of using a debugger. You need to learn to use that - you won't get far without it. Ask us how we can help you with that, and provide details as to what you have available.

Quote:

---

Originally Posted by nareshlove

dude temp1 can never be zero because i initialize temp1=1....

---

Well... not in the first loop

But I put an "assert" in your code earlier today and ran it, and yes it does become 0.

Code:

---

#include <assert.h>

...

assert(temp1 != 0);
temp4=temp3/temp1;

---

It fails there after a few loops.

Quote:

---

Originally Posted by nareshlove

i cannot use do while loop because this is my assignment using while loop......can anyone give me solution of this error..

---

Then you should use if before while if you need to printf zero for input 0.

Also try writing new program from beggining, do it step by step. At beginning do not use tons of variables, insert them only when you really need them. This names temp1, temp2, temp3 can really be confusive, so give them descriptive names. And also after every step use printf or debugger to see where are you going.