Is this reading file true?

I am programming in visual studio 2010 and
want to read some text files (page1.txt page2.txt ...)(that each has some characters and numbers),that their names are in the other text file(gamemap.txt)
at first i open gamemap.txt

Code:

---

FILE* ptr_map;
    ptr_map=fopen("gamemap.txt","r");

---

then want to read lines one by one (each line is something like page6.txt)

Code:

---

fscanf(ptr_map,"%s",current->page);

---

that Page* current=(Page*)malloc(sizeof(Page));

and Page is:

Code:

---

                      typedef struct PAGE{

                        char page[10];
                        shape* element;
                        struct PAGE* next;
                        struct PAGE* previous;
                      } Page;

---

after reading the first line i want to put(or copy)this string in an array that is belong to a structure and then open the corresponding text file and then read it.

Code:

---

FILE* ptr_page=fopen(current->page,"r");

---

see these pictures

is it correct?

No. fscanf() won't read in an entire line of text. It will stop reading in, when the first word ends.

Use fgets(buffer, sizeof(buffer, filePointer). THAT will read in an entire line of text. And this, will read in the entire text file, line by line:

Code:

---

char buffer[100];
FILE *fp;

//open the file here, and test if it opened OK also.



while((fgets(buffer, sizeof(buffer), fp)) != NULL) {
  //all your code to do what you want with this line of text

}

fclose(fp); //the file has been read, so close it.

---

If you need to grab a corresponding file name, then use strstr(), to find it for you, within the buffer, as the while loop iterates. You will need to include string.h in your program to use strstr().

Be aware that fgets() will keep a newline at the end of any line (space permitting), into the buffer, as well as an end of string char marker: '\0'.

I did but you can see what happened!:frown:

It appears from your pic that page[] needs to be quite a bit bigger to handle all the whitespace (which fgets() will be saving).

Isn't current->page a pointer to page, so you don't want sizeof() on just the pointer?

i incremented the size of current->page (1000) but that error happened again.????????what should i do?


and if that you said about pointer... when you identify buffer : char buffer[100]; so <buffer> is a pointer too. so i did something like you(sizeof ( a pointer). what's the problem?

help!

Quote:

---

Originally Posted by mathink

i incremented the size of current->page (1000) but that error happened again.????????what should i do?


and if that you said about pointer... when you identify buffer : char buffer[100]; so <buffer> is a pointer too. so i did something like you(sizeof ( a pointer). what's the problem?

help!

---

sizeof() is calculated at compile time. At compile time, buffer[] had a known (and large) size - it was NOT just the size of a pointer.

Not so with the pointers whom you allocate memory to, at run time. They would be given the size they had at compile time, which is usually 2 or 4 bytes, only.

Print out the sizeof() each, and see for yourself. Note that sizeof() an array, works in main(). After the array is passed as a parameter to another function, it "decays" to the size of a pointer. At that time, you need to pass the sizeof() the array, into the function that you have called.

After you fix the first problem, what do you do next? You fix the second problem.

'Cause you is da Fixer! :cool:

There may be other problems, but if so, we'll get to them.

ok

i corrected it.

thanks so much!!