I am new to this forum

Hey Everyone
I am new to this forum

I have an issue with my C programming assignment
there are some error in simple C program

PLEASE !
If I paste the code here can anybody can help me that what mistake i have made ? while coding !

Welcome to the forum!!

Of course, here there are many very good programmers, who, for sure, can say something about every code they see!

Post your code in code tags
[key]/*your program*/[/key]
replace key with code in order this to work

Code:

---

#include<stdio.h>#include<conio.h>
void main()
{


                                            /* Getting Inital Values */


int english,electronics,programming,itc,calculus;
int sum,roll;
//char grade_total[];
char grade_english[1];
char grade_electronics[1];
char grade_programming[1];
char grade_itc[5];char grade_calculus[5];
float gpa_english,gpa_electronics,gpa_programming,gpa_itc,gpa_calculus;
float percentage;
char name[20];
//char remarks_total;
char remarks_english[10],remarks_electronics[10],remarks_programming[10],remarks_itc[10],remarks_calculus[10];


                                            /* Getting User Personal Info */


printf("\n Please Enter Your Name : ");
scanf("%d",&name);
printf("\n Please Enter Your Roll Number : ");
scanf("%d",&roll);


                                            /* Getting User Academic Record */




printf("\n Please Enter Your Marks in Programming : ");
scanf("%d",&programming);
printf("\n Please Enter Your Marks in Electronics : ");
scanf("%d",&electronics);
printf("\n Please Enter Your Marks in I.T.C : ");
scanf("%d",&itc);
printf("\n Please Enter Your Marks in Calculus : ");
scanf("%d",&calculus);
printf("\n Please Enter Your Marks in English : ");
scanf("%d",&english);


                                  /* If Condition - Programming Marks - for GPA and Grade and Remarks */


if(programming>=85)
{
grade_programming="A+";
gpa_programming=4.0;
grade_programming="Exceptional";
}


if(programming>=80&&programming<=84)
{
grade_programming='A';
gpa_programming=3.7;
remarks_programming="Outstanding";
}


if(programming>=75&&programming<=79)
{
grade_programming="B+";
gpa_programming=3.4;
remarks_programming="Excellent";
}


if(programming>=70&&programming<=74)
{
grade_programming='B';
gpa_programming=3.0;
remarks_programming="Very Good";
}


if(programming>=65&&programming<=69)
{
grade_programming="B-";
gpa_programming=2.5;
remarks_programming="Good";
}


if(programming>=60&&programming<=64)
{
grade_programming="C+";
gpa_programming=2.0;
remarks_programming="Average";
}


if(programming>=55&&programming<=59)
{
grade_programming='C';
gpa_programming=1.5;
remarks_programming="Satisfactory";
}


if(programming>=50&&programming<=54)
{
grade_programming='D';
gpa_programming=1.0;
remarks_programming="Pass";
}


if(programming<=49)
{
grade_programming='F';
gpa_programming=0.0;
remarks_programming="Fail";
}






                                  /* If Condition - English Marks - for GPA and Grade and Remarks */








if(english>=85)
{
grade_english='A';
gpa_english=4.0;
remarks_english="Exceptional";
}


if(english>=80&&english<=84)
{
grade_english='A';
gpa_english=3.7;
remarks_english="Outstanding";
}


if(english>=75&&english<=79)
{
grade_english="B+";
gpa_english=3.4;
remarks_english="Excellent";
}


if(english>=70&&english<=74)
{
grade_english='B';
gpa_english=3.0;
remarks_english="Very Good";
}


if(english>=65&&english<=69)
{
grade_english="B-";
gpa_english=2.5;
remarks_english="Good";
}


if(english>=60&&english<=64)
{
grade_english="C+";
gpa_english=2.0;
remarks_english="Average";
}


if(english>=55&&english<=59)
{
grade_english='C';
gpa_english=1.5;
remarks_english="Satisfactory";
}


if(english>=50&&english<=54)
{
grade_english='D';
gpa_english=1.0;
remarks_english="Pass";
}


if(english<=49)
{
grade_english='F';
gpa_english=0.0;
remarks_english="Fail;
}




                                  /* If Condition - Electronics Marks - for GPA and Grade and Remarks */






if(electronics>=85)
{
grade_electronics='A';
gpa_electronics=4.0;
remarks_electronics="Exceptional";
}


if(electronics>=80&&electronics<=84)
{
grade_electronics='A';
gpa_electronics=3.7;
remarks_electronics="Outstanding";
}


if(electronics>=75&&electronics<=79)
{
grade_electronics="B+";
gpa_electronics=3.4;
remarks_electronics="Excellent";
}


if(electronics>=70&&electronics<=74)
{
grade_electronics='B';
gpa_electronics=3.0;
remarks_electronics="Very Good";
}


if(electronics>=65&&electronics<=69)
{
grade_electronics="B-";
gpa_electronics=2.5;
remarks_electronics="Good";
}


if(electronics>=60&&electronics<=64)
{
grade_electronics="C+";
gpa_electronics=2.0;
remarks_electronics="Average";
}


if(electronics>=55&&electronics<=59)
{
grade_electronics='C';
gpa_electronics=1.5;
remarks_electronics="Satisfactory";
}


if(electronics>=50&&electronics<=54)
{
grade_electronics='D';
gpa_electronics=1.0;
remarks_electronics="Pass";
}


if(electronics<=49)
{
grade_electronics='F';
gpa_electronics=0.0;
remarks_electronics="Fail;
}






                                  /* If Condition - I.T.C Marks - for GPA and Grade and Remarks */






if(itc>=85)
{
grade_itc='A';
gpa_itc=4.0;
remarks_itc="Exceptional";
}


if(itc>=80&&itc<=84)
{
grade_itc='A';
gpa_itc=3.7;
remarks_itc="Outstanding";
}


if(itc>=75&&itc<=79)
{
grade_itc="B+";
gpa_itc=3.4;
remarks_itc="Excellent";
}


if(itc>=70&&itc<=74)
{
grade_itc='B';
gpa_itc=3.0;
remarks_itc="Very Good";
}


if(itc>=65&&itc<=69)
{
grade_itc="B-";
gpa_itc=2.5;
remarks_itc="Good";
}


if(itc>=60&&itc<=64)
{
grade_itc="C+";
gpa_itc=2.0;
remarks_itc="Average";
}


if(itc>=55&&itc<=59)
{
grade_itc='C';
gpa_itc=1.5;
remarks_itc="Satisfactory";
}


if(itc>=50&&itc<=54)
{
grade_itc='D';
gpa_itc=1.0;
remarks_itc="Pass";
}


if(itc<=49)
{
grade_itc='F';
gpa_itc=0.0;
remarks_itc="Fail;
}




                                  /* If Condition - Calculus Marks - for GPA and Grade and Remarks */






if(calculus>=85)
{
grade_calculus='A';
gpa_calculus=4.0;
remarks_calculus="Exceptional";
}


if(calculus>=80&&calculus<=84)
{
grade_calculus='A';
gpa_calculus=3.7;
remarks_calculus="Outstanding";
}


if(calculus>=75&&calculus<=79)
{
grade_calculus="B+";
gpa_calculus=3.4;
remarks_calculus="Excellent";
}


if(calculus>=70&&calculus<=74)
{
grade_calculus='B';
gpa_calculus=3.0;
remarks_calculus="Very Good";
}


if(calculus>=65&&calculus<=69)
{
grade_calculus="B-";
gpa_calculus=2.5;
remarks_calculus="Good";
}


if(calculus>=60&&calculus<=64)
{
grade_calculus="C+";
gpa_calculus=2.0;
remarks_calculus="Average";
}


if(calculus>=55&&calculus<=59)
{
grade_calculus='C';
gpa_calculus=1.5;
remarks_calculus="Satisfactory";
}


if(calculus>=50&&calculus<=54)
{
grade_calculus='D';
gpa_calculus=1.0;
remarks_calculus="Pass";
}


if(calculus<=49)
{
grade_calculus='F';
gpa_calculus=0.0;
remarks_calculus="Fail;
}




                                                /* Finalizing the Conditions */


sum=english+electronics+programming+itc+calculus;
percentage=(sum*100)/500;


gets(name);
printf("\n Roll Number : %d ",roll);


printf("\n English      %d      %f    %s    %s ",english,gpa_english,remarks_english,grade_english);
printf("\n Electronics  %d      %f    %s    %s ",electronics,gpa_electronics,remarks_electronics,grade_electronics);
printf("\n Programming  %d      %f    %s    %s ",programming,gpa_programming,remarks_programming,grade_programming);
printf("\n ITC  %d      %f    %s    %s ",itc,gpa_itc,remarks_itc,grade_itc);
printf("\n Calculus      %d      %f    %s    %s ",calculus,gpa_calculus,remarks_calculus,grade_calculus);


printf("\n \n \t The Total Marks You got are %d" and your Percentage is %f,sum,percentage);
getch();
}

---

Hope My issue will be solved !

Ok, beginner's tips about to come :)

• We write
  Code:

  ---

  int main(void)

  ---

  and not
  Code:

  ---

  void main()

  ---

• When you want to read a string into a char array you do it like this
  
  Code:

  ---

  scanf("%s", name);

  ---

  This is just ok for start
• When reporting a problem, it would be very nice and helpful if you provided the reason you post (which are the errors you get, etc.)

Lvalue required in 46 48 and .................................( 25 LINES)

I guess there is a simple error which i have made in all the lines
Please help me
i have to submit this assignment in few hours to professor !

Did you change what I said?

Yeah !
but still problem

Please check and open it in your Tubo c

than check the errors

and than tell me boss !

What is your current code? And no, I don't use Turbo C.

laserlight

Code:

---

#include<stdio.h>
#include<conio.h>
int main(void)
{


                                            /* Getting Inital Values */


int english,electronics,programming,itc,calculus;
int sum,roll;
//char grade_total[];
char grade_english[1];
char grade_electronics[1];
char grade_programming[1];
char grade_itc[5];char grade_calculus[5];
float gpa_english,gpa_electronics,gpa_programming,gpa_itc,gpa_calculus;
float percentage;
char name[20];
//char remarks_total;
char remarks_english[10],remarks_electronics[10],remarks_programming[10],remarks_itc[10],remarks_calculus[10];


                                            /* Getting User Personal Info */


printf("\n Please Enter Your Name : ");
scanf("%d",&name);
printf("\n Please Enter Your Roll Number : ");
scanf("%d",&roll);


                                            /* Getting User Academic Record */




printf("\n Please Enter Your Marks in Programming : ");
scanf("%d",&programming);
printf("\n Please Enter Your Marks in Electronics : ");
scanf("%d",&electronics);
printf("\n Please Enter Your Marks in I.T.C : ");
scanf("%d",&itc);
printf("\n Please Enter Your Marks in Calculus : ");
scanf("%d",&calculus);
printf("\n Please Enter Your Marks in English : ");
scanf("%d",&english);


                                  /* If Condition - Programming Marks - for GPA and Grade and Remarks */


if(programming>=85)
{
grade_programming="A+";
gpa_programming=4.0;
grade_programming="Exceptional";
}


if(programming>=80&&programming<=84)
{
grade_programming='A';
gpa_programming=3.7;
remarks_programming="Outstanding";
}


if(programming>=75&&programming<=79)
{
grade_programming="B+";
gpa_programming=3.4;
remarks_programming="Excellent";
}


if(programming>=70&&programming<=74)
{
grade_programming='B';
gpa_programming=3.0;
remarks_programming="Very Good";
}


if(programming>=65&&programming<=69)
{
grade_programming="B-";
gpa_programming=2.5;
remarks_programming="Good";
}


if(programming>=60&&programming<=64)
{
grade_programming="C+";
gpa_programming=2.0;
remarks_programming="Average";
}


if(programming>=55&&programming<=59)
{
grade_programming='C';
gpa_programming=1.5;
remarks_programming="Satisfactory";
}


if(programming>=50&&programming<=54)
{
grade_programming='D';
gpa_programming=1.0;
remarks_programming="Pass";
}


if(programming<=49)
{
grade_programming='F';
gpa_programming=0.0;
remarks_programming="Fail";
}






                                  /* If Condition - English Marks - for GPA and Grade and Remarks */








if(english>=85)
{
grade_english='A';
gpa_english=4.0;
remarks_english="Exceptional";
}


if(english>=80&&english<=84)
{
grade_english='A';
gpa_english=3.7;
remarks_english="Outstanding";
}


if(english>=75&&english<=79)
{
grade_english="B+";
gpa_english=3.4;
remarks_english="Excellent";
}


if(english>=70&&english<=74)
{
grade_english='B';
gpa_english=3.0;
remarks_english="Very Good";
}


if(english>=65&&english<=69)
{
grade_english="B-";
gpa_english=2.5;
remarks_english="Good";
}


if(english>=60&&english<=64)
{
grade_english="C+";
gpa_english=2.0;
remarks_english="Average";
}


if(english>=55&&english<=59)
{
grade_english='C';
gpa_english=1.5;
remarks_english="Satisfactory";
}


if(english>=50&&english<=54)
{
grade_english='D';
gpa_english=1.0;
remarks_english="Pass";
}


if(english<=49)
{
grade_english='F';
gpa_english=0.0;
remarks_english="Fail;
}




                                  /* If Condition - Electronics Marks - for GPA and Grade and Remarks */






if(electronics>=85)
{
grade_electronics='A';
gpa_electronics=4.0;
remarks_electronics="Exceptional";
}


if(electronics>=80&&electronics<=84)
{
grade_electronics='A';
gpa_electronics=3.7;
remarks_electronics="Outstanding";
}


if(electronics>=75&&electronics<=79)
{
grade_electronics="B+";
gpa_electronics=3.4;
remarks_electronics="Excellent";
}


if(electronics>=70&&electronics<=74)
{
grade_electronics='B';
gpa_electronics=3.0;
remarks_electronics="Very Good";
}


if(electronics>=65&&electronics<=69)
{
grade_electronics="B-";
gpa_electronics=2.5;
remarks_electronics="Good";
}


if(electronics>=60&&electronics<=64)
{
grade_electronics="C+";
gpa_electronics=2.0;
remarks_electronics="Average";
}


if(electronics>=55&&electronics<=59)
{
grade_electronics='C';
gpa_electronics=1.5;
remarks_electronics="Satisfactory";
}


if(electronics>=50&&electronics<=54)
{
grade_electronics='D';
gpa_electronics=1.0;
remarks_electronics="Pass";
}


if(electronics<=49)
{
grade_electronics='F';
gpa_electronics=0.0;
remarks_electronics="Fail;
}






                                  /* If Condition - I.T.C Marks - for GPA and Grade and Remarks */






if(itc>=85)
{
grade_itc='A';
gpa_itc=4.0;
remarks_itc="Exceptional";
}


if(itc>=80&&itc<=84)
{
grade_itc='A';
gpa_itc=3.7;
remarks_itc="Outstanding";
}


if(itc>=75&&itc<=79)
{
grade_itc="B+";
gpa_itc=3.4;
remarks_itc="Excellent";
}


if(itc>=70&&itc<=74)
{
grade_itc='B';
gpa_itc=3.0;
remarks_itc="Very Good";
}


if(itc>=65&&itc<=69)
{
grade_itc="B-";
gpa_itc=2.5;
remarks_itc="Good";
}


if(itc>=60&&itc<=64)
{
grade_itc="C+";
gpa_itc=2.0;
remarks_itc="Average";
}


if(itc>=55&&itc<=59)
{
grade_itc='C';
gpa_itc=1.5;
remarks_itc="Satisfactory";
}


if(itc>=50&&itc<=54)
{
grade_itc='D';
gpa_itc=1.0;
remarks_itc="Pass";
}


if(itc<=49)
{
grade_itc='F';
gpa_itc=0.0;
remarks_itc="Fail;
}




                                  /* If Condition - Calculus Marks - for GPA and Grade and Remarks */






if(calculus>=85)
{
grade_calculus='A';
gpa_calculus=4.0;
remarks_calculus="Exceptional";
}


if(calculus>=80&&calculus<=84)
{
grade_calculus='A';
gpa_calculus=3.7;
remarks_calculus="Outstanding";
}


if(calculus>=75&&calculus<=79)
{
grade_calculus="B+";
gpa_calculus=3.4;
remarks_calculus="Excellent";
}


if(calculus>=70&&calculus<=74)
{
grade_calculus='B';
gpa_calculus=3.0;
remarks_calculus="Very Good";
}


if(calculus>=65&&calculus<=69)
{
grade_calculus="B-";
gpa_calculus=2.5;
remarks_calculus="Good";
}


if(calculus>=60&&calculus<=64)
{
grade_calculus="C+";
gpa_calculus=2.0;
remarks_calculus="Average";
}


if(calculus>=55&&calculus<=59)
{
grade_calculus='C';
gpa_calculus=1.5;
remarks_calculus="Satisfactory";
}


if(calculus>=50&&calculus<=54)
{
grade_calculus='D';
gpa_calculus=1.0;
remarks_calculus="Pass";
}


if(calculus<=49)
{
grade_calculus='F';
gpa_calculus=0.0;
remarks_calculus="Fail;
}




                                                /* Finalizing the Conditions */


sum=english+electronics+programming+itc+calculus;
percentage=(sum*100)/500;


gets(name);
printf("\n Roll Number : %d ",roll);


printf("\n English      %d      %f    %s    %s ",english,gpa_english,remarks_english,grade_english);
printf("\n Electronics  %d      %f    %s    %s ",electronics,gpa_electronics,remarks_electronics,grade_electronics);
printf("\n Programming  %d      %f    %s    %s ",programming,gpa_programming,remarks_programming,grade_programming);
printf("\n ITC  %d      %f    %s    %s ",itc,gpa_itc,remarks_itc,grade_itc);
printf("\n Calculus      %d      %f    %s    %s ",calculus,gpa_calculus,remarks_calculus,grade_calculus);


printf("\n \n \t The Total Marks You got are %d" and your Percentage is %f,sum,percentage);
getch();
}

---

Welcome Raja! :cool:

I'm afraid almost no one here has turbo C anymore. I was one of the last "hold outs" to use it, and i stopped over a year ago. (I *love* Pelles C x64, btw.) Still, we can test your code, as long as it doesn't use the special functions that turbo C had: graphics, far pointers, especially. Conio.h is non-standard, but some of us can use it, (Pelles C allows it). Others can't.

I'll take a peek, but i believe STD has me beat on this. ;)

Edit:

In your remarks string, you have "Fail

What you need is to have "Fail"

With the closing double quotes on the end of the word. You have that in several places. Use your editor to find the word Fail, and you'll get right to them.

One more beginner's tip :
Read the whole posts. The words are there, because they have something to say.
When you are asked about something, answer honestly!
You said you changed what I said, but obviously you didn't read about scanf...

Adak, at least nothing sounds Greek to my now! :p (so everything cool)

Adak,
I am a beginner so In Uni, we start from this

Please tell me what mistake I have made
It takes many hour for a beginner like me to code that
I have to submit it to sir sooner
can anyone can reply me with the correct code after resolving erros from this and tell me what mistakes i have made !

std10093

That's not an array!

I havent use a single array ! Thats char size !

As far as I know, this

Code:

---

char name[20];

---

is an array of 20 characters.

I am new here myself but I think you could be more helpful by saying exactly the what problem is/what error message you are receiving.

What i want to make was
a chracter whose whose chracter length is 20 mean it can have 20 chracters !

Quote:

---

Originally Posted by rajatahirqaiser

What i want to make was
a chracter whose whose chracter length is 20 mean it can have 20 chracters !

---

That's exactly an array of 20 characters :)

SDH

Lvalue required in 46 48 and .................................( 25 LINES)

καλά!

Raja, all your grade electronics, grade english, grade programming arrays, are too small. Minimum size for "A+" is 3 chars: A, + and the end of string char: '\0'.
And you can't assign a string with the equal sign, you have to use string functions or:

Code:

---

grade_english[0]='A';
grade_english[1]='+';
grade_english[2]='\0';


But if you can use strings, then it's easier (but #include <string.h>):
strcpy(grade_programming,"A+");
gpa_programming=4.0;
strcpy(grade_programming,"Exceptional");

---

Adak

Didn't get you please explain !

In C, we can not assign a variable with a string by the equal (=) operator.

We have to use functions from string.h, like strcpy.

Or you have to do it as Adak said.

Adak, I guess google translate is your friend! Nice one!

@Std, thought you'd like that - and yes, Google knows some Greek.

Raja, the gpa_Variables, are OK, with the = assignment, but strings can't be assigned with the equal sign. Use strcpy(), as I've shown you , above. LOTS of errors there!

Quote:

---

Originally Posted by Adak

@Std, thought you'd like that - and yes, Google knows some Greek.

Raja, the gpa_Variables, are OK, with the = assignment, but strings can't be assigned with the equal sign. Use strcpy(), as I've shown you , above. LOTS of errors there!

---

Adak, I have already "liked" it ;)

@Raja, too many said, take a 5min break and think of what was said. Then try to debug :)

means header should be

Code:

---

#include<stdio.h>
#include<conio.h>
#include<string.h>
int main(void)
{

---

.................................................. ..................
and In each i have to change from
.................................................. .........

Code:

---

if(programming>=85)
{
grade_programming="A+";
gpa_programming=4.0;
grade_programming="Exceptional";
}

---

to

Code:

---

if(programming>=85)
{
strcpy(grade_programming,"A+");
strcpy(gpa_programming,"4.0");
strcpy(grade_programming,"Exceptional");
}

---

This is how the first few lines of your program should look:

Code:

---

#include<stdio.h>
#include<string.h>
#include<conio.h>
int main(void)
{


                                            /* Getting Inital Values */


int english,electronics,programming,itc,calculus;
int sum,roll;
//char grade_total[];
char grade_english[3];
char grade_electronics[3];
char grade_programming[3];
char grade_itc[5];char grade_calculus[5];
float gpa_english,gpa_electronics,gpa_programming,gpa_itc,gpa_calculus;
float percentage;
char name[20];
//char remarks_total;
char remarks_english[10],remarks_electronics[10],remarks_programming[10],remarks_itc[10],remarks_calculus[10];


                                            /* Getting User Personal Info */


printf("\n Please Enter Your Name : ");
scanf("%d",name);
printf("\n Please Enter Your Roll Number : ");
scanf("%d",&roll);


                                            /* Getting User Academic Record */


printf("\n Please Enter Your Marks in Programming : ");
scanf("%d",&programming);
printf("\n Please Enter Your Marks in Electronics : ");
scanf("%d",&electronics);
printf("\n Please Enter Your Marks in I.T.C : ");
scanf("%d",&itc);
printf("\n Please Enter Your Marks in Calculus : ");
scanf("%d",&calculus);
printf("\n Please Enter Your Marks in English : ");
scanf("%d",&english);


                                  /* If Condition - Programming Marks - for GPA and Grade and Remarks */


if(programming>=85)
{
strcpy(grade_programming,"A+"); //string copy needed
gpa_programming=4.0;    //float, no string copy needed
strcpy(grade_programming,"Exceptional"); //string copy needed
}


if(programming>=80&&programming<=84)
{
strcpy(grade_programming,"A");  //same as above
gpa_programming=3.7;
strcpy(remarks_programming,"Outstanding");
}


if(programming>=75&&programming<=79)
{
strcpy(grade_programming,"B+");
gpa_programming=3.4;
strcpy(remarks_programming,"Excellent");
}


if(programming>=70&&programming<=74)
{
strcpy(grade_programming,"B");;
gpa_programming=3.0;
strcpy(remarks_programming,"Very Good");
}

---

As Adak said, you have to do that AND to have enough space in your arrays.
This

Code:

---

char grade_electronics[1];

---

can have only one character!!!! And what about the null terminator of the strings ????????
You need to have enough space to fit the string +1 for the null terminator.
Actually what are you doing? You want to assign A+ to grade of programming or Exceptional??
Decide which the max length your array may have, let's say 12, if you use Exceptional (11 letters + 1 for the null terminator), then
you should declare the array like this

Code:

---

char grade_electronics[12];

---

//Adak just 3 for grade programming won't make the work

I'm making the comments as I go, rather than reviewing the whole program first. Sort of a running commentary:

First 200 lines or so:

Code:

---


#include<stdio.h>
#include<string.h>
#include<conio.h>
int main(void)
{

                                            /* Getting Inital Values */


int english,electronics,programming,itc,calculus;
int sum,roll;
//char grade_total[];
char grade_english[3];
char grade_electronics[3];
char grade_programming[3];
char grade_itc[5];char grade_calculus[5];
float gpa_english,gpa_electronics,gpa_programming,gpa_itc,gpa_calculus;
float percentage;
char name[20];
//char remarks_total;
char remarks_english[10],remarks_electronics[10],remarks_programming[10],remarks_itc[10],remarks_calculus[10];


                                            /* Getting User Personal Info */


printf("\n Please Enter Your Name : ");
scanf("%s",name);
printf("\n Please Enter Your Roll Number : ");
scanf("%d",&roll);

                                            /* Getting User Academic Record */


printf("\n Please Enter Your Marks in Programming : ");
scanf("%d",&programming);
printf("\n Please Enter Your Marks in Electronics : ");
scanf("%d",&electronics);
printf("\n Please Enter Your Marks in I.T.C : ");
scanf("%d",&itc);
printf("\n Please Enter Your Marks in Calculus : ");
scanf("%d",&calculus);
printf("\n Please Enter Your Marks in English : ");
scanf("%d",&english);


                                  /* If Condition - Programming Marks - for GPA and Grade and Remarks */


if(programming>=85)
{
strcpy(grade_programming,"A+");
gpa_programming=4.0;
strcpy(grade_programming,"Exceptional");
}


if(programming>=80&&programming<=84)
{
strcpy(grade_programming,"A");
gpa_programming=3.7;
strcpy(remarks_programming,"Outstanding");
}


if(programming>=75&&programming<=79)
{
strcpy(grade_programming,"B+");
gpa_programming=3.4;
strcpy(remarks_programming,"Excellent");
}


if(programming>=70&&programming<=74)
{
strcpy(grade_programming,"B");;
gpa_programming=3.0;
strcpy(remarks_programming,"Very Good");
}


if(programming>=65&&programming<=69)
{
strcpy(grade_programming,"B-");
gpa_programming=2.5;
strcpy(remarks_programming,"Good");
}


if(programming>=60&&programming<=64)
{
strcpy(grade_programming,"C+");
gpa_programming=2.0;
strcpy(remarks_programming,"Average");
}


if(programming>=55&&programming<=59)
{
strcpy(grade_programming,"C");
gpa_programming=1.5;
strcpy(remarks_programming,"Satisfactory");
}


if(programming>=50&&programming<=54)
{
strcpy(grade_programming,"D");
gpa_programming=1.0;
strcpy(remarks_programming,"Pass");
}


if(programming<=49)
{
strcpy(grade_programming,"F");
gpa_programming=0.0;
strcpy(remarks_programming,"Fail");
}


                                  /* If Condition - English Marks - for GPA and Grade and Remarks */

if(english>=85)
{
strcpy(grade_english,"A");
gpa_english=4.0;
strcpy(remarks_english,"Exceptional");
}


if(english>=80&&english<=84)
{
strcpy(grade_english,"A");
gpa_english=3.7;
strcpy(remarks_english,"Outstanding");
}


if(english>=75&&english<=79)
{
strcpy(grade_english,"B+");
gpa_english=3.4;
strcpy(remarks_english,"Excellent");
}


if(english>=70&&english<=74)
{
strcpy(grade_english,"B");
gpa_english=3.0;
strcpy(remarks_english,"Very Good");
}


if(english>=65&&english<=69)
{
strcpy(grade_english,"B-");
gpa_english=2.5;
strcpy(remarks_english,"Good");
}


if(english>=60&&english<=64)
{
strcpy(grade_english,"C+");
gpa_english=2.0;
strcpy(remarks_english,"Average");
}


if(english>=55&&english<=59)
{
strcpy(grade_english,"C");
gpa_english=1.5;
strcpy(remarks_english,"Satisfactory");
}


if(english>=50&&english<=54)
{
strcpy(grade_english,"D");
gpa_english=1.0;
strcpy(remarks_english,"Pass");
}


if(english<=49)
{
strcpy(grade_english,"F");
gpa_english=0.0;
strcpy(remarks_english,"Fail");
}




                                  /* If Condition - Electronics Marks - for GPA and Grade and Remarks */



if(electronics>=85)
{
strcpy(grade_electronics,"A");
gpa_electronics=4.0;
strcpy(remarks_electronics,"Exceptional");
}

---

When do you have to turn this in, Raja?

Quote:

---

Originally Posted by rajatahirqaiser

means header should be

Code:

---

#include<stdio.h>
#include<conio.h>
#include<string.h>
int main(void)
{

---

.................................................. ..................
and In each i have to change from
.................................................. .........

Code:

---

if(programming>=85)
{
grade_programming="A+";
gpa_programming=4.0;
grade_programming="Exceptional";
}

---

to

Code:

---

if(programming>=85)
{
strcpy(grade_programming,"A+");
strcpy(gpa_programming,"4.0");        <======NO! Leave that one with the equal sign, it's a float!!
strcpy(grade_programming,"Exceptional");
}

---

---

NO! Leave the = sign in place, for all the floats! Just change the strings to use strcpy().

Now my code after debugging is

Code:

---

#include<stdio.h>
#include<string.h>
#include<conio.h>
int main(void)
{
clrscr();




                                            /* Getting Inital Values */




int english,electronics,programming,itc,calculus;
int sum,roll;
//char grade_total[];
char grade_english[3];
char grade_electronics[3];
char grade_programming[3];
char grade_itc[3];char grade_calculus[3];
float gpa_english,gpa_electronics,gpa_programming,gpa_itc,gpa_calculus;
float percentage;
char name[20];
//char remarks_total;
char remarks_english[10],remarks_electronics[10],remarks_programming[10],remarks_itc[10],remarks_calculus[10];




                                            /* Getting User Personal Info */




printf("\n Please Enter Your Name : ");
scanf("%d",name);
printf("\n Please Enter Your Roll Number : ");
scanf("%d",&roll);   
printf("\n Please Enter Your Marks in Programming : ");
scanf("%d",&programming);


                              /* If Condition - Programming Marks - for GPA and Grade and Remarks */




if(programming>=85)
{
strcpy(grade_programming,"A+");
gpa_programming=4.0;
strcpy(grade_programming,"Exceptional");
}




if(programming>=80&&programming<=84)
{
strcpy(grade_programming,"A");
gpa_programming=3.7;
strcpy(remarks_programming,"Outstanding");
}




if(programming>=75&&programming<=79)
{
strcpy(grade_programming,"B+");
gpa_programming=3.4;
strcpy(remarks_programming,"Excellent");
}




if(programming>=70&&programming<=74)
{
strcpy(grade_programming,"B");;
gpa_programming=3.0;
strcpy(remarks_programming,"Very Good");
}




if(programming>=65&&programming<=69)
{
strcpy(grade_programming,"B--");
gpa_programming=2.5;
strcpy(remarks_programming,"Good");
}


if(programming>=60&&programming<=64)
{
strcpy(grade_programming,"C+");
gpa_programming=2.0;
strcpy(remarks_programming,"Average");
}


if(programming>=55&&programming<=59)
{
strcpy(grade_programming,"C");
gpa_programming=1.5;
strcpy(remarks_programming,"Satisfactory");
}


if(programming>=50&&programming<=54)
{
strcpy(grade_programming,"D");
gpa_programming=1.0;
strcpy(remarks_programming,"Pass");
}


if(programming<=49)
{
strcpy(grade_programming,"F");
gpa_programming=0.0;
strcpy(remarks_programming,"Fail");
}




printf("\n Please Enter Your Marks in Electronics : ");
scanf("%d",&electronics);




                                 


                                  /* If Condition - Electronics Marks - for GPA and Grade and Remarks */


if(electronics>=85)
{
strcpy(grade_electronics,"A+");
gpa_electronics=4.0;
strcpy(grade_electronics,"Exceptional");
}




if(electronics>=80&&electronics<=84)
{
strcpy(grade_electronics,"A");
gpa_electronics=3.7;
strcpy(remarks_electronics,"Outstanding");
}




if(electronics>=75&&electronics<=79)
{
strcpy(grade_electronics,"B+");
gpa_electronics=3.4;
strcpy(remarks_electronics,"Excellent");
}




if(electronics>=70&&electronics<=74)
{
strcpy(grade_electronics,"B");;
gpa_electronics=3.0;
strcpy(remarks_electronics,"Very Good");
}




if(electronics>=65&&electronics<=69)
{
strcpy(grade_electronics,"B--");
gpa_electronics=2.5;
strcpy(remarks_electronics,"Good");
}


if(electronics>=60&&electronics<=64)
{
strcpy(grade_electronics,"C+");
gpa_electronics=2.0;
strcpy(remarks_electronics,"Average");
}


if(electronics>=55&&electronics<=59)
{
strcpy(grade_electronics,"C");
gpa_electronics=1.5;
strcpy(remarks_electronics,"Satisfactory");
}


if(electronics>=50&&electronics<=54)
{
strcpy(grade_electronics,"D");
gpa_electronics=1.0;
strcpy(remarks_electronics,"Pass");
}


if(electronics<=49)
{
strcpy(grade_electronics,"F");
gpa_electronics=0.0;
strcpy(remarks_electronics,"Fail");
}


printf("\n Please Enter Your Marks in I.T.C : ");
scanf("%d",&itc);


                            /* If Condition - I.T.C Marks - for GPA and Grade and Remarks */


if(itc>=85)
{
strcpy(grade_itc,"A+");
gpa_itc=4.0;
strcpy(grade_itc,"Exceptional");
}




if(itc>=80&&itc<=84)
{
strcpy(grade_itc,"A");
gpa_itc=3.7;
strcpy(remarks_itc,"Outstanding");
}




if(itc>=75&&itc<=79)
{
strcpy(grade_itc,"B+");
gpa_itc=3.4;
strcpy(remarks_itc,"Excellent");
}




if(itc>=70&&itc<=74)
{
strcpy(grade_itc,"B");;
gpa_itc=3.0;
strcpy(remarks_itc,"Very Good");
}




if(itc>=65&&itc<=69)
{
strcpy(grade_itc,"B--");
gpa_itc=2.5;
strcpy(remarks_itc,"Good");
}


if(itc>=60&&itc<=64)
{
strcpy(grade_itc,"C+");
gpa_itc=2.0;
strcpy(remarks_itc,"Average");
}


if(itc>=55&&itc<=59)
{
strcpy(grade_itc,"C");
gpa_itc=1.5;
strcpy(remarks_itc,"Satisfactory");
}


if(itc>=50&&itc<=54)
{
strcpy(grade_itc,"D");
gpa_itc=1.0;
strcpy(remarks_itc,"Pass");
}


if(itc<=49)
{
strcpy(grade_itc,"F");
gpa_itc=0.0;
strcpy(remarks_itc,"Fail");
}
printf("\n Please Enter Your Marks in Calculus : ");
scanf("%d",&calculus);




                                 




                                  /* If Condition - Calculus Marks - for GPA and Grade and Remarks */


if(calculus>=85)
{
strcpy(grade_calculus,"A+");
gpa_calculus=4.0;
strcpy(grade_calculus,"Exceptional");
}




if(calculus>=80&&calculus<=84)
{
strcpy(grade_calculus,"A");
gpa_calculus=3.7;
strcpy(remarks_calculus,"Outstanding");
}




if(calculus>=75&&calculus<=79)
{
strcpy(grade_calculus,"B+");
gpa_calculus=3.4;
strcpy(remarks_calculus,"Excellent");
}




if(calculus>=70&&calculus<=74)
{
strcpy(grade_calculus,"B");;
gpa_calculus=3.0;
strcpy(remarks_calculus,"Very Good");
}




if(calculus>=65&&calculus<=69)
{
strcpy(grade_calculus,"B--");
gpa_calculus=2.5;
strcpy(remarks_calculus,"Good");
}


if(calculus>=60&&calculus<=64)
{
strcpy(grade_calculus,"C+");
gpa_calculus=2.0;
strcpy(remarks_calculus,"Average");
}


if(calculus>=55&&calculus<=59)
{
strcpy(grade_calculus,"C");
gpa_calculus=1.5;
strcpy(remarks_calculus,"Satisfactory");
}


if(calculus>=50&&calculus<=54)
{
strcpy(grade_calculus,"D");
gpa_calculus=1.0;
strcpy(remarks_calculus,"Pass");
}


if(calculus<=49)
{
strcpy(grade_calculus,"F");
gpa_calculus=0.0;
strcpy(remarks_calculus,"Fail");
}




printf("\n Please Enter Your Marks in English : ");
scanf("%d",&english);


                                /* If Condition - English Marks - for GPA and Grade and Remarks */


if(english>=85)
{
strcpy(grade_english,"A+");
gpa_english=4.0;
strcpy(grade_english,"Exceptional");
}




if(english>=80&&english<=84)
{
strcpy(grade_english,"A");
gpa_english=3.7;
strcpy(remarks_english,"Outstanding");
}




if(english>=75&&english<=79)
{
strcpy(grade_english,"B+");
gpa_english=3.4;
strcpy(remarks_english,"Excellent");
}




if(english>=70&&english<=74)
{
strcpy(grade_english,"B");;
gpa_english=3.0;
strcpy(remarks_english,"Very Good");
}




if(english>=65&&english<=69)
{
strcpy(grade_english,"B--");
gpa_english=2.5;
strcpy(remarks_english,"Good");
}


if(english>=60&&english<=64)
{
strcpy(grade_english,"C+");
gpa_english=2.0;
strcpy(remarks_english,"Average");
}


if(english>=55&&english<=59)
{
strcpy(grade_english,"C");
gpa_english=1.5;
strcpy(remarks_english,"Satisfactory");
}


if(english>=50&&english<=54)
{
strcpy(grade_english,"D");
gpa_english=1.0;
strcpy(remarks_english,"Pass");
}


if(english<=49)
{
strcpy(grade_english,"F");
gpa_english=0.0;
strcpy(remarks_english,"Fail");
 }






                                 




                                                /* Finalizing the Conditions */


sum=english+electronics+programming+itc+calculus;
percentage=(sum*100)/500;


gets(name);
printf("\n Roll Number : %d ",roll);


printf("\n English      %d      %f    %s    %s ",english,gpa_english,remarks_english,grade_english);
printf("\n Electronics  %d      %f    %s    %s ",electronics,gpa_electronics,remarks_electronics,grade_electronics);
printf("\n Programming  %d      %f    %s    %s ",programming,gpa_programming,remarks_programming,grade_programming);
printf("\n ITC  %d      %f    %s    %s ",itc,gpa_itc,remarks_itc,grade_itc);
printf("\n Calculus      %d      %f    %s    %s ",calculus,gpa_calculus,remarks_calculus,grade_calculus);


printf("\n \n \t The Total Marks You got are %d and your Percentage is %f",sum,percentage);
getch();


}

---

NO ERROR
but prints all after asking name

automatically !

Raja I told you to read the whole posts! If you to post number 4, you see that I said to use
%s for strings in scanf !

Glad you have no errors :)

In the size for the remarks arrays, change them to 15, instead of 10. Ten is too small.