Having a hard time shifting elements

Hello,

I am trying my best to shift to the next elment in my array. But its not working. The first element shifts just fine, but after that, the value from the first moves to the next.The objective of the program is to prompt the user for a string(which UserString02) is, then take that input and compare it to the alphabet of characters and move it n spaces from the character. For example, if someone enters in ABC and also enters in 3, A will be moved to D, B will be moved to E and C will be moved to F. Here is the code I have

Code:

---

for(int i=n-1; i>0;i--) //n is the length of the string
 
  {
  for(int j=0;j<LIMIT;j++) //Limit is the number of characters in the alphabet.
  {
   
    if(UserString2[i]==Alphabet[j])
    {
   
     
      UserString2[i] =Alphabet[k];//k is the amount of spaces the user wants the character to be moved to to be switched to another character.
      UserString2[i]=UserString[i-1];
   
    }
  }
 }

---

any help will be greatly appreciated. thanks

Code:

---

UserString2[i] =Alphabet[k];  // adjust this to j+k so u it works even if the letter isn't A
 UserString2[i]=UserString[i-1]; // not sure what u are doing here but it saves over what you just did

---

If it as I understand is Caesar cipher and letters in Alphabet are in alphabet order, then:

Code:

---

for(int i=0; i<n;i++) //n is the length of the string
 
  {
  for(int j=0;j<LIMIT;j++) //Limit is the number of characters in the alphabet.
  {
   
    if(UserString2[i]==Alphabet[j])
    {
   
     
      UserString2[i] =Alphabet[(j+k) % LIMIT];//k is the amount of spaces the user wants the character to be moved to to be switched to another character.
   
    }
  }
 }

---

Quote:

---

Originally Posted by Shurik

If it as I understand is Caesar cipher and letters in Alphabet are in alphabet order, then:

Code:

---

for(int i=0; i<n;i++) //n is the length of the string
 
  {
  for(int j=0;j<LIMIT;j++) //Limit is the number of characters in the alphabet.
  {
   
    if(UserString2[i]==Alphabet[j])
    {
   
     
      UserString2[i] =Alphabet[(j+k) % LIMIT];//k is the amount of spaces the user wants the character to be moved to to be switched to another character.
   
    }
  }
 }

---

---

I don't understand the second nested loop here. The shift is done in one addition or subtraction, for each letter.

Code:

---

      //encrypt cipher n is the secret shift number (sssh!) ;)
      n= 5;
 
      for(i=0;i<len;i++) {        //len=strlen(cipher)
        if(isalpha(cipher[i])) {
            if(cipher[i]+n <= 'z')
              cipher[i]=cipher[i]+n;
            else
              cipher[i]=cipher[i]+n-26;
           
        }else
            cipher[i]=clear[i];      //don't change non alpha char's
      }
  }
  printf("\n\nclear: %s\n\ncipher: %s\n",clear,cipher);

---

Quote:

---

Originally Posted by Adak

Code:

---

      //encrypt cipher n is the secret shift number (sssh!) ;)
      n= 5;
 
      for(i=0;i<len;i++) {        //len=strlen(cipher)
        if(isalpha(cipher[i])) {
            if(cipher[i]+n <= 'z')
              cipher[i]=cipher[i]+n;
            else
              cipher[i]=cipher[i]+n-26;
           
        }else
            cipher[i]=clear[i];      //don't change non alpha char's
      }
  }
  printf("\n\nclear: %s\n\ncipher: %s\n",clear,cipher);

---

---

For ASCII only?

Quote:

---

Originally Posted by Adak

I don't understand the second nested loop here. The shift is done in one addition or subtraction, for each letter.

---

OK. Super-puper fast version:

Code:

---

for(int i=0; i < n;i++) //n is the length of the string
  for(int j=0; j < LIMIT;j++) //Limit is the number of characters in the alphabet.
    if(UserString2[i] == Alphabet[j])
    {
      UserString2[i] = Alphabet[(j+k) % LIMIT];//k is the amount of spaces the user wants the character to be moved to to be switched to another character.
      break;
    }

---

Quote:

---

Originally Posted by Shurik

For ASCII only?

---

I was thinking of a Caesar shift of a plain text message. Like a Cryptogram in the paper. In that case, there's no need to encipher a period or a space or an apostrophe.

If you want a full enciphering of all the char's, it's the same idea.

There's still no need to use a double nested for loop. Each char has a value, and each char will then be added by the value of N, (the shift) one time.

If that addition goes beyond the range of your alphabet, you need to "wrap" the char value, back around, by subtracting 26 (or whatever your alphabetic range is (ascii would be 128), so 'z' + a shift of +1 equals 'a', with the alphabet, or 'z' + 1 equals '[' with full 128 ascii values.

OK, I understand.
But what about non-contiguous alphabets like EBCDIC - Wikipedia, the free encyclopedia ?

Quote:

---

Originally Posted by Shurik

But what about non-contiguous alphabets like EBCDIC

---

Then obviously another approach should be used, e.g., using an array to store the alphabet in alphabetical order.