Counting vowels

1. [Prompt the user to enter a sentence, then hit newline. Read the sentence one character at a time,
2. until you come to the newline character. Count the total number of keystrokes entered, the number of
3. alphabetic characters, and the number of vowels ('a', 'e', 'i', 'o', and 'u'). Output these three
4. counts]
   
   End Result should look like this :
   Keystrokes: 9999
   Alpha Characters: 9999
   Vowels: 9999
   
   Only problem is when I insert a sentence... the CMD prompt does not continue... Any Help appreciated Please

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>


int main(int argc, char *argv[])
{
 
  int loop = 0; //Variable used for counting in the loop.
  int keystrokes = 0; //Counts number of keystrokes.
  int letters = 0; //Counts number of total letters.
  int vowels = 0;//Counts number of vowels.
  char sentence[9999]; //Defines the character array that will hold the input sentence. and fills it with the user's input.
 
  printf("Sentence Analyzer.\n");
  printf("Input your sentence(s), then hit enter.\n");
  scanf(" %c", &sentence);
 
  for(loop = 0; sentence[loop] != '\n'; loop++)
  {
          if (sentence[loop] = 'a'||'e'||'i'||'u')
          {
                              ++keystrokes;
                              ++letters;
                              ++vowels;
                              }
                              else
                              {
                                  if (isalpha(sentence[loop]) == 1)
                                  {
                                                              ++keystrokes;
                                                              ++letters;
                                                              }
                                                              else
                                                              {
                                                                  ++keystrokes;
                                                                  }
                                                                  }
                                                                  }
                                                                 
 
  printf("keystrokes%c\n  ", keystrokes);
  printf("Alpha Characters %c\n", letters);
  printf("Vowels %c", vowels);
 
 
  return 0;
}

---

Code:

---

scanf(" %c", &sentence);

---

If you're trying to read a string, you should use "%s" here, and eliminate the '&' before "sentence" (as "sentence" alone will act like a pointer to the first element of that array).

Be warned, however, that "scanf()" will stop reading when it hits whitespace (such as a space or a tab), so entering a sentence will be difficult. (There are ways around it, but let's not worry about that now.)

Perhaps you were intending to enter one one character at a time using "%c"? In that case, you'd need the "scanf()" in a loop, and to include the (incrementing) index number in the second argument (i.e. "&sentence[i]").

Code:

---

if (sentence[loop] = 'a'||'e'||'i'||'u')

---

This is incorrect syntax.

First of all, you want the comparison operator ( == ), not the assignment operator ( = ).

Secondly, you need to explicitly compare the input with each possible character, i.e.

Code:

---

if(sentence[loop] == 'a' || sentence[loop] == 'e' || ... )

---

You also want to use "%d" to print out an integer. %c will print out a character.

Code:

---

  printf("keystrokes%c\n  ", keystrokes);
  printf("Alpha Characters %c\n", letters);
  printf("Vowels %c", vowels);

---

There might be more, but let's start with that.

Still is not fully functioning in CMD.

Code:

---

include <stdio.h>
#include <stdlib.h>
#include <ctype.h>


int main(int argc, char *argv[])
{
 
  int loop = 0; //Variable used for counting in the loop.
  int keystrokes = 0; //Counts number of keystrokes.
  int letters = 0; //Counts number of total letters.
  int vowels = 0;//Counts number of vowels.
  char sentence[9999]; //Defines the character array that will hold the input sentence. and fills it with the user's input.
 
  printf("Sentence Analyzer.\n");
  printf("Input your sentence(s), then hit enter.\n");
  scanf(" %s", sentence);
 
  for(loop = 0; sentence[loop] != '\n'; loop++)
  {
          if(sentence[loop] == 'a' || sentence[loop] == 'e' || sentence[loop] == 'i' || sentence[loop] == 'o' ||sentence[loop] == 'u')
          {
                              ++keystrokes;
                              ++letters;
                              ++vowels;
                              }
                              else
                              {
                                  if (isalpha(sentence[loop]) == 1)
                                  {
                                                              ++keystrokes;
                                                              ++letters;
                                                              }
                                                              else
                                                              {
                                                                  ++keystrokes;
                                                                  }
                                                                  }
                                                                  }
                                                                 
 
  printf("keystrokes %d\n  ", keystrokes);
  printf("Alpha Characters %d\n", letters);
  printf("Vowels %d", vowels);
 
 
  return 0;
}

---

ok, that makes sense...

Hmm, it seems I didn't take all of your specs into account - my apologies. You want the newline there, but using "scanf()" to take a string will remove the newline.

Rather than use "scanf()" to read each character from the input, you might want to try "getchar()" in a "while()" loop.

Code:

---

int i = 0;

while((sentence[i] = getchar()) != '\n')
    i++

---

Bingo! That did the trick... I wanted to use getchar() , but was unfamiliar with it.
Heres the final product:

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>


int main(int argc, char *argv[])
{
 
  int loop = 0; //Variable used for counting in the loop.
  int keystrokes = 0; //Counts number of keystrokes.
  int letters = 0; //Counts number of total letters.
  int vowels = 0;//Counts number of vowels.
  int i = 0;
  char sentence[9999]; //Defines the character array that will hold the input sentence. and fills it with the user's input.
 
  printf("Sentence Analyzer.\n");
  printf("Input your sentence(s), then hit enter.\n");
  scanf(" %s", sentence);


  while((sentence[i] = getchar()) != '\n')
    i++;
        {
          if(sentence[i] == 'a' || sentence[i] == 'e' || sentence[i] == 'i' || sentence[i] == 'o' ||sentence[i] == 'u')
          {
                              ++keystrokes;
                              ++letters;
                              ++vowels;
                              }
                              else
                              {
                                  if (isalpha(sentence[i]) == 1)
                                  {
                                                              ++keystrokes;
                                                              ++letters;
                                                              }
                                                              else
                                                              {
                                                                  ++keystrokes;
                                                                  }
                                                                  }
                                                                  }


                                                                 
 
  printf("Keystrokes %d \n", keystrokes);
  printf("Alpha Characters %d \n", letters);
  printf("Vowels %d \n", vowels);
 
 
  return 0;
}

---

You can get rid of this line now:

Code:

---

scanf(" %s", sentence);

---

Have you tested it? The results are dreadfully wrong. There are dangers to simply copy+pasting code and not understanding. The code I provided was intended to illustrate a concept, not to be shoved into the program without thought.

Think of what's happening:

Code:

---

  while((sentence[i] = getchar()) != '\n')  // "while" loop
    i++;                                      // body of "while" loop
    {                                          // by the time the program gets here, the while loop is already over and this part just gets executed once
          if(sentence[i] == 'a' || sentence[i] == 'e' || sentence[i] == 'i' || sentence[i] == 'o' ||sentence[i] == 'u')
          {
                // ...

---

If i get rid of the Scanf... I wouldnt be able to input anything unless i place a scanf() somewhere else.

One more thing I held off mentioning until now ... work on your indentation. The code you posted is difficult to skim over.

Here is the last code you posted (errors still intact) with proper indentation.

See how much easier it is to follow?

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>
 
int main(int argc, char *argv[])
{
    int loop = 0; //Variable used for counting in the loop.
    int keystrokes = 0; //Counts number of keystrokes.
    int letters = 0; //Counts number of total letters.
    int vowels = 0;//Counts number of vowels.
    int i = 0;
    char sentence[9999]; //Defines the character array that will hold the input sentence. and fills it with the user's input.

    printf("Sentence Analyzer.\n");
    printf("Input your sentence(s), then hit enter.\n");
    scanf(" %s", sentence);
 
 
    while((sentence[i] = getchar()) != '\n')
        i++;

    {
        if(sentence[i] == 'a' || sentence[i] == 'e' || sentence[i] == 'i' || sentence[i] == 'o' ||sentence[i] == 'u')
        {
            ++keystrokes;
            ++letters;
            ++vowels;
        }
        else
        {
            if (isalpha(sentence[i]) == 1)
            {
                ++keystrokes;
                ++letters;
            }
            else
            {
                ++keystrokes;
            }
        }
    }

    printf("Keystrokes %d \n", keystrokes);
    printf("Alpha Characters %d \n", letters);
    printf("Vowels %d \n", vowels);

    return 0;
}

---

Quote:

---

Originally Posted by rmrjr22

If i get rid of the Scanf... I wouldnt be able to input anything unless i place a scanf() somewhere else.

---

Not true. Characters are being inputted with:

Code:

---

while((sentence[i] = getchar()) != '\n')

---

Yeah, sorry about the mess... just trying to fit it all together before I make it neat.
yes, i tried it w/o the scanf() and it reads properly...
now im trying to input another sample sentence after the first.... but the "Press any key to continue..." comes up...
I tried...
system("pause")
printf("Sample sentence #2");

return = 0;
{

If you added code, please post an update!

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>


int main(int argc, char *argv[])
{
 
  int keystrokes = 0;                        //Number of keystrokes.
  int letters = 0;                                        //Number of total letters.
  int vowels = 0;                                //Number of vowels.
  int i = 0;
  char sentence[9999];                                        //Chararacter array specified to ussers input.
 
 
 
  //scanf("%s", sentence);


  while((sentence[i] = getchar()) != '\n')
    i++;
  {
          if(sentence[i] == 'a' || sentence[i] == 'e' || sentence[i] == 'i' || sentence[i] == 'o' ||sentence[i] == 'u')
          {
                  ++keystrokes;
                  ++letters;
                  ++vowels;
          }
          else
          {
                  if (isalpha(sentence[i]) == 1)
                  {
                          ++keystrokes;
                          ++letters;
                  }
                  else
                  {
                          ++keystrokes;
                  }
          }
  }
                                                                 
  printf("SAMPLE OUTPUT, for EACH sentence above:\n");
  printf(" Program#5 CS110.\n");
  printf("Keystrokes %d \n", keystrokes);
  printf("Alpha Characters %d \n", letters);
  printf("Vowels %d \n", vowels);


  system("pause");


  printf("Sample #2");
  // had the while loop here, but it didnt do much
 
  return 0;
}

---

I also input a sentence but do not receive a proper output:
This is a Sentence.
SAMPLE OUTPUT, for EACH sentence above:
Program#5 CS110.
Keystrokes 1
Alpha Characters 0
Vowels 0
Press any key to continue . . .

What's going on here?

Code:

---

  while((sentence[i] = getchar()) != '\n')
    i++;
  {
      if(sentence[i] == 'a' || sentence[i] == 'e' || sentence[i] == 'i' || sentence[i] == 'o' ||sentence[i] == 'u')
      {
          ++keystrokes;
          ++letters;
          ++vowels;
      }
      else
      {
          if (isalpha(sentence[i]) == 1)
          {
              ++keystrokes;
              ++letters;
          }
          else
          {
              ++keystrokes;
          }
      }
  }

---

Thats the body of the while loop, no?
Ah, nvr mind. Moved ++i; to end of loop.
reads vowels now...
but i still am unsure on how to input more than once sentence

This is what you wanted.

Code:

---

    while((sentence[i] = getchar()) != '\n')
    {
        if(sentence[i] == 'a' || sentence[i] == 'e' || sentence[i] == 'i' || sentence[i] == 'o' ||sentence[i] == 'u')
        {
            ++keystrokes;
            ++letters;
            ++vowels;
        }
        else
        {
            if (isalpha(sentence[i]) == 1)
            {
                ++keystrokes;
                ++letters;
            }
            else
            {
                ++keystrokes;
            }
        }


        i++;
    }

---

Quote:

---

Originally Posted by Click_here

What's going on here?

---

I addressed that in post #7. Apparently we've gotten nowhere with that.

Or better yet...

Code:

---

    for(i=0; ((sentence[i] = getchar()) != '\n'); i++)
    {
        if(sentence[i] == 'a' || sentence[i] == 'e' || sentence[i] == 'i' || sentence[i] == 'o' ||sentence[i] == 'u')
        {
            ++keystrokes;
            ++letters;
            ++vowels;
        }
        else
        {
            if (isalpha(sentence[i]) == 1)
            {
                ++keystrokes;
                ++letters;
            }
            else
            {
                ++keystrokes;
            }
        }
    }

---

Or even better :P

Code:

---

    for(i=0; ((sentence[i] = getchar()) != '\n'); i++)
    {
        ++keystrokes;
       
        if (isalpha(sentence[i]) == 1)
        {
            ++letters;
           
            if(sentence[i] == 'a' || sentence[i] == 'e' || sentence[i] == 'i' || sentence[i] == 'o' ||sentence[i] == 'u')
            { 
                ++vowels;
            }
        }
    }

---

So far this works great... minus being unable to input more than one sentence when the program runs

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>


int main(int argc, char *argv[])
{
  int keystrokes = 0;                        //Number of keystrokes.
  int letters = 0;                                        //Number of total letters.
  int vowels = 0;                                //Number of vowels.
  int i = 0;
  char sentence[9999];                                        //Chararacter array specified to users input.


 while((sentence[i] = getchar()) != '\n')
           
  {
          if(sentence[i] == 'a' || sentence[i] == 'e' || sentence[i] == 'i' || sentence[i] == 'o' ||sentence[i] == 'u') //stating vowels
          {
                  ++keystrokes;
                  ++letters;
                  ++vowels;
          }
          else
          {
                  if (isalpha(sentence[i]) == 1) // if character is true
                  {
                          ++keystrokes;
                          ++letters;
                  }
                  else
                  {
                          ++keystrokes;
                          i++;
                  }
          }
  }


 
                                                                 
  printf("SAMPLE OUTPUT, for EACH sentence above:\n");
  printf(" Program#5 CS110.\n");
  printf("Keystrokes %d \n", keystrokes);
  printf("Alpha Characters %d \n", letters);
  printf("Vowels %d \n", vowels);


 
 
  return 0;
}

---

Code:

---

Hello friend

SAMPLE OUTPUT, for EACH sentence above:
 Program#5 CS110.

Keystrokes 12
Alpha Characters 5
Vowels 4

---

Works great, eh?

@Click_Here: Be careful of the return value of "isalpha()" - it might be better to just make sure it's true (or not zero), instead of equal to one.

Quote:

---

Return value: A value different from zero (i.e., true) if indeed c is an alphabetic letter. Zero (i.e., false) otherwise.

---

Quote:

---

Originally Posted by Matticus

@Click_Here: Be careful of the return value of "isalpha()" - it might be better to just make sure it's true (or not zero), instead of equal to one.

---

I did rush it :P

Yes, that would be much better.

Looking at my sketch file where I copy/paste and run code for here, I seem to have done it before closing the file (?!) - I didn't repost the code though -> I remember now: I didn't think that it was worth reposting.

Quote:

---

Originally Posted by rmrjr22

"So far this works great... minus being unable to input more than one sentence when the program runs"

---

Your code is not working, because you are incrementing 'i' only if it's not a vowel and is not alpha. What is more annoying is that in a rare laps of judgement, I showed you where to do it in post 17 :(