Slight Confusion

So first off, i'm new to this. Very Very new.

I'm currently writing a text based game in Ansi C (some of you may of noticed a few of us doing this and asking around here for guidance).

Code:

---

#include <stdio.h>
#include <stdlib.h>

#define North=0
#define East=1
#define South=2
#define West=3
typedef struct{
  char RoomName[30];
  char Description[500];
  unsigned int Exit[4];
}Location;
Location Room[7];
void SetupRooms()
{
strcpy(Room[1].RoomName, "AirLock");
strcpy(Room[1].Description,"As you enter the facility you find your comms channels have scrambled. \nYou appear to be in some kind of air lock. \nIn front of you the light turns green and you can hear bolts shifting.");
Room[1].Exit[North]=2;
Room[1].Exit[East]=0;
Room[1].Exit[South]=50;
Room[1].Exit[West]=0;
strcpy(Room[2].RoomName, "Main Canteen");
strcpy(Room[2].Description,"\"Arrrgghhhhhhh\" A muffled scream dies out somewhere up ahead as you \nstep into a wide berthed room full of regimented tables and chairs, \nto the left is a food station. Looks like your in the canteen.");
Room[2].Exit[North]=3;
Room[2].Exit[East]=4;
Room[2].Exit[South]=1;
Room[2].Exit[West]=5;
strcpy(Room[3].RoomName, "Stasis Chamber");
strcpy(Room[3].Description,"After a brief scan from the remaining functional automatic \nsystems you enter a completely white room with a large bank of computer systems next to a row of malfunctioning cryogenic bays. \nBehind you comes those sounds from earlier, very very close. Its found you.\n No time for lockdown, There is only one other door aside from where you came in. To the escape pods!");
Room[3].Exit[North]=0;
Room[3].Exit[East]=0;
Room[3].Exit[South]=0;
Room[3].Exit[West]=7;
strcpy(Room[4].RoomName, "Decontamination Chamber");
strcpy(Room[4].Description,"Tentatively you follow the big warning signs and step into a room with plastic shawls on each side with shower heads poking through. Its impossible to tell how big the room actually is beyond this and shadows dance menacingly behind every surface.");
Room[4].Exit[North]=0;
Room[4].Exit[East]=0;
Room[4].Exit[South]=0;
Room[4].Exit[West]=2;
strcpy(Room[5].RoomName, "Containment Facility");
strcpy(Room[5].Description,"The doors are heavy, but warped and twisted. You crouch and make your way through a gap whilst trying not to question the damp surface. Once in you can see that the containment room itself is severly damaged, chemical burns splatter the walls and a metallic odour flips your stomach. Suddenly a wet \"Thud\" and snarl sounds from the corridor in front of you leading to the cages. Everything in your body wants to turn back.");
Room[5].Exit[North]=0;
Room[5].Exit[East]=2;
Room[5].Exit[South]=0;
Room[5].Exit[West]=6;
strcpy(Room[6].RoomName, "Cages");
strcpy(Room[6].Description,"Against everything, you carry on towards the sound. This is the place where they must have been keeping whatever it is. What you've been sent to secure. The air is heavy here and there are definite sounds of life from the end cage. Whatever it is, its in there. Now you must isolate the facility from the central control unit in the crews stasis chamber and leave as quickly as you can.");
Room[6].Exit[North]=0;
Room[6].Exit[East]=5;
Room[6].Exit[South]=0;
Room[6].Exit[West]=0;
strcpy(Room[7].RoomName, "Escape Pods");
strcpy(Room[7].Description,"Houses the household computer and bookshelves filled to the brim. Rob is in the corner fapping. Its too late, the creature has found you...its Paedobear. The next scene has been censored.");
Room[7].Exit[North]=50;
Room[7].Exit[East]=0;
Room[7].Exit[South]=0;
Room[7].Exit[West]=0;
}
void DescribeRoom(unsigned int i)
{
 printf("You are sent to a home facility for testing of new biological sciences after it stopped responding to communications. \nYou are to secure that the stored subjects are still within the facility and initilise lockdown.\n \n");
 printf("%15d- Maps indicate that your are in the ");
 printf(Room[i].RoomName);
 printf(" -0\n\n\n\n");
 printf(Room[i].Description);
 printf("\n\n");
}
void DescribeExits(unsigned int i)
{
 printf("There are doors to your;\n");
 if(Room[i].Exit[North]!=0) printf("North\n");
 if(Room[i].Exit[East]!=0) printf("East\n");
 if(Room[i].Exit[South]!=0) printf("South\n");
 if(Room[i].Exit[West]!=0) printf("West\n");
 printf("\nInput the first letter of your desired direction to move. \nPress q to quit the system.\n");
}
int GetDirection(unsigned int i)
{
 char test;
 unsigned int NewDirection=0;
 while(1)
 {
  test=getch();
  if(test=='n') NewDirection=Room[i].Exit[North];
  if(test=='e') NewDirection=Room[i].Exit[East];
  if(test=='s') NewDirection=Room[i].Exit[South];
  if(test=='w') NewDirection=Room[i].Exit[West];
  if(test=='q') NewDirection=50;
 
  if(NewDirection!=0) return(NewDirection);
  printf("Theres no way you can go there.\n");
 }
}
 
void main()
{
 unsigned int RoomNumber = 1;
 unsigned int Direction;
 SetupRooms();
  while(1)
  {
  system("cls");
  DescribeRoom(RoomNumber);
  DescribeExits(RoomNumber);
  Direction = GetDirection(RoomNumber);
  if(Direction==50)exit(0);
  if(Direction>0)RoomNumber= Direction;
  }
}
void print_house(unsigned int RoomNumber, unsigned int Direction){ // set up Room numbers and Directions
 char Room_x[RoomNumbers];
 unsigned int i;
 for ( i=0; i<RoomNumbers; ++i )
  Room_x[i] = ' ';
 Room_x[RoomNumber] = 'X';
 printf("___________________________________________________________\n");
 printf("|                    _____________________                |\n");
 printf("|                    |                  |                |\n");
 printf("|        __________  |                  |                |\n");
 printf("|      /          | |                  |                |\n");
 printf("|      /          |_|    Stasis        |                |\n");
 printf("|    / Escape            Chamber      |                |\n", Room_x[7]);
 printf("|    \  Pod  %c    _                    |                |\n");
 printf("|      \          | |        %c        |                |\n", Room_x[3]);
 printf("|      \__________| |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |________  ________|                |\n");
 printf("|                    _______|  |________                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|________  ___________|                  | _______________|\n");
 printf("|        ||          |                  ||              |\n");
 printf("|  Cages ||Containment|                  ||Decontamination|\n");
 printf("|  %c      Facility                          Chamber    |\n", Room_x[6]);
 printf("|              %c                                        |\n", Room_x[5]);
 printf("|        ||          |    Canteen      ||      %c      |\n", Room_x[4]);
 printf("|________||___________|                  ||_______________|\n");
 printf("|                    |        %c        |                |\n", Room_x[2]);
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |_____    ________|                |\n");
 printf("|                        |        |                      |\n");
 printf("|________________________| Airlock |______________________|\n");
 printf("                        |  %c    |                      \n", Room_x[1]);
 printf("                        |___  ___|                      \n");
}

---

I understand my program may be very confused and inefficient, but for now the main issue i am trying to tacke is the text map seen near the bottom. At the moment i have the errors:

Undefined Symbol RoomNumbers in function 'print_house'.
And
Non Scalar or negative array index in function 'print_house'

both on line 111.

I understand that i've not properly defined RoomNumbers, but everytime i put a char in for it i get 'internal error'

Any advice would be greatly appreciated. On the problem at hand first, and then i can start to worry about other things.

Thanks

Your compiler must have given you a lot more diagnostics

Code:

---

#define North=0
#define East=1
#define South=2
#define West=3

---

will not work
use

Code:

---

#define North 0
#define East 1
#define South 2
#define West 3

---

As you'r e using globals anyway you could just as well write

Code:

---

#define RoomNumbers 7
typedef struct{
  char RoomName[30];
  char Description[500];
  unsigned int Exit[4];
}Location;
Location Room[RoomNumbers];

---

haven't looked for any other errors.
Kurt

Ok. The undefined symbol error is obvious (I hope).

This one:

Quote:

---

Non Scalar or negative array index in function 'print_house'

---

Are you trying to create an array of RoomNumbers chars? And RoomNumbers is what.. a variable?

You're not allowed to use variables to declare the size of an array in C90. In C99 you can, and I believe gcc supports variable length arrays too.

Code:

---

#define LEN 10


char arr1[10];  //ok
char arr2[LEN]; //ok
int foo = 10;
char arr3[foo]; // Illegal, compiler error.

---

I'm not sure I got what you meant by "put a char in it" -- can you post what you've tried if you're still stuck?

Now I understand this Room_x thingy. You want to print it in the diagram.
you propably want

Code:

---

for ( i=0; i<RoomNumbers; ++i )
  Room_x[i] = '0' + i;

---

Kurt - Thankyou for your help, however those sections you pointed out do indeed work as the program functions fine with no errors as it stands aside from these issues with the map. I appreciate help with the messy code elsewhere but first i want to get something with all parts functioning before cleaning it up.

Smokeyangel - The undefined symbol error is obvious, however whenever i attempt to define it i just get 'internal error' from my compiler.

I believe the scalar error may be related to the undefined symbol as it seems i have confused soemthing during this part of the code:

Code:

---

void print_house(unsigned int RoomNumber, unsigned int Direction){ // set up Room numbers and Directions
 char Room_x[RoomNumbers];
 unsigned int i;
 for ( i=0; i<RoomNumbers; ++i )
  Room_x[i] = ' ';
 Room_x[RoomNumber] = 'X';


---

Thankyou for your patience with me whilst i get to grips with this.

Can you show me where and how you're trying to define it?

sorry

Code:

---

#define North=0
Room[1].Exit[North]=2;

---

cannot work
the preprocessor would translate this to

Code:

---

Room[1].Exit[North=0]=2;

---

and then the compiler must complain about a unknown symbol North
Kurt
EDIT: I could imagine that this is the reason for an internal error.

you'll need string.h lib.

Code:

---

        printf("%15d- Maps indicate that your are in the ");

---

you used %d with intention of printing out integer, but there is no second argument.

Code:

---

void print_house(unsigned int RoomNumber, unsigned int Direction){ // set up Room numbers and Directions
 char Room_x[RoomNumbers];

---

Can't have variable name mismatch like that.

Code:

---

Location Room[7];

Room[7].Exit[North]=50;
Room[7].Exit[East]=0;
Room[7].Exit[South]=0;
Room[7].Exit[West]=0;

---

You exceed the length of your array. C's array starts from 0.

Code:

---

printf("|    / Escape            Chamber      |                |\n", Room_x[7]);
 printf("|    \  Pod  %c   _                    |                |\n");

---

"%c" is put in the wrong printf. Make sure "%c" apperas in the same printf as your variable.

Kurt - It seems to function with no complaints without the map section even with the code how it stands, however i have now updated it to:

Code:

---


#define North 0
#define East 1
#define South 2
#define West 3

---

Smokeyangel - I have tried to define it with:

Code:

---


void print_house(unsigned int RoomNumber, unsigned int Direction, unsigned int RoomNumbers){ // set up Room numbers and Directions
 char Room_x[RoomNumbers];
 unsigned int i;
 for ( i=0; i<RoomNumbers; ++i )
  Room_x[i] = ' ';
 Room_x[RoomNumber] = 'X';

---

but i can tell this isnt right.

Maybe it would help if i further explained. What i want it to do. Essentially as the user moves around between these rooms i want the map to update the %c under each room name being X whilst when they are not in the room it should be just a space.

In your diagram at the bottom, you have to replace every \ with \\.
Since \ is special, to get an actual \ to print, you need two.

'print_house' return void; so get rid of that 'return 0' at the end. Main should return an integer, so replace that 'void' in front of main, and put 'return 0' at the end of it.

so you want

Code:

---

for ( i=0; i<RoomNumbers; ++i ) {
    if ( i == RoomNumber)
        Room_x[i] = 'X';
    else
        Room_x[i] = ' ';
}

---

What is 'RoomNumber'? You have 'RoomNumbers, but I don't see 'RoomNumber':

Code:

---

Room_x[RoomNumber] = 'X';

---

If you switch that out to be i, at that point you will be out of range of what your array is allowed to try to access.


Quzah.

Ok so currently i have:

Code:

---

void print_house(unsigned int RoomNumber, unsigned int Direction){ // set up Room numbers and Directions
 char Room_x[RoomNumber];
 unsigned int i;
 for ( i=0; i<RoomNumber; ++i ) {
    if ( i == RoomNumber)
        Room_x[i] = 'X';
    else
        Room_x[i] = ' ';

---

Above my map. Thankyou to oogabooga and nimitz hunter for helping me clean up the map a little - now looks like this:

Code:

---

printf("___________________________________________________________\n");
 printf("|                    _____________________                |\n");
 printf("|                    |                  |                |\n");
 printf("|        __________  |                  |                |\n");
 printf("|      /          | |                  |                |\n");
 printf("|      /          |_|    Stasis        |                |\n");
 printf("|    / Escape            Chamber      |                |\n");
 printf("|    \\  Pod  %c    _                    |                |\n", Room_x[7]);
 printf("|    \\          | |        %c        |                |\n", Room_x[3]);
 printf("|      \\__________| |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |________  ________|                |\n");
 printf("|                    _______|  |________                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|________  ___________|                  | _______________|\n");
 printf("|        ||          |                  ||              |\n");
 printf("|  Cages ||Containment|                  ||Decontamination|\n");
 printf("|  %c      Facility                          Chamber    |\n", Room_x[6]);
 printf("|              %c                                        |\n", Room_x[5]);
 printf("|        ||          |    Canteen      ||      %c      |\n", Room_x[4]);
 printf("|________||___________|                  ||_______________|\n");
 printf("|                    |        %c        |                |\n", Room_x[2]);
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |_____    ________|                |\n");
 printf("|                        |        |                      |\n");
 printf("|________________________| Airlock |______________________|\n");
 printf("                        |  %c    |                      \n", Room_x[1]);
 printf("                        |___  ___|                      \n");
}

---

Quote:

---

Originally Posted by quzah

What is 'RoomNumber'?

---

If the op has followed my advice RoomNumbers should be a #define for 7
But we have to see the updated code.
Kurt

Are you all in the same class?
http://cboard.cprogramming.com/c-pro...g-program.html
http://cboard.cprogramming.com/c-pro...-username.html
http://cboard.cprogramming.com/c-pro...-im-stuck.html

Because every one of you seems to be writing some kind of text adventure, and EVERY one of you has screwed up on thinking arrays start at 1, whereas in fact they start at zero.

Now one making the mistake is the students fault.
But 4 students with the same mistake - now that's down to crummy teaching.

Zuk - would it? I would have thought you'd have to write

Code:

---

#define North North=1

---

to get it to substitute like that.

In any case I'm surprised it didn't give an error straight away.

Quote:

---

Originally Posted by L.Firth

Smokeyangel - I have tried to define it with:

Code:

---


void print_house(unsigned int RoomNumber, unsigned int Direction, unsigned int RoomNumbers){ // set up Room numbers and Directions
 char Room_x[RoomNumbers];

---

---

Ok, right, you can't do that. In C you can only initialise an array with a compiler-time constant: i.e. the compiler has to know what the value of RoomNumbers is, and it can't do that with a variable passed in as a parameter. You can dynamically allocate memory using malloc(), but I don't think there's any need for that here as you do know the required length of the array.

Quote:

---

Originally Posted by L.Firth

Maybe it would help if i further explained. What i want it to do. Essentially as the user moves around between these rooms i want the map to update the %c under each room name being X whilst when they are not in the room it should be just a space.

---

Ok, I understand. But the number of rooms is fixed, there are only 7 of them. So why not just use:

Code:

---

void print_house(unsigned int RoomNumber, unsigned int Direction){ // set up Room numbers and Directions
 char Room_x[7];
 unsigned int i;
 for ( i=0; i<7; ++i )
  Room_x[i] = ' ';
 Room_x[RoomNumber] = 'X';

---

Accessing a particular room number with [RoomNumber] is fine - it's just the declaration you can't do.

Or far nicer (using magic numbers like "7" in code is bad for maintainability, readability, etc), do as Zuk suggested and put

Code:

---

#define RoomNumbers 7

---

At the beginning.

Quote:

---

Originally Posted by Salem

Now one making the mistake is the students fault.
But 4 students with the same mistake - now that's down to crummy teaching.

---

I noticed that too. Bad teacher!!

Quote:

---

Originally Posted by ZuK

If the op has followed my advice RoomNumbers should be a #define for 7

---

Go read my post again. I didn't ask what RoomNumbers was. I asked what RoomNumber was.


Quzah.

Quote:

---

Originally Posted by smokeyangel

Zuk - would it? I would have thought you'd have to write

Code:

---

#define North North=1

---

---

True, I don't know how it would be substituted but it should be an error anyway
Kurt

Salem - Yes we are. But we're gonna try and do what we can. I know we are a pain but we are essentially trying to teach ourselves from the ground up, afterall we are all product designers given a programming project oddly.

Ok, so i've updated the relevant section of code to:

Code:

---


void print_house(unsigned int RoomNumber, unsigned int Direction){ // set up Room numbers and Directions
 char Room_x[RoomNumber];
 unsigned int i;
 for ( i=0; i<RoomNumber; ++i ) {
    if ( i == RoomNumber)
        Room_x[i] = 'X';
    else
        Room_x[i] = ' ';
 }
 printf("___________________________________________________________\n");
 printf("|                    _____________________                |\n");
 printf("|                    |                  |                |\n");
 printf("|        __________  |                  |                |\n");
 printf("|      /          | |                  |                |\n");
 printf("|      /          |_|    Stasis        |                |\n");
 printf("|    / Escape            Chamber      |                |\n");
 printf("|    \\  Pod  %c    _                    |                |\n", Room_x[7]);
 printf("|    \\          | |        %c        |                |\n", Room_x[3]);
 printf("|      \\__________| |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |________  ________|                |\n");
 printf("|                    _______|  |________                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|________  ___________|                  | _______________|\n");
 printf("|        ||          |                  ||              |\n");
 printf("|  Cages ||Containment|                  ||Decontamination|\n");
 printf("|  %c      Facility                          Chamber    |\n", Room_x[6]);
 printf("|              %c                                        |\n", Room_x[5]);
 printf("|        ||          |    Canteen      ||      %c      |\n", Room_x[4]);
 printf("|________||___________|                  ||_______________|\n");
 printf("|                    |        %c        |                |\n", Room_x[2]);
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |_____    ________|                |\n");
 printf("|                        |        |                      |\n");
 printf("|________________________| Airlock |______________________|\n");
 printf("                        |  %c    |                      \n", Room_x[1]);
 printf("                        |___  ___|                      \n");
}

---

But i get an internal error.

I plan to update the #define RoomNumbers 7 part but i'm still a little confused.

Quote:

---

But i get an internal error.

---

This is not specific enough! How about the full text of the error and the line on which it occurs?

Code:

---

char Room_x[RoomNumber];

---

Does the compiler you're using support variable-length arrays?

I will give the whole of what my compiler CC386 IDE is giving me in return when i build:

Compiling CMAP.c
Linking
Compile Done. Errors: 0, Warnings: 0
Internal Error...

And that is all. I can't give you any more detail as i don't have it myself. Sorry.

My code as it stands:

Code:

---

#include <stdio.h>
#include <stdlib.h>

#define North 0
#define East 1
#define South 2
#define West 3
typedef struct{
  char RoomName[30];
  char Description[500];
  unsigned int Exit[4];
}Location;
Location Room[7];
void SetupRooms()
{
strcpy(Room[1].RoomName, "AirLock");
strcpy(Room[1].Description,"As you enter the facility you find your comms channels have scrambled. \nYou appear to be in some kind of air lock. \nIn front of you the light turns green and you can hear bolts shifting.");
Room[1].Exit[North]=2;
Room[1].Exit[East]=0;
Room[1].Exit[South]=50;
Room[1].Exit[West]=0;
strcpy(Room[2].RoomName, "Main Canteen");
strcpy(Room[2].Description,"\"Arrrgghhhhhhh\" A muffled scream dies out somewhere up ahead as you \nstep into a wide berthed room full of regimented tables and chairs, \nto the left is a food station. Looks like your in the canteen.");
Room[2].Exit[North]=3;
Room[2].Exit[East]=4;
Room[2].Exit[South]=1;
Room[2].Exit[West]=5;
strcpy(Room[3].RoomName, "Stasis Chamber");
strcpy(Room[3].Description,"After a brief scan from the remaining functional automatic \nsystems you enter a completely white room with a large bank of computer systems next to a row of malfunctioning cryogenic bays. \nBehind you comes those sounds from earlier, very very close. Its found you.\n No time for lockdown, There is only one other door aside from where you came in. To the escape pods!");
Room[3].Exit[North]=0;
Room[3].Exit[East]=0;
Room[3].Exit[South]=0;
Room[3].Exit[West]=7;
strcpy(Room[4].RoomName, "Decontamination Chamber");
strcpy(Room[4].Description,"Tentatively you follow the big warning signs and step into a room with plastic shawls on each side with shower heads poking through. Its impossible to tell how big the room actually is beyond this and shadows dance menacingly behind every surface.");
Room[4].Exit[North]=0;
Room[4].Exit[East]=0;
Room[4].Exit[South]=0;
Room[4].Exit[West]=2;
strcpy(Room[5].RoomName, "Containment Facility");
strcpy(Room[5].Description,"The doors are heavy, but warped and twisted. You crouch and make your way through a gap whilst trying not to question the damp surface. Once in you can see that the containment room itself is severly damaged, chemical burns splatter the walls and a metallic odour flips your stomach. Suddenly a wet \"Thud\" and snarl sounds from the corridor in front of you leading to the cages. Everything in your body wants to turn back.");
Room[5].Exit[North]=0;
Room[5].Exit[East]=2;
Room[5].Exit[South]=0;
Room[5].Exit[West]=6;
strcpy(Room[6].RoomName, "Cages");
strcpy(Room[6].Description,"Against everything, you carry on towards the sound. This is the place where they must have been keeping whatever it is. What you've been sent to secure. The air is heavy here and there are definite sounds of life from the end cage. Whatever it is, its in there. Now you must isolate the facility from the central control unit in the crews stasis chamber and leave as quickly as you can.");
Room[6].Exit[North]=0;
Room[6].Exit[East]=5;
Room[6].Exit[South]=0;
Room[6].Exit[West]=0;
strcpy(Room[7].RoomName, "Escape Pods");
strcpy(Room[7].Description,"Houses the household computer and bookshelves filled to the brim. Rob is in the corner fapping. Its too late, the creature has found you...its Paedobear. The next scene has been censored.");
Room[7].Exit[North]=50;
Room[7].Exit[East]=0;
Room[7].Exit[South]=0;
Room[7].Exit[West]=0;
}
void DescribeRoom(unsigned int i)
{
 printf("You are sent to a home facility for testing of new biological sciences after it stopped responding to communications. \nYou are to secure that the stored subjects are still within the facility and initilise lockdown.\n \n");
 printf("%15d- Maps indicate that your are in the ");
 printf(Room[i].RoomName);
 printf(" -0\n\n\n\n");
 printf(Room[i].Description);
 printf("\n\n");
}
void DescribeExits(unsigned int i)
{
 printf("There are doors to your;\n");
 if(Room[i].Exit[North]!=0) printf("North\n");
 if(Room[i].Exit[East]!=0) printf("East\n");
 if(Room[i].Exit[South]!=0) printf("South\n");
 if(Room[i].Exit[West]!=0) printf("West\n");
 printf("\nInput the first letter of your desired direction to move. \nPress q to quit the system.\n");
}
int GetDirection(unsigned int i)
{
 char test;
 unsigned int NewDirection=0;
 while(1)
 {
  test=getch();
  if(test=='n') NewDirection=Room[i].Exit[North];
  if(test=='e') NewDirection=Room[i].Exit[East];
  if(test=='s') NewDirection=Room[i].Exit[South];
  if(test=='w') NewDirection=Room[i].Exit[West];
  if(test=='q') NewDirection=50;
 
  if(NewDirection!=0) return(NewDirection);
  printf("Theres no way you can go there.\n");
 }
}
 
void main()
{
 unsigned int RoomNumber = 1;
 unsigned int Direction;
 SetupRooms();
  while(1)
  {
  system("cls");
  DescribeRoom(RoomNumber);
  DescribeExits(RoomNumber);
  Direction = GetDirection(RoomNumber);
  if(Direction==50)exit(0);
  if(Direction>0)RoomNumber= Direction;
  }
}
void print_house(unsigned int RoomNumber, unsigned int Direction){ // set up Room numbers and Directions
#define RoomNumbers 7
 char Room_x[RoomNumbers];
 unsigned int i;
 for ( i=0; i<RoomNumbers; ++i ) {
    if ( i == RoomNumber)
        Room_x[i] = 'X';
    else
        Room_x[i] = ' ';
}
 printf("___________________________________________________________\n");
 printf("|                    _____________________                |\n");
 printf("|                    |                  |                |\n");
 printf("|        __________  |                  |                |\n");
 printf("|      /          | |                  |                |\n");
 printf("|      /          |_|    Stasis        |                |\n");
 printf("|    / Escape            Chamber      |                |\n");
 printf("|    \\  Pod  %c    _                    |                |\n", Room_x[7]);
 printf("|    \\          | |        %c        |                |\n", Room_x[3]);
 printf("|      \\__________| |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |________  ________|                |\n");
 printf("|                    _______|  |________                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|________  ___________|                  | _______________|\n");
 printf("|        ||          |                  ||              |\n");
 printf("|  Cages ||Containment|                  ||Decontamination|\n");
 printf("|  %c      Facility                          Chamber    |\n", Room_x[6]);
 printf("|              %c                                        |\n", Room_x[5]);
 printf("|        ||          |    Canteen      ||      %c      |\n", Room_x[4]);
 printf("|________||___________|                  ||_______________|\n");
 printf("|                    |        %c        |                |\n", Room_x[2]);
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |_____    ________|                |\n");
 printf("|                        |        |                      |\n");
 printf("|________________________| Airlock |______________________|\n");
 printf("                        |  %c    |                      \n", Room_x[1]);
 printf("                        |___  ___|                      \n");
}

---

Yeah, you're still not allowed to do that in C.

RoomNumber is the number of the room you want to print 'X' in, right?
And RoomNumbers is the total number of rooms.

So now, if it was legal syntax, you'd create an array with only "RoomNumber" entries, which probably isn't what you want. You want to:
Create an array with 1 char for each room
Loop through every character
If the room number matches the one given, put 'X' in the array
otherwise put ' ' in the array

This line

Code:

---

char Room_x[NUM];

---

creates the array. NUM needs to be a constant -- either #defined, or just a number, or a const. You can't put a function parameter in here.

This'd be easier if the compiler would give you a proper error message!

Disregard my last post, you posted before me

Quote:

---

Originally Posted by L.Firth

I will give the whole of what my compiler CC386 IDE is giving me in return when i build:

Compiling CMAP.c
Linking
Compile Done. Errors: 0, Warnings: 0
Internal Error...

And that is all. I can't give you any more detail as i don't have it myself. Sorry.

---

Wow. Helpful toolchain award goes to.....CC386

So it says "Compile Done" before "Internal Error". Did it manage to finish linking? Was an executable file produced?

Is it possible the IDE started running/debugging the program? You've still got out-of-bounds array accesses which could cause dodgy behaviour.

I checked your code on MSVC - it compiles fine now.

I do not believe the file was produced, when i try to run it simply runs what looks like the last working .exe file it produced was (before the map sections were added). I tried deleting the existing .exe and then tried again. This time it produced a new .exe but still, nothing to do with the map or anything like that. Its as if the program has completely ignored everything to do with print_house onwards.

You don't call print_house anywhere in the code you pasted. You're definitely calling it, right? :)

Does the IDE have a "clean" option? It'll probably be near whatever menu/button you use to build. If it does, try that then try building again. If not, see if there are any *.o or *.obj files around where the exe was, and delete them. The compiler outputs these (object) files, then the linker then puts them together into an exe. So it is possible that the code hasn't been regenerated.

Still got some warnings/errors

Code:

---

kurt@kurt-virtual-machine:~/c_tests$ gcc pp.c -Wall --pedantic
pp.c: In function 'DescribeRoom':
pp.c:65:2: warning: format '%d' expects a matching 'int' argument [-Wformat]
pp.c:66:2: warning: format not a string literal and no format arguments [-Wformat-security]
pp.c:68:2: warning: format not a string literal and no format arguments [-Wformat-security]
pp.c: In function 'GetDirection':
pp.c:86:3: warning: implicit declaration of function 'getch' [-Wimplicit-function-declaration]
pp.c: At top level:
pp.c:98:6: warning: return type of 'main' is not 'int' [-Wmain]
pp.c: In function 'print_house':
pp.c:113:68: warning: C++ style comments are not allowed in ISO C90 [enabled by default]
pp.c:113:68: warning: (this will be reported only once per input file) [enabled by default]
/tmp/ccnim8E1.o: In function `GetDirection':
pp.c:(.text+0x5e3): undefined reference to `getch'

---

Kurt

Code:

---

#include <stdio.h>
#include <stdlib.h>
#define North 0
#define East 1
#define South 2
#define West 3
typedef struct{
  char RoomName[30];
  char Description[500];
  unsigned int Exit[4];
}Location;
Location Room[7];
void SetupRooms()
{
strcpy(Room[1].RoomName, "AirLock");
strcpy(Room[1].Description,"As you enter the facility you find your comms channels have scrambled. \nYou appear to be in some kind of air lock. \nIn front of you the light turns green and you can hear bolts shifting.");
Room[1].Exit[North]=2;
Room[1].Exit[East]=0;
Room[1].Exit[South]=50;
Room[1].Exit[West]=0;
strcpy(Room[2].RoomName, "Main Canteen");
strcpy(Room[2].Description,"\"Arrrgghhhhhhh\" A muffled scream dies out somewhere up ahead as you \nstep into a wide berthed room full of regimented tables and chairs, \nto the left is a food station. Looks like your in the canteen.");
Room[2].Exit[North]=3;
Room[2].Exit[East]=4;
Room[2].Exit[South]=1;
Room[2].Exit[West]=5;
strcpy(Room[3].RoomName, "Stasis Chamber");
strcpy(Room[3].Description,"After a brief scan from the remaining functional automatic \nsystems you enter a completely white room with a large bank of computer systems next to a row of malfunctioning cryogenic bays. \nBehind you comes those sounds from earlier, very very close. Its found you.\n No time for lockdown, There is only one other door aside from where you came in. To the escape pods!");
Room[3].Exit[North]=0;
Room[3].Exit[East]=0;
Room[3].Exit[South]=0;
Room[3].Exit[West]=7;
strcpy(Room[4].RoomName, "Decontamination Chamber");
strcpy(Room[4].Description,"Tentatively you follow the big warning signs and step into a room with plastic shawls on each side with shower heads poking through. Its impossible to tell how big the room actually is beyond this and shadows dance menacingly behind every surface.");
Room[4].Exit[North]=0;
Room[4].Exit[East]=0;
Room[4].Exit[South]=0;
Room[4].Exit[West]=2;
strcpy(Room[5].RoomName, "Containment Facility");
strcpy(Room[5].Description,"The doors are heavy, but warped and twisted. You crouch and make your way through a gap whilst trying not to question the damp surface. Once in you can see that the containment room itself is severly damaged, chemical burns splatter the walls and a metallic odour flips your stomach. Suddenly a wet \"Thud\" and snarl sounds from the corridor in front of you leading to the cages. Everything in your body wants to turn back.");
Room[5].Exit[North]=0;
Room[5].Exit[East]=2;
Room[5].Exit[South]=0;
Room[5].Exit[West]=6;
strcpy(Room[6].RoomName, "Cages");
strcpy(Room[6].Description,"Against everything, you carry on towards the sound. This is the place where they must have been keeping whatever it is. What you've been sent to secure. The air is heavy here and there are definite sounds of life from the end cage. Whatever it is, its in there. Now you must isolate the facility from the central control unit in the crews stasis chamber and leave as quickly as you can.");
Room[6].Exit[North]=0;
Room[6].Exit[East]=5;
Room[6].Exit[South]=0;
Room[6].Exit[West]=0;
strcpy(Room[7].RoomName, "Escape Pods");
strcpy(Room[7].Description,"Houses the household computer and bookshelves filled to the brim. Rob is in the corner fapping. Its too late, the creature has found you...its Paedobear. The next scene has been censored.");
Room[7].Exit[North]=50;
Room[7].Exit[East]=0;
Room[7].Exit[South]=0;
Room[7].Exit[West]=0;
}
void DescribeRoom(unsigned int i)
{
 printf("You are sent to a home facility for testing of new biological sciences after it stopped responding to communications. \nYou are to secure that the stored subjects are still within the facility and initilise lockdown.\n \n");
 printf("%15d- Maps indicate that your are in the ");
 printf(Room[i].RoomName);
 printf(" -0\n\n\n\n");
 printf(Room[i].Description);
 printf("\n\n");
}
void DescribeExits(unsigned int i)
{
 printf("There are doors to your;\n");
 if(Room[i].Exit[North]!=0) printf("North\n");
 if(Room[i].Exit[East]!=0) printf("East\n");
 if(Room[i].Exit[South]!=0) printf("South\n");
 if(Room[i].Exit[West]!=0) printf("West\n");
 printf("\nInput the first letter of your desired direction to move. \nPress q to quit the system.\n");
}
int GetDirection(unsigned int i)
{
 char test;
 unsigned int NewDirection=0;
 while(1)
 {
  test=getch();
  if(test=='n') NewDirection=Room[i].Exit[North];
  if(test=='e') NewDirection=Room[i].Exit[East];
  if(test=='s') NewDirection=Room[i].Exit[South];
  if(test=='w') NewDirection=Room[i].Exit[West];
  if(test=='q') NewDirection=50;
 
  if(NewDirection!=0) return(NewDirection);
  printf("Theres no way you can go there.\n");
 }
}
 
void main()
{
 unsigned int RoomNumber = 1;
 unsigned int Direction;
 SetupRooms();
  while(1)
  {
  system("cls");
  print_house(RoomNumber);
  DescribeRoom(RoomNumber);
  DescribeExits(RoomNumber);
  Direction = GetDirection(RoomNumber);
  if(Direction==50)exit(0);
  if(Direction>0)RoomNumber= Direction;
  }
  }
void print_house(unsigned int RoomNumber, unsigned int Direction){ // set up Room numbers and Directions
#define RoomNumbers 7
 char Room_x[RoomNumbers];
 unsigned int i;
 for ( i=0; i<RoomNumbers; ++i ) {
    if ( i == RoomNumber)
        Room_x[i] = 'X';
    else
        Room_x[i] = ' ';
}
 printf("___________________________________________________________\n");
 printf("|                    _____________________                |\n");
 printf("|                    |                  |                |\n");
 printf("|        __________  |                  |                |\n");
 printf("|      /          | |                  |                |\n");
 printf("|      /          |_|    Stasis        |                |\n");
 printf("|    / Escape            Chamber      |                |\n");
 printf("|    \\  Pod  %c    _                    |                |\n", Room_x[7]);
 printf("|    \\          | |        %c        |                |\n", Room_x[3]);
 printf("|      \\__________| |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |________  ________|                |\n");
 printf("|                    _______|  |________                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|________  ___________|                  | _______________|\n");
 printf("|        ||          |                  ||              |\n");
 printf("|  Cages ||Containment|                  ||Decontamination|\n");
 printf("|  %c      Facility                          Chamber    |\n", Room_x[6]);
 printf("|              %c                                        |\n", Room_x[5]);
 printf("|        ||          |    Canteen      ||      %c      |\n", Room_x[4]);
 printf("|________||___________|                  ||_______________|\n");
 printf("|                    |        %c        |                |\n", Room_x[2]);
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |                  |                |\n");
 printf("|                    |_____    ________|                |\n");
 printf("|                        |        |                      |\n");
 printf("|________________________| Airlock |______________________|\n");
 printf("                        |  %c    |                      \n", Room_x[1]);
 printf("                        |___  ___|                      \n");
}

---

-Smokeyangel, this is my current code. I think i may of been quite silly in not calling it, thankyou very much with your time on this its very very much appreciated.

I can tell we are almost there. With the code above i have the error now of:
Type missmatch in redeclaration of print_house
On line: 110

Code:

---

strcpy(Room[1].RoomName, "AirLock");
strcpy(Room[1].Description,"As you enter the facility you find your comms channels have scrambled. \nYou appear to be in some kind of air lock. \nIn front of you the light turns green and you can hear bolts shifting.");
Room[1].Exit[North]=2;
Room[1].Exit[East]=0;
Room[1].Exit[South]=50;
Room[1].Exit[West]=0;
strcpy(Room[2].RoomName, "Main Canteen");
strcpy(Room[2].Description,"\"Arrrgghhhhhhh\" A muffled scream dies out somewhere up ahead as you \nstep into a wide berthed room full of regimented tables and chairs, \nto the left is a food station. Looks like your in the canteen.");
Room[2].Exit[North]=3;
Room[2].Exit[East]=4;
Room[2].Exit[South]=1;
Room[2].Exit[West]=5;
strcpy(Room[3].RoomName, "Stasis Chamber");
strcpy(Room[3].Description,"After a brief scan from the remaining functional automatic \nsystems you enter a completely white room with a large bank of computer systems next to a row of malfunctioning cryogenic bays. \nBehind you comes those sounds from earlier, very very close. Its found you.\n No time for lockdown, There is only one other door aside from where you came in. To the escape pods!");
Room[3].Exit[North]=0;
Room[3].Exit[East]=0;
Room[3].Exit[South]=0;
Room[3].Exit[West]=7;
strcpy(Room[4].RoomName, "Decontamination Chamber");
strcpy(Room[4].Description,"Tentatively you follow the big warning signs and step into a room with plastic shawls on each side with shower heads poking through. Its impossible to tell how big the room actually is beyond this and shadows dance menacingly behind every surface.");
Room[4].Exit[North]=0;
Room[4].Exit[East]=0;
Room[4].Exit[South]=0;
Room[4].Exit[West]=2;
strcpy(Room[5].RoomName, "Containment Facility");
strcpy(Room[5].Description,"The doors are heavy, but warped and twisted. You crouch and make your way through a gap whilst trying not to question the damp surface. Once in you can see that the containment room itself is severly damaged, chemical burns splatter the walls and a metallic odour flips your stomach. Suddenly a wet \"Thud\" and snarl sounds from the corridor in front of you leading to the cages. Everything in your body wants to turn back.");
Room[5].Exit[North]=0;
Room[5].Exit[East]=2;
Room[5].Exit[South]=0;
Room[5].Exit[West]=6;
strcpy(Room[6].RoomName, "Cages");
strcpy(Room[6].Description,"Against everything, you carry on towards the sound. This is the place where they must have been keeping whatever it is. What you've been sent to secure. The air is heavy here and there are definite sounds of life from the end cage. Whatever it is, its in there. Now you must isolate the facility from the central control unit in the crews stasis chamber and leave as quickly as you can.");
Room[6].Exit[North]=0;
Room[6].Exit[East]=5;
Room[6].Exit[South]=0;
Room[6].Exit[West]=0;
strcpy(Room[7].RoomName, "Escape Pods");
strcpy(Room[7].Description,"Houses the household computer and bookshelves filled to the brim. Rob is in the corner fapping. Its too late, the creature has found you...its Paedobear. The next scene has been censored.");
Room[7].Exit[North]=50;
Room[7].Exit[East]=0;
Room[7].Exit[South]=0;
Room[7].Exit[West]=0;
}

---

C array starts at '0', for array size 7, the last element MUST end at 6

Quote:

---

pp.c:86:3: warning: implicit declaration of function 'getch' [-Wimplicit-function-declaration]

---

because you didn't include the lib for it. I belive getch need conio.h(may be deprecated). why don't you just use getchar?

Nimitzhunter. 0 = there is no way you can go that way (look lower down in the code)
1= airlock
""
""
7= escape pods

No problem, happy to help :)

Problem now is that you're calling print_house before you've declared it in the source file, so the compiler will guess at the parameters. Then it'll complain because you haven't supplied enough parameters. You can either move the whole print_house up above main, or you can put a function prototype somewhere before main. A function prototype is just a copy of what you've already got:

Code:

---

void print_house(unsigned int RoomNumber, unsigned int Direction); // note semicolon
void main()
{
 unsigned int RoomNumber = 1;
... etc

---

You can put the prototype anywhere in the file so long as it's before main.

It still won't work because you have print_house expecting 2 parameters: RoomNumber and Direction, but you're only calling it with 1: RoomNumber. Since you're not actually using Direction in print_house, you could get rid of the parameter. Or you could call it with both parameters.

Quote:

---

Originally Posted by L.Firth

Nimitzhunter. 0 = there is no way you can go that way (look lower down in the code)
1= airlock
""
""
7= escape pods

---

Sure, but the point is that you declare array like this:

Code:

---

Location Room[7];

---

This creates 7 elements numbered 0 to 6. It doesn't matter what numbers you give to the rooms -- you can't read from or write to Room[7]. If you are doing, and it's working, then that's by chance not by design. It's actually the worst case scenario in my opinion that it "just works" -- it WILL break eventually, and it's not fun to debug/track down.

My apologies, i made a mistake in only having 7 when i should of had 8. 0-7.

In other news, thankyou Smokey Angel as it now works, all i have to do now is place the map in a different place on screen and i'm away. You have been a great help!

your print_house function also messes up the array.

Code:

---

printf("|    \\  Pod  %c    _                    |                |\n", Room_x[7]);

---

Room_x[7] doesn't exist; it's whatever value exists in the memory location after Room_x[6]; so basically it's junk.

Great! Glad it works.

Quote:

---

Originally Posted by L.Firth

My apologies, i made a mistake in only having 7 when i should of had 8. 0-7.

---

Hmmmm. Well, that'll solve the potential problem of memory access violations/segfaults, but it's not ideal, as you're taking up memory for 8 items when you only have 7. In the grand scheme of things it may seem a bit silly to worry about 500 or so bytes of space -- but IMO it's Bad Coding to take up more space than you need. Also, anyone modifying your program will expect the array to be indexed from 0. You've even made the mistake yourself:

Code:

---

for ( i=0; i<RoomNumbers; ++i ) {

---

This will process Room[0]. What a waste of cpu time....okay, being silly, but.... you might want to change it to i = 1, but I think it's a bad habit to pick up.

Looking at your code and the code of ShotgunChimp, who is doing the same thing, I can see you're both using 0 as a sentinel value to mean "Direction not valid". Since the code is identical I suspect it came from an instructor/teacher? That ........es me off - not only failing to teach you something, but also providing you with code that would need modification to do things properly. Unless there's something I'm missing... since other arrays are correctly indexed from 0 in the program.

Grumble. Rant over.