Unable to open file using fopen()

I have following piece of code:

Code:

---

#define MAX_BYTES_LINE        100

// Main Program starts here

//int main(int argc,char *argv[])
int main()
{
        char **ptdata,filename[40],count[10];
        int cnt=2,i;
        FILE *pFile;

        /*if((argv[1] == NULL)&&(argv[2] == NULL))
        {
                printf("ERROR: Insufficient info \n");
                return 1;
        }

        //Copy command line strings
        strcpy(filename,argv[1]);
        strcpy(count,argv[2]);
        cnt = atoi(count);
        printf("Filename : %s count :%s , count :%d",filename,count,cnt);*/
       
        strcpy(filename,"noop.txt"); //Assigning the filename

        //Allocate memory
        ptdata = malloc(cnt*MAX_BYTES_LINE*sizeof(char *));
        if(ptdata == NULL)
        {
                printf("ERROR:Insufficient Memory\n");
                return 1;
        }
        for(i=0;i<(cnt*MAX_BYTES_LINE);i++)
        {
                ptdata[i] = malloc(20*sizeof(char));
                if(ptdata[i] == NULL)
                {
                        printf("ERROR:Insufficient Memory\n");
                        return 1;
                }
        }

        //File open       
        pFile = fopen(filename,"r+"); //Does open file with this
        //pFile = fopen("noop.txt","r+"); //Works fine here
        if(pFile == NULL)
        {
                printf("ERROR : File cannot be opened\n");
                return 1;
        }
       
        //Read file content       
        fread (ptdata[1],1,20,pFile);

        printf("File content:%s",ptdata[1]);
       

        //Destructor
        fclose(pFile);
        for(i=0;i<(cnt*MAX_BYTES_LINE);i++)
                free(ptdata[i]);
        free(ptdata);

        return 0;
}

---

1. Why can't open File ,when I pass a buffer containing the filename to fopen()


Thanks

You should post the simplest program that demonstrates the problem. Also be sure it is able to compile, including all necessary headers.

Here's a simplification of your code. Does it work for you? If not, then either the file doesn't exist or you're accessing the wrong directory.

Code:

---

#include <stdio.h>
#include <string.h>

int main()
{
        char filename[40];
        FILE *pFile;

        strcpy(filename,"noop.txt");

        pFile = fopen(filename,"r+");
        if(pFile == NULL)
        {
                printf("ERROR : File cannot be opened\n");
                return 1;
        }

        fclose(pFile);

        return 0;
}

---

I agree your suggestion....... was in hurry......

I am unable to open the file, But it works fine if i pass the file name directly to the function.

what may be wrong in the higlighted code?

Thanks in advance

Nothing seems to be wrong with the highlighted code.
You didn't answer my question.
Does the simplified program that I posted work for you?

Quote:

---

Originally Posted by sanddune008

1. Why can't open File ,[B]when I pass a buffer containing the filename to fopen()

---

Ask the system itself:

Code:

---

        pFile = fopen(filename,"r+"); //Does open file with this
        if(pFile == NULL)
        {
                perror(filename);
                return 1;
        }

---

@oogabooga.......Simplified ex worked!!!....

How are you running the code? Within an IDE or from the command-line?

Quote:

---

Originally Posted by sanddune008

@oogabooga.......Simplified ex worked!!!....

---

then probably something you are doing between the strcpy and fopen is corrupting filename. printf the filename after your mallocs and right before the fopen.