problem with array transport between programs

I'm triyng to use an older program of mine as a function of a new one i made but instead of just coping the code of the older to the new i wanted to use they as separeted files, i writed the codes i tought would be enough for this task and compilated the new one as main.c and the older as function.o with gcc but i'm geting a giant stray error, gonna post the coded and ask if any of you can help me, i'm doing this on linux.

main.c

Code:

---

#include <stdio.h> 
#include "function.o"
#define N 4000

void function( float Sx[], float h[], float Cor[][4], int PontosSpec, int v );


int main()
{

  int v, j,  NumeroEspectros, PontosSpec, q;
  char  L[N][1000];
  signed char  x[N][1000];
  float Sx[N], h[N], c[N], Cor[N][4];

...

    function(Sx, h, Cor, PontosSpec, v);

...
}

---

function.o

Code:

---

 
#include <math.h>
#include <stdio.h>
#include <stdlib.h>
#define N 4000
void function( float Sx[], float h[], float Cor[][4], int PontosSpec, int v )
{
 
  int i,j,q,NumeroPontosS, NumeroPontos ;
  float  y[N+1],p[N+1], o[N+1],l[N+1],z[N],x[N+1],a,b, Sy[N];

...

Cor = ...;
}

---

I know the problem is in the link because both programs work fine when separated, i'm using "gcc main.c function.o -o prog" to compilate both in an executable, the awnser i need is the "Cor'' parameter, I'm getting errors like this in a lot of lines in the function when tryiyng to compilate:


error: stray ‘\374’ in program
error: stray ‘\377’ in program
...

That surely isn't your function.o file. Please tell me that's not your function.o file. If that is, rename it to function.c and stop lying to your C compiler.

Quote:

---

Originally Posted by tabstop

That surely isn't your function.o file. Please tell me that's not your function.o file. If that is, rename it to function.c and stop lying to your C compiler.

---

If i try to make an executable with the main. and function.c files instead of main.c and function.o the result is the same.

create a new file called function.h, add it to your project

put this in function.h:

Code:

---

#define N 4000

void function( float Sx[], float h[], float Cor[][4], int PontosSpec, int v );

---

create a file called function.c, add it to your project

put this in function.c:

Code:

---

#include <math.h>
#include <stdio.h>
#include <stdlib.h>
#include "function.h"

#define N 4000

void function( float Sx[], float h[], float Cor[][4], int PontosSpec, int v )
{
 
  int i,j,q,NumeroPontosS, NumeroPontos ;
  float  y[N+1],p[N+1], o[N+1],l[N+1],z[N],x[N+1],a,b, Sy[N];

...

Cor = ...;
}

---

Am not saying your code problems are over by doing this...

Quote:

---

Originally Posted by rogster001

create a new file called function.h, add it to your project

put this in function.h:

Code:

---


void function( float Sx[], float h[], float Cor[][4], int PontosSpec, int v );

---

create a file called function.c, add it to your project

put this in function.c:

Code:

---

#include <math.h>
#include <stdio.h>
#include <stdlib.h>
#include "function.h"

#define N 4000

void function( float Sx[], float h[], float Cor[][4], int PontosSpec, int v )
{
 
  int i,j,q,NumeroPontosS, NumeroPontos ;
  float  y[N+1],p[N+1], o[N+1],l[N+1],z[N],x[N+1],a,b, Sy[N];

...

Cor = ...;
}

---

---

... then compile them separately into .o files and use LINK to combine them into an executable file.

Do i erase the "#include "function.o" " from main.c? as long as this is there i get the same error.

yes, i thought i showed that in the example code, replace it with function.h - files with an .o extension are objectfiles, an intermediate build file, you dont work with those directly, you need to create a header file as shown - .h

in a header file you can put all the descriptions of your functions and data types, member variables they have, arguments the functions take.

Then you include this header file in any of your source files that need to use the functions it describes - the function working code 'the function definitions. i.e. body of the function is contained in the source file function.c as shown

Did what you told me, compiled them separated in .o files and them compiled them like this "gcc main.o function.o function.h -o prog", got the executable but the arrays are not geting to the function, i get 0.0 as awnser on the Cor parameter.

So maybe that's the answer.

I'm surprised the thing even runs, with as many 4MB arrays as you're putting on the stack.

Made an quick code to test what you guys are telling me, it didnt work either so i must be doing something wrong.

Code:

---

#include <stdio.h>
#include "del.h"

main()
{

  int v;

v=1;
deli(v);
printf("v = %d",v);
}

---

Code:

---

#include <stdio.h>
#include "del.h"


void deli( int v )
{
v = v + 1;
}

---

Code:

---

void deli( int v );

---

compilated: gcc del.o deli.o del.h -o del

im geting v = 1 as awnser wich means its not passing troght.

Quote:

---

Am not saying your code problems are over by doing this...

---

yep, ...

Your v variable is only changed within the scope of the function it is passed to, you need to read up on scope, pointers, references

try putting a printf statement inside the function you will soon see...

Notice that arrays are different in this respect: you can modify arrays inside a function (as they are passed by pointer), but not "normal" variables.

Yeah, it worked which means my problems are worst than i thought, thank you anyway, you dont happen know any tutorial about this kind of operation do you?

You've been very careful not to even hint at what operation you are doing, so I don't know how we could possibly suggest a tutorial.

Quote:

---

Originally Posted by vtergolina

Do i erase the "#include "function.o" " from main.c? as long as this is there i get the same error.

---

Yes. You cannot include object files. #include is intended mainly for header (.h) and source (.c) files with the latter being rarely used.

Grab your C textbooks and start reading... the relationship between headers and source files should be explained there as well as the rules for scope and function calls.

Quote:

---

Originally Posted by vtergolina

Yeah, it worked which means my problems are worst than i thought, thank you anyway, you dont happen know any tutorial about this kind of operation do you?

---

Based on what you have demonstrated for your issues, may I suggest a refresher in C:

Cprogramming C Tutorials
Teach Yourself C in 21 Days

Quote:

---

Originally Posted by tabstop

You've been very careful not to even hint at what operation you are doing, so I don't know how we could possibly suggest a tutorial.

---

I'm reading specters from stars wich means i need to store an X value for waveleghts and an Y value for radiation flux, the function i'm using is an older program wich get this specters and filter them in specific wavelehghts, it works fine. The new program i made, i did because i needed to automatizate the older so he can do his task with 4000 specters instead of 1 like it's original task.

So it basicalys read the arrays X and Y of each specter and them passes one by one to the older program so he can filter it them, i wanted it to give back to the new program the awnser which is the integral of the filtred specter, the integral also was calculated on the older program.

Did you actually change the code of the original, or are you trying to make "function" your filter? You'll want to make sure you are calling the original code with the data it expects (unwrapping these 4000-long arrays, etc.)

I didn't notice before, but you wrote "Cor = ..." in your original snippet above. That's not going to get you anywhere. You only assign to individual slots of an array.

I changed the code so it should be geting the arrays from the new program like it used to get from the fscanf back when it filtered one specter at time. But i don know if it is geting the arrays because i tried printing from the function and still giving me 0.0 as awnser so its probably no geting the arrays. I know the new program is reading the arrays fine because i tested it before trying to put it togheter with the new.

We don't know either because we don't have any code to work off of. Try to break this down to as simple of an implementation that you can and show us what you have.

My problem is that the way i specified it on the new program aparently isnt enough to pass the arrays Sx[j] and h[j] to the older.

Quote:

---

Originally Posted by vtergolina

My problem is that the way i specified it on the new program aparently isnt enough to pass the arrays Sx[j] and h[j] to the older.

---

Given the history up to this point, I'd say this almost certainly isn't your problem, or at least isn't your only problem. For one thing, I don't think it actually means anything.

Quote:

---

Originally Posted by AndrewHunter

We don't know either because we don't have any code to work off of. Try to break this down to as simple of an implementation that you can and show us what you have.

---

Ok, i have to go to class now but i'll get back here as soon as i can with a template of it.

Found my error guys. the Cor parameter was giving 0.0000 because i was trying to print it as %f, changed it to %e and it gave me the right value, thanks for the help!

Code:

---


#define N 4000

char  L[N][1000];
signed char  x[N][1000];

float Sx[N], h[N], c[N], Cor[N][4];

---

Frankly I'm amazed it runs at all...
These arrays are enormous... over 8 megs of data created on your program's stack.
Your L array alone is 4 megs...

Most programs only have a 1meg stack...
You seriously need to look into using malloc() and free() to create these arrays.