A Qn on Posix threads

Hi,

A sample program using POSIX threads (with basic pthread functions) runs well perfectly for 1 thread/2 threads. But for more than 2 threads it fails with Segmentation fault.
The function which is threaded, makes use of a variable 'flag' & contains an if statement. If the "if" condition is true, flag will be set to 0 and the loop will be break in the next iteration. To test the next case, again the flag is set to 1.
The server has 2 cores.
The memory allocation statement is:

// params is a structure
params *thread_params = (params*) malloc( nthreads * sizeof(params*));

What could be the reason for "seg fault" here?

Let me know if the complete program is required.

Thanks

You compile with the -g flag.
You run the code in the debugger.
You get a much better idea of where the problem REALLY is.

As opposed to posting 1 line of code, and hoping we can guess what it is you're seeing.

Code:

---

params *thread_params = (params*) malloc( nthreads * sizeof(params*));

---

If you're programming in C, there is no need to cast the return value of malloc, and doing so can hide more insidious issues like failing to include the stdlib.h header required for malloc, which will cause further problems. On the bright side of things, good job on your sizeof() call; using sizeof(*type) is the right way to do it.

Quote:

---

Originally Posted by rags_to_riches

On the bright side of things, good job on your sizeof() call; using sizeof(*type) is the right way to do it.

---

Actually, the sizeof in your malloc is incorrect. I read it wrong too at first. You did params*, which is the size of one pointer, not one param (whatever that is). The preferred malloc usage is:

Code:

---

params *thread_params = malloc(nthreads * sizeof(*thread_params));

---

The name of the variable goes in the sizeof call, with a star in front of it.