Segmentation fault.

When i run this program i get the error segamentation fault (core dumped). I have checked my placeholders several times and can't seem to find the error.
Can anyone tell me what causes segmentation fault. And if any of you have the time feel free to see if you can't find the error i've made.

Code:

---

#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#define max_number_of_matches 198


  struct match {
        int round;
        char day[3];
    char time[5];
        char hometeam[3];
        char awayteam[3];
        int hometeam_score;
        int awayteam_score;
  };
        typedef struct match match;
               
        void read_resultater(const char *filename, match matches[]){
                FILE *fp;
                char day_m[3], time_m[5], hometm[3], awaytm[3];
                int i, rnd, hometm_score, awaytm_score, scanres;
                match local_match;
               
                fp=fopen(filename,"r");
               
                scanres = fscanf(fp, "%d  %s  %s  %s - %s  %d - %d", &rnd, day_m, time_m, hometm, awaytm, &hometm_score, &awaytm_score);
                while (scanres ==7){
               
                local_match.round = rnd;
                strcpy(local_match.day, day_m);
                strcpy(local_match.time, time_m);
                strcpy(local_match.hometeam, hometm);
                strcpy(local_match.awayteam, awaytm);
                local_match.hometeam_score = hometm_score;
                local_match.awayteam_score = awaytm_score;
               
                matches[i] = local_match;
               
                scanres = fscanf(fp, "%d  %s  %s  %s - %s  %d - %d", &rnd, day_m, time_m, hometm, awaytm, &hometm_score, &awaytm_score);
                i++;
                }
               
                fclose(fp);       
        }
       
        void print_match(match m){
                printf("%d  %s  %s  %s - %s  %d - %d \n", m.round, m.day, m.time, m.hometeam, m.awayteam, m.hometeam_score, m.awayteam_score);
        }
       
        int main(void){
        int i;
                match matches_SAS_2009[max_number_of_matches];
                read_resultater("resultater.txt", matches_SAS_2009);
               
                for(i=0; i <= 198; i++){
                print_match(matches_SAS_2009[i]);
                }
        return 0;
}

---

Code:

---

i <= 198

---

No such thing as item #198 in your array. (You also should be using your max_whatever defined constant instead of a plain number here.

Shouldn't make any difference. and it doesn't i still get a segmentation error.

1) If you want people to study your code, show the courtesy of wrapping it in the forum's code tags (click on the # icon in the top of the editor window, and paste your code, between the supplied
[CODE ] [/CODE ] tags).

2) Learn to narrow down your seg faults to at least one function, by trying it without calling one function at a time, and see how it does. Troubleshooting bugs in code is a necessary skill to develop, don't ignore it.

And Welcome to the forum, Dizzy++! :D

Okay so far i have tested my program bit by bit. And i believe that my error is in

Code:

---

void read_resultater(const char *filename, match matches[])

---

And if I edit my while loop to be any other number than 7 it shows an unreadable portion of the txt file. What is the cause of this :S

You write to matches[i] in your read function. Were you planning to give i a real value before you start?

Quote:

---

Originally Posted by tabstop

You write to matches[i] in your read function. Were you planning to give i a real value before you start?

---

Well you are right aout that i should assign i a value. So i assigned it the value 0. After compiling, it still shows the txt file as unreadable, but still more readable than before. But still don't know what the error is

What text file? Or do you mean that you are redirecting the output into a text file? You may very well get garbage at the end, since you are printing 199 results no matter how many get read.

So because i am reading to many lines of text it just gives me garbage?

I don't see any initialization code for i in read_resultater() function. and you are using it to index array.
As tabstop has pointed out, Array[N] valid indices 0 to N-1 inclusive.
You are printing up to 199( 0-198) records. How the hell do you know that you've read that many records?

Edit: are you sure that your input string are not longer than array sizes in your fscanf() call?

Because you're reading too few lines. Your read function never bothers to tell anybody else how many lines get read, so you have no way of knowing, when you're printing, whether you're printing something valid or not.

Paste the first few lines of your input data file.

> char day_m[3], time_m[5], hometm[3], awaytm[3];
Because if any day or team name has more that TWO characters, then you're screwed.

Most likely the OP is not taking into consideration the need to allocate 1 extra character for \0 at the end of his strings. So in his version 3 characters (i.e. FRA vs ENG) seem sufficient.