Multiple definition error, one definition

I am trying to finish off a text RPG, and a strange problem has cropped up. I get the error "multiple definition of [x]", and then a reference to where it was 'first' defined, being a function that only uses the objects, but does not define them. Here is a rundown of the set up:

In header ENTITIES_H, an array of items is created like this. The intention is for them to be global. ENTITIES_H uses #ifndef. Note that the compiler does not say the objects were first defined here. What are accused of being redefined are potion, ether, etc..:

Code:

---

Item items[5] = { potion, ether, bandage, eyeDrops, antigen };

---

These hold the characteristics of the items, and are only instantiated once. The inventory is an integer array that holds the number of each item held.

This header is included in two files, SHOP.CPP and PLAYER.CPP, which both make references like:

Code:

---

for (int i=0;i<5;i++) //Determine if the player has anything
    {
        int check = 0;
        check += inventory[i];
        if ( inventory[i] > 0 )
            cout << i+1 << ". " << items[i].itemName << " - x" << inventory[i] << endl;
    }

---

Why is the compiler telling me I am attempting to redefine them? There is absolutely no instantiation of class Item outside of ENTITIES_H.

Thanks!

You probably need header guards in your header.

Code:

---

#ifndef ENTITIES_H
#define ENTITIES_H

//////////////  all other entries go here


#endif

---

Quote:

---

Originally Posted by jimblumberg

You probably need header guards in your header.

---

They are already included.

Quote:

---

Originally Posted by frog

Why is the compiler telling me I am attempting to redefine them? There is absolutely no instantiation of class Item outside of ENTITIES_H.

---

Instantiating an object inside a header file is the cause of the problem.

It is not the compiler complaining about multiple definitions. It will be the linker.

And the reason, as brewbuck noted, is that your a defining the variable in a header file - which means it is defined in every source file that #include's that header. You are #include'ing that header in two source files, so your array of items is defined twice.

I get the deal about multiple definitions now, even though at first it wasn't apparent to me. I included extern declarations in the header file, and defined them in a source file.

It now links just fine. However, I have another problem: I could only get this to work by defining the Items in the global area in main.cpp. I had first tried to define them in an items.cpp file, but they were not recognizedas being there. While effectively this setup is the same, it is butt-ugly. Why is it not recognizing the definitions in items.cpp?

Without seeing your code, how can we know?

Jim

When building the executable, the main.o and items.o need to BOTH be supplied to the linker (as parameters on the command line).

try #pragma once

Quote:

---

Originally Posted by Eman

try #pragma once

---

.... if you wish to have a non-portable approach that also doesn't address the problem being discussed in this thread.