From global to local variable

Hi,

I need some help to convert global variables into local variables. How the hell do i do that when im operating with .txt files.

The following is a part of my program.

Thanks

Code:

---


#define infilename "input.txt"
#define outfilename "output.txt"


int main(void)

{

        FILE *infile, *outfile;

        if (!(infile = fopen(infilename, "r")) || !(outfile = fopen(outfilename, "w")))
        {
                puts("Fejl: kan ej åbne filer\n");
                exit(EXIT_FAILURE);
        }
        CreatePwList(infile, outfile);
        fclose(infile); fclose(outfile);
        return 1;
}

---

You don't have any truly global variables there. You have two #defines, which are substituted into the code during the preprocessing phase and aren't variables at all; the are, in fact, constants.

Well i want to eliminate them. Any idea how i can do that without ruining the code?

Wellll... you could try this...

Code:

---

if (!(infile = fopen("input.txt", "r")) || !(outfile = fopen("output.txt", "w")))

---

Which is how the compiler sees it.

Thanks for the help. What about this one, is this also a constant (or variable?), and how do i eliminate it?

Code:

---


#define MAXCHARS 100

void CreatePwList(FILE *in, FILE *out)
{
        char templine[MAXCHARS], fornavn[MAXCHARS];
        char efternavn[MAXCHARS], klasse[MAXCHARS];
        int elevnr=0, i=0;

        while(fgets(templine, MAXCHARS, in))
        {
                elevnr++;
                i = GrabSubStr(fornavn, templine, 0);
                i = GrabSubStr(efternavn, templine, i);
                    GrabSubStr(klasse, templine, i);

                sprintf(templine, "%c%c%d;%c%c%d%s;%s;%s;%s\n",
                                fornavn[0], efternavn[0], elevnr,
                                fornavn[0], efternavn[0], elevnr, "DTU",
                                klasse, fornavn, efternavn);
                printf(templine);
                fputs(templine, out);
        }
}

---

Never mind, i just found out how to fix it :)

This works for me:

Code:

---


void CreatePwList(FILE *in, FILE *out)
{
        char templine[100], fornavn[100];
        char efternavn[100], klasse[100];
        int elevnr=0, i=0;

        while(fgets(templine, 100, in))
        {
                elevnr++;
                i = GrabSubStr(fornavn, templine, 0);
                i = GrabSubStr(efternavn, templine, i);
                    GrabSubStr(klasse, templine, i);

                sprintf(templine, "%c%c%d;%c%c%d%s;%s;%s;%s\n",
                                fornavn[0], efternavn[0], elevnr,
                                fornavn[0], efternavn[0], elevnr, "DTU",
                                klasse, fornavn, efternavn);
                printf(templine);
                fputs(templine, out);
        }
}

---

In this case, it's a step backwards, because everytime you change the size, you have to change it in 5 places instead of one.

Quote:

---

Originally Posted by Elysia

In this case, it's a step backwards, because everytime you change the size, you have to change it in 5 places instead of one.

---

Yep, I was thinking the same thing.

#define does have it's benefits.

Yea, i know it's a bit silly, but the thing is that we aren't allowed to use global variables in our assignment. Don't know why.

Those aren't global variables. They are not even variables, they are just bits of text that the compiler will replace directly in your code before it compiles it.

Quote:

---

Originally Posted by urban1990

Yea, i know it's a bit silly, but the thing is that we aren't allowed to use global variables in our assignment. Don't know why.

---

First of all a #define is not a variable, it's a constant that can't be changed within the program.

Secondly it's just plain unreasonable to think you can write programs any bigger than "tic tac toe" without at least a couple of variables that have to be shared. Global variables have their places... interprocess signalling, settings, behavioral flags, window handles etc. It might be fun for your assignment, but it ain't practical in a project of any real size.

No, actually, it's a good thing that you aren't allowed to use global variables. Not that they do not have their places; they should be used sparingly, and carefully.
Chances are that, in a small projects, you don't even need them.