trying to pass a array of a class

well i have one solution to my code right now but i would prefer to keep the main function simplier

Code:

---


#include <string>
#include <iostream>

using namespace std;

class monster
{
public:
        int m_hps;
};

void displayMonsterHealth(monster &mon);

int main()
{
        monster mon[4];
        mon[0].m_hps = 23;
        mon[1].m_hps = 12;
        mon[2].m_hps = 31;
        mon[3].m_hps = 1;


        for( int i = 0; i < 4; ++i)
                displayMonsterHealth(mon[i]);                // this works to display the information from class
                                                                                        // monster but i would prefer......




        system("pause");
        return 0;
}

void displayMonsterHealth(monster &mon)
{
        cout << mon.m_hps << endl;                                // to be able manage the same thing with the for(int i = 0; i < 4; ++i)
}                                                                        // here and leave the Main function simple. Anyone know how i can pass the
                                                                        // whole array of mon into this function then use "for" to check them.

---

i seen a few other posts, i think similar and one said something about vectors and iters, would like a opinion on that please

Code:

---

#include <iostream>
#include <vector>

std::vector<monster> monsters;

void AddMonster(int hps) {
        monster m;
        m.m_hps = hps;

        monsters.push_back(m);
}

void DisplayAll() {
        std::vector<monster>::iterator itr;

        for (itr = monsters.begin(); itr != monsters.end(); ++itr )
                std::cout "This monster's health is: " << itr.m_hps << std::endl;
}
int main() {
        AddMonster(10);
        AddMonster(43);
        AddMonster(25);
        AddMonster(12);

        DisplayAll();

        return 0;
}

---

Code:

---

void displayAllMonsterHealth(monster *mon, size_t size){
  for( int i = 0; i < size; ++i)
    cout << mon[i].m_hps << endl;
}

---

Pass your mon variable for mon, and 4 for size.

And don't listen to nicoqwertyu. No need for global variables here.

Aye, no need for a global. You could refactor DisplayAll() to DisplayAll(const std::vector<monster>& monsters) instead.
I agree with the use of vectors over pointers though.

And I agree with vectors over passing pointer + size.
A vector will basically be your array. Then all your functions can take the vector by reference and it'll all work out a you want.

thanks for your help, i will go and learn to pass my array into my function as a vector, i will look for a tutorial on this but if you have any suggestions of where some "good" tutorials on this are that would be great too.

thanks again

Quote:

---

Originally Posted by morngrym

thanks for your help, i will go and learn to pass my array into my function as a vector, i will look for a tutorial on this but if you have any suggestions of where some "good" tutorials on this are that would be great too.

thanks again

---

Online tutorial are insufficient for learning C++. You really need a book.

The suggestion is not to pass your array as a vector, but to use a vector in place of your array. Nicoqwertyu's code does correctly show how vectors are used. _Mike explains how to declare a function that takes a vector as a reference, so you do not have to use a global.

If you want to use an array, use my code. Note that I fixed an error in it. Principally it's more versatile, since you can pass a vector as a pointer, but not an array as a vector. But vectors are more important to learn than arrays.