Password Checks 3 times Problem

Hey guys I'm a newbie in C programming and I had a hard time trying to figure out whats the problem with my codes:

Code:

---

#include <stdio.h>
#include <string.h>
main()
{
char pass1[20];
char pass2[]= "password";
int i=0;
        do
        {
        i++;
        clrscr();
        printf("Enter Password: ");
        gets(pass1);
        if(strcmp(pass1,pass2)==0)
        printf("Congrats!");
        else
        printf("Invalid Password %i Tries\n");
        }
        while((strcmp(pass1,pass2)!=0 || i!=3);
getche();
}

---

This codes suppose to check password entered if it matches the given. If it is incorrect the loop will not terminate till one of the conditions below is satisfied... Help me out guys... Thanks in advance...

I'm only starting out myself but you may get more suggestions if you say what the error is you are experiencing

You probably want && instead of ||.


Quzah.

Code:

---

#include <stdio.h>
#include <string.h>
main()
{
char pass1[20];
char pass2[]= "password";
int i=0;
        do
        {
        i++;
        clrscr();
        printf("Enter Password: ");
        gets(pass1); //use fgets instead
        if(strcmp(pass1,pass2)==0)
        printf("Congrats!");
        else
        printf("Invalid Password %i Tries\n");
        }
        while((strcmp(pass1,pass2))!=0 && i!=3);
getche();
}

---

Code:

---

printf("Invalid Password %d Tries\n", i);

---

Also, neither getche() or clrscr() is part of stdio.h or string.h, or the C standard for that matter.

Thanks for the immediate response guys... Tried removing the clrscr() and it shows in the execution of the program 1277 tries... Why it exceeds the condition i!=3? Thanks in advance....

I tried it again and the code works now... My question now is how do we clear the screen after the first trial are made? example:

Enter Password: dasdadad //entered incorrect password
Invalid Password 1 Tries //Then Clears the screen after showing the number of tries

Enter Password: //This will show up only 3 times until the correct password or 3 trials are met.


Thanks guys... ^_^

Quote:

---

Originally Posted by jappy512

I tried it again and the code works now... My question now is how do we clear the screen after the first trial are made? example:

Enter Password: dasdadad //entered incorrect password
Invalid Password 1 Tries //Then Clears the screen after showing the number of tries

Enter Password: //This will show up only 3 times until the correct password or 3 trials are met.


Thanks guys... ^_^

---

The screen is cleared so fast you can't see the invalid password message.

The real problem, of course, is that anyone looking, can see what the user is keyboarding in as their password.

The only two ways I know to solve that, are:

1) Include the windows.h header and use the Windows API, and SetConsoleMode() to set the monitor to no echo mode, while the password is being entered (and you can use SetConsoleCursorPosition() also, as you want to).

2) go back to using the DOS style console cursor control and control of the keyboard input to the terminal - getch() gets a key with no echo to the monitor, and gotoxy() will set the cursor to any place on the console window.

It would be good if the password was encrypted on a file, also. :)

There are other ways to do this, but they involve a little bit of another language, not C. Note that while #2 is included, it is not using standard C, and wouldn't be portable with newer compilers.

Thanks to all the reply guys.... It helped me a lot and now the program runs smoothly because of all your suggestions..

Thank You Very Much.. ^_^