Program stopping working

Whenever I run this program, I input a path to the file. Once I hit Enter a box comes up saying
"NumberAnalysis.exe has stopping working
A problem caused the program to stop working correctly.
Windows will close the program and notify you if a solution is available."

I give it a simple .txt file with some numbers separated by a line break.

Code:

---

#include <iostream>
#include <string>
#include <fstream>
#include <vector>
using namespace std;

int getLowest(vector<int> theVector);
int getHighest(vector<int> theVector);
int getTotal(vector<int> theVector);
int getAverage(vector<int> theVector);


vector <int> numArray;

int main(int argc, char *argv[]) {
    string filepath;
    cout<<"Please enter a file path."<<endl;
    cin>>filepath;
    ifstream theFile(filepath.c_str());
    if(!theFile.is_open())
        cout<<"File could not be opened!"<<endl;
    else {
        char x;
        int count = 0;
        while(theFile.get(x)) {
            numArray[count] = (int)x;
            count++;
        }
        cout<<"The lowest number here is "<<getLowest(numArray)<<"."<<endl;
        cout<<"The highest numer here is "<<getHighest(numArray)<<"."<<endl;
        cout<<"The total of the numbers are "<<getTotal(numArray)<<"."<<endl;
        cout<<"The average of the numbers is "<<getAverage(numArray)<<"."<<endl;
    }   
    cin.get();
   
}


int getLowest(vector<int> theVector) {
    int lowest = 100000000;
    for(int i=0;i < theVector.size();i++) {
            if(lowest > theVector[i])
                      lowest = theVector[i];
            }
    return lowest;
}

int getHighest(vector<int> theVector) {
    int highest = 0;
    for(int i=0;i < theVector.size();i++) {
            if(highest < theVector[i])
                      highest = theVector[i];
            }   
    return highest;
}

int getTotal(vector<int> theVector) {
    int total = 0;
    for(int i=0;i < theVector.size();i++)
            total += theVector[i];
    return total;   
}

int getAverage(vector<int> theVector) {
    return (getTotal(theVector) / theVector.size());     
}

---

Any idea as to why this is happening? Or any website I can check out to see the problem?

Also, is there a function for ifstream that I could use to return ints instead of using .get(x) and typecasting to int?

Code:

---

while(theFile.get(x)) {
    numArray[count] = (int)x;
    count++;
}

---

The index's don't magically exist or get created simply because you say so. You need to push_back values onto the vector.

Try debugging (or at least printing hard-coded debug messages) to find out where the program fails.

If you're opening the file as a stream, you should be able to use >> and << to read and write from it.
...or perhaps you should try using numArray.push_back(x); instead of numArray[count] = (int)x;

EDIT: oops, I took forever to write my post, looks like someone beat me :-)

Okay I used the push_back function, but my problem now is how to put ints into the vector.

Code:

---


        while(theFile.get()) {
            numArray.push_back(theFile.get());

---

I tried that but when I input the path file everything just stops until I alt+f4.

Code:

---

        char x;
        while(theFile.get(x)) {
            numArray.push_back((int)x);

---

When I tried that the vector doesn't get filled with the actual numbers in the file. I'm guessing typecasting chars into ints doesn't work so well?

Code:

---

        int x;
        while(theFile.get(x)) {
            numArray.push_back(x);

---

And that doesn't even compile.

I'm looking at the get reference get - C++ Reference
but it isn't making much sense to me.


int get();
Extracts a character from the stream and returns its value (casted to an integer).

I also read that get() returns false if there is nothing to extract which is why I used it for the while loop expression. So now I'm kinda confused on why this says it returns an int and not a bool. Can anyone point me in the right direction here? Any help is appreciated.

Use operator>> to read an int.

Code:

---

while(theFile >> x)

---

Okay I changed the while expression but it's back to telling me the program stopped and is giving me the wrong numbers.

Code:

---

        int x;
        while(theFile >> x) {
            numArray.push_back(x);
        }

---

Code:

---

        int x;
        while(theFile >> x) {
            numArray.push_back(theFile.get());
        }

---

I tried both of these and they give me the same output.

try

Code:

---

while(!theFile.eof())
{
  theFile>>x;
  numArray.push_back(x);
}

---

That method shouldn't work any better, m37h0d, and will usually be worse (by adding a duplicate value at the end). You don't want to use eof() to control the loop.

Your first loop with while(theFile >> x) is correct, SterlingM. The problem is somewhere else in the code. I don't see it at the moment, but I wouldn't change that part right there any more.

Actually, the program works fine for me just by making that change. Maybe you changed something else? Post your latest full code and maybe even the input file text you are using.

the reference says that >> returns ifstream&; does implementing the ! operator provide an implicit conversion to bool?

>> does implementing the ! operator provide an implicit conversion to bool?

There is an implicit conversion to bool, but it's not because of the implementation of operator!. It's because there is a conversion to void* made available by the stream classes and void* converts to bool.

It's not an obvious solution, but it works best when reading from streams.

This is the full code

Code:

---

#include <iostream>
#include <string>
#include <fstream>
#include <vector>
using namespace std;

int getLowest(vector<int> theVector);
int getHighest(vector<int> theVector);
int getTotal(vector<int> theVector);
int getAverage(vector<int> theVector);


vector <int> numArray;

int main(int argc, char *argv[]) {
    string filepath;
    cout<<"Please enter a file path."<<endl;
    cin>>filepath;
    ifstream theFile(filepath.c_str());
    if(!theFile.is_open())
        cout<<"File could not be opened!"<<endl;
    else {
        int x;
        while(theFile >> x) {
            numArray.push_back(theFile.get());
        }
        cout<<"The lowest number here is "<<getLowest(numArray)<<"."<<endl;
        cout<<"The highest numer here is "<<getHighest(numArray)<<"."<<endl;
        cout<<"The total of the numbers are "<<getTotal(numArray)<<"."<<endl;
        cout<<"The average of the numbers is "<<getAverage(numArray)<<"."<<endl;
    }   
    system("PAUSE");
}


int getLowest(vector<int> theVector) {
    int lowest = 100000000;
    for(int i=0;i < theVector.size();i++) {
            if(lowest > theVector[i])
                      lowest = theVector[i];
            }
    return lowest;
}

int getHighest(vector<int> theVector) {
    int highest = 0;
    for(int i=0;i < theVector.size();i++) {
            if(highest < theVector[i])
                      highest = theVector[i];
            }   
    return highest;
}

int getTotal(vector<int> theVector) {
    int total = 0;
    for(int i=0;i < theVector.size();i++)
            total += theVector[i];
    return total;   
}

int getAverage(vector<int> theVector) {
    return (getTotal(theVector) / theVector.size());     
}

---

I was out for a bit so I haven't looked at the while since I left. The input string I give it for the file is always -
C:\Users\Sterling\Testing.txt

When you said it worked after making that change, do you mean the while loop being while(theFile >> x) ? Or are you talking about something else?

>> numArray.push_back(theFile.get());

Oops! You're using the wrong loop. Your first loop with while(theFile >> x) in post #7 was the correct one.

And yes, making that small change makes the program work for me.

Quote:

---

Originally Posted by Daved

>> numArray.push_back(theFile.get());

Oops! You're using the wrong loop. Your first loop with while(theFile >> x) in post #7 was the correct one.

And yes, making that small change makes the program work for me.

---

?

My while loop expression is still the same as in post 7, it is still
while(theFile >> x)

Or are you saying what's inside the loop is wrong? Doesn't get() return an int? I tried doing both assignments that I had in post 7 for inside the while loop and they give me the same output just like they did earlier. I apologize if what I'm missing is obvious, but I'm confused about your post and get().

Quote:

---

Originally Posted by SterlingM

?

My while loop expression is still the same as in post 7, it is still
while(theFile >> x)

Or are you saying what's inside the loop is wrong? Doesn't get() return an int? I tried doing both assignments that I had in post 7 for inside the while loop and they give me the same output just like they did earlier. I apologize if what I'm missing is obvious, but I'm confused about your post and get().

---

You shouldn't need the get call at all. Just push_back the x value you've already read.

Code:

---

while(theFile >> x) {
            numArray.push_back(x);
        }

---

Code:

---

        int x;
        while(theFile >> x) {
            numArray.push_back(x);
        }

---

With this, the program again "stops working" and the outputted numbers are
100000000
0
0

and it doesn't give one for the average. This tells me nothing is being put into the vector or my other functions are wrong.

Code:

---

int getLowest(vector<int> theVector) {
    int lowest = 100000000;
    for(int i=0;i < theVector.size();i++) {
            if(lowest > theVector[i])
                      lowest = theVector[i];
            }
    return lowest;
}

---

Is that function correct? Can you get to specific elements of the vector using [] like arrays?

At this point in your learning, you should be coding one section of code and making sure it works before coding the next.
Comment out everything else. See if you can read the file into the vector and print it out before doing anything else.

>> With this, the program again "stops working" and the outputted numbers are

The code works perfectly for me.

Sorry to make you do this, but please post the whole code again, with the push_back part fixed. Also, please post the contents of your input file. Also, make sure you are completely rebuilding your program and testing the new executable. You might just be running the old one.


>> Can you get to specific elements of the vector using [] like arrays?
Yes. You coded that, didn't you? Wouldn't you already know?

Code:

---

#include <iostream>
#include <string>
#include <fstream>
#include <vector>
using namespace std;

//function prototypes
int getLowest(vector<int> theVector); 
int getHighest(vector<int> theVector);
int getTotal(vector<int> theVector);
int getAverage(vector<int> theVector);


vector <int> numArray;    //the vector to hold the numbers

int main(int argc, char *argv[]) {
    string filepath;
    cout<<"Please enter a file path."<<endl;
    cin>>filepath;
    ifstream theFile(filepath.c_str());    //make an ifstream for the given path
    if(!theFile.is_open())                  //if it couldn't be opened...
        cout<<"File could not be opened!"<<endl; 
    else {
        int x;
        while(theFile >> x) {    //while there is a next int in theFile
            numArray.push_back(x);      //push_back next int onto numArray
        }
        cout<<"The lowest number here is "<<getLowest(numArray)<<"."<<endl;
        cout<<"The highest numer here is "<<getHighest(numArray)<<"."<<endl;
        cout<<"The total of the numbers are "<<getTotal(numArray)<<"."<<endl;
        cout<<"The average of the numbers is "<<getAverage(numArray)<<"."<<endl;
        theFile.close();
    }   
    cin.get();
}

//go through vector and find smaller values
int getLowest(vector<int> theVector) {
    int lowest = 100000000;
    for(int i=0;i < theVector.size();i++) {
            if(lowest > theVector[i])
                      lowest = theVector[i];
            }
    return lowest;
}

//go through vector and find larger values
int getHighest(vector<int> theVector) {
    int highest = 0;
    for(int i=0;i < theVector.size();i++) {
            if(highest < theVector[i])
                      highest = theVector[i];
            }   
    return highest;
}

//get total of all the numbers in the vector
int getTotal(vector<int> theVector) {
    int total = 0;
    for(int i=0;i < theVector.size();i++)
            total += theVector[i];
    return total;   
}

//get the average of all numbers in the vector
int getAverage(vector<int> theVector) {
    return (getTotal(theVector) / theVector.size());     
}

---

This is all that is in the file I give it --

5
10
56
17
18
9


Just some random numbers separated by a line break. Tried not separating them with a line break and got the same results. Also tried just one giant number and got the same results. Whenever it shows the numbers
10000000
0
0
it doesn't give me one for getAverage(). So is something wrong with getAverage()? I also tried putting a cout in the while loop like this --

Code:

---

        while(theFile >> x) {    //while there is a next int in theFile
            cout<<x;
            numArray.push_back(x);      //push_back next int onto numArray
        }

---

And nothing was shown for cout<<x; It just did the same routine of
100000000
0
0
And the program stopped working box.

So you're getting zero entries. It should complain if it can't open the file, but I would double-check the filename that you are using (maybe print it out) -- for sure, if your filename or path contains spaces, you are not going to be able to read it in with >>.

The filename doesn't contain any spaces, it is just C:\Users\Sterling\Testing.txt.
I made some slight changes...

When I made the vector, I didn't have a size for it.

Code:

---

vector <int> numArray;    //the vector to hold the numbers

---

I changed it to hold 6 (that's how many numbers are in my file)

Code:

---

vector <int> numArray(6);    //the vector to hold the numbers

---

When I did this, the "program stopped working" box did not come up. But then I got four zeroes for numbers.


I added a cout into the while loop to see if it is actually looping

Code:

---

        while(theFile >> x) {    //while there is a next int in theFile
            cout<<"test"<<endl;
            numArray.push_back(x);      //push_back next int onto numArray
        }

---

And "test" didn't show one time. So I figured theFile >> x wasn't reading any numbers. So I added an if statement after it to check.

Code:

---

    if(numArray.empty())  {
        cout<<"numArray is empty!!"<<endl;
        }

---

When I ran the program, this message did not show. Just gave me 4 zeroes. So the while loop isn't looping, but the vector isn't empty?

This is the main function now with these little tests(and the change in declaring the vector)

Code:

---

vector <int> numArray(6);    //the vector to hold the numbers

int main(int argc, char *argv[]) {
    string filepath;
    cout<<"Please enter a file path."<<endl;
    cin>>filepath;
    ifstream theFile(filepath.c_str());    //make an ifstream for the given path
    if(!theFile.is_open())                  //if it couldn't be opened...
        cout<<"File could not be opened!"<<endl; 
    else {
        int x;
        while(theFile >> x) {    //while there is a next int in theFile
            cout<<"test"<<endl;
            numArray.push_back(x);      //push_back next int onto numArray
        }
        if(numArray.empty())  {
                  cout<<"numArray is empty!!"<<endl;
              }
        cout<<"The lowest number here is "<<getLowest(numArray)<<"."<<endl;
        cout<<"The highest numer here is "<<getHighest(numArray)<<"."<<endl;
        cout<<"The total of the numbers are "<<getTotal(numArray)<<"."<<endl;
        cout<<"The average of the numbers is "<<getAverage(numArray)<<"."<<endl;
        theFile.close();
    }   
    cin.get();
    cin.ignore();
   
}

---

Everything else is the same.

Well, numArray won't be empty, since you have 6 numbers in it.

Is there something (other than a number) at the start of the file? Once a read error happens, your program will stop.

There are just numbers and line breaks. Not even spaces before the line break. It reads
5
10
56
17
18
9

Then you need to check the path you give your program and compare it to where the file really lives. (The path you told us in the thread could be the right one, although it is somewhat strange for windows.) I will add on to the chorus of "it works here, if you type a file name without spaces".