filling an array

I would like to fill my array with the 40 numbers I generated randomly, but it doesn't seem to be working right. Here is the code:
#include <stdlib.h>
#include <stdio.h>

int main()
{
int i, r, x, ref[39];
unsigned seed;

printf("Enter seed: ");
scanf("%u", &seed);
srand(seed);

for( i=0;i<=39;i++){
printf("%10d", 1 + (rand() % 20));
r= 1 + (rand() % 20);
ref[i]=r;

}
printf("\nref[4] = %d", (ref[4]));
printf("\nThis is the complete ref string\n");
scanf("%d", &i);

return 0;
}

Without actually running your code, I'll take a guess that the problem happens at that last random number.

You say you want to hold 40 random numbers, but you only allocate enough room for 39 in the ref array. Later on, you loop through the array adding random numbers. Unfortunately, there are only 39 places to put these values (0 through 38), but on the last time through you attempt to put a value in rval[39], which does not exist.

Change your declaration of rval to hold 40 integers instead of 39 to give yourself enough room, and modify your for statement to loop through as long as 'i < 40' so that you only hit the valid subscripts of your array.

HTH

I tried your solution and the program acts the same. My problem lies where I try to initialize the array to my random # output. So I guess I need to know how to initialize the array to the numbers being generated randomly.

#include <stdlib.h>
#include <stdio.h>

int main()
{
int i, r, x, ref[39];
unsigned seed;

printf("Enter seed: ");
scanf("%u", &seed);
srand(seed);

for( i=0;i<40;i++){
printf("%10d", 1 + (rand() % 20));

/* THIS IS WHERE I HAVE A PROBLEM
/* HOW DO I SET THE ARRAY TO MATCH MY RANDOM LOOP

r = 1 + (rand() % 20);
r=ref[i];
ref[i]++;

}
printf("%10d", (1+ref[0]%20));
printf("\nThis is the complete ref string\n");
scanf("%d", &i);

return 0;
}

for( i=0;i<40;i++){
r = 1 + (rand() % 20);
printf("%10d", r));
ref[i] = r;
}

Code:

---

for ( i = 0; i < 40; i++ ) {
  ref[i] = 1 + ( rand() % 20 );
  printf ( "%d ", ref[i] );
}

---

-Prelude

Bit of concurrency...

> int rand;

?

Oops, I started with one solution and changed my mind without changing the first part of the code ;)

-Prelude

Don't forget to change:

int i, r, x, ref[39];

to

int i, r, x, ref[40];

now the <40 will work correctly and you'll do 40 instead of 39 random values :)