Simple shell question and more if needed

Code:

---


echo "Enter Name of the first file:"
        read file1
        echo $file1
        if[ ! -f $file1]
                echo "Sorry, file does not exist."
                exit 1

---

I was wondering if someone could tell me why when I pass in a file name (say "txt.txt') it errors out. (txt.txt is located in the same directory from where I execute my script.)


Sorry if its in the wrong forum section.

fixed it. But does anyone understand this error?
"[!: command command not found

First thing: bash is whitespace sensitive. That means this is no good:

Code:

---

if[ ! -f $file1]

---

You want:

Code:

---

if [ ! -f $file1 ]
12345678901234567890

---

Notice, a space at position 3,5,7, and 17. Those all MUST be there. If you use an editor with syntax highlighting for shell scripts (eg, vim), it will be slightly easier to notice that.

But also your syntax is missing some things. Try this:

Code:

---

#!/bin/bash

echo "Enter Name of the first file:"
read file1
echo $file1
        if [ ! -f $file1 ]; then
                echo "Sorry, file does not exist."
                exit 1
        fi

---

Quote:

---

Originally Posted by TaiL

fixed it. But does anyone understand this error?
"[!: command command not found

---

Because your whitespace was wrong. The ! is right up against [, meaning [! was taken as a single token.