Creating class - linker problems

Should this work?

Code:

---

/* .h */

class cPlayer                        //declaration
{
        public:
                float x, y, z;

                cPlayer();        //constructor

};

cPlayer::cPlayer();                //construct

void do_something(cPlayer);

/* .cpp */

cPlayer player;                //instance

player.x=10;                        //assignment

main()
{
        do_something(player)        //pass
}

/* other.cpp - includes same .h */


void do_something(cPlayer &player)
{
        player->y=20;                //use by reference

}

---

The linker can't find the constructor because you've only declared, but not defined, it.

Also, main returns an int.

EDIT:

One more thing. Your declaration for do_something doesn't match it's definition, either.

Quote:

---

Originally Posted by Sebastiani

The linker can't find the constructor because you've only declared, but not defined, it.

---

I tried duplicating the declaration just after it and removed the constructor and gave the floats a value. The compiler says - 'cPlayer' : 'class' type redefinition.

Quote:

---

Also, main returns an int.

---

I was paraphrasing, sorry.

Quote:

---

One more thing. Your declaration for do_something doesn't match it's definition, either.

---

Should the declaration indicate a pointer to cPlayer rather than to a type cPlayer?

>> I tried duplicating the declaration just after it and removed the constructor and gave the floats a value. The compiler says - 'cPlayer' : 'class' type redefinition.

You don't need to duplicate or remove anything - simply define a body for the constructor *somewhere*.

>> Should the declaration indicate a pointer to cPlayer rather than to a type cPlayer?

The declaration indicates that the parameter is to be a temporary (eg: copy of the value passed in), whereas the definition specifies a reference. You need to pick one and stick with it (probably the latter, since you seem to need to make changes to the object).

Quote:

---

Originally Posted by Sebastiani

The declaration indicates that the parameter is to be a temporary (eg: copy of the value passed in), whereas the definition specifies a reference. You need to pick one and stick with it (probably the latter, since you seem to need to make changes to the object).

---

void do_something(cPlayer &player); //declaration
:)

That's it.

I'm assuming you fixed the undefined reference to the constructor, as well, then?

I began by removing it until I could compile cleanly, then I took the assignments collecting in the main .cpp and put them back into a constructor and all seems well.

Code:

---

/* .cpp */

cPlayer player;                //instance

player.x=10;                        //assignment

main()
{
        do_something(player)        //pass
}

---

Does that assignment work for you? It shouldn't... or is this more "paraphrasing"?

No, I wasn't, and I've moved that line (and others like it) to a constructor within the declaration, and I removed the instance names in the process. I can now access the members in that way from within the functions that the class is passed to by reference.