Storing Changing Variables in Array

I am trying to store constantly changing variables into a character array,while communicating over a serial port, and I am not getting the consistency that I need.
Here is the code:

Code:

Code:

---

char str[4];

if(Serial.available())
{
        for(int i=0;i<3;i++)
          {
                  str[i] = Serial.read();
          }
}

---

Is this the best way to read in the variables that I need? I am reading multiple variables at a time,using multiple arrays, which could be two to three digits in length each and are sent next to each other as a whole number. Any help would be greatly appreciated. Thanks.

First of all, if you are reading binary data, you may want to declare your buffer as unsigned char.

Even though your buffer is 4 chars big, you are only reading 3 values into it. Is this intentional?

Quote:

---

Is this the best way to read in the variables that I need?

---

That depends. Does the Serial class have a function which can read more than 1 byte at a time?

Quote:

---

I am reading multiple variables at a time,using multiple arrays

---

What do you mean by this? Are you using multiple threads?

We may need a little more information about what you are attempting to do in order to help further.

Quote:

---

Originally Posted by bithub

First of all, if you are reading binary data, you may want to declare your buffer as unsigned char.

Even though your buffer is 4 chars big, you are only reading 3 values into it. Is this intentional?

That depends. Does the Serial class have a function which can read more than 1 byte at a time?

What do you mean by this? Are you using multiple threads?

We may need a little more information about what you are attempting to do in order to help further.

---

I am only reading up to 3 values into the buffer.
The Serial class only reads 1 byte at a time.
I am using more than one character array to store the different variables which are displayed in a row as one single number.

So the values you are reading are numbers? How are the numbers sent across, is it binary or ascii? How are the numbers separated when they are sent across? In other words, how do you know you've reached the end of a number?

Quote:

---

Originally Posted by bithub

So the values you are reading are numbers? How are the numbers sent across, is it binary or ascii? How are the numbers separated when they are sent across? In other words, how do you know you've reached the end of a number?

---

The values are numbers which are ascii. They are not separated and so I set a limit of three numbers per variable. After that, I was able to determine which numbers were two digits by using:

Code:

---

if(str[2]>0) // if the number is 3 digits or above 100

---

I also used strcmp() in order to determine actions within certain points of a particular variable:

Code:

---

char small[] = "130";
char large[] = "145";
if(strcmp(str,small)>0 && strcmp(str,large)<0)  // Set the window between 130 and 145

---

Ok, I'm going to assume the numbers are separated by a null byte. If that's not the case, then you have a problem.

It sounds like you want to have a function that just gets you a number.

Code:

---

int get_number(void)
{
    char buffer[16];
    int i;
    while(i < sizeof(buffer))
    {
        buffer[i] = Serial.read();
        if(buffer[i] == '\0')
            break; // We reached the end of the number
        i++;
    }
    if(i == sizeof(buffer))
        // Handle error case where we never encountered a null byte
   
    // Now convert the buffer and return it
    return atoi(buffer);
}

---

This will help to encapsulate the serial handling code from the rest of your application.

That worked great, thanks. Now how would I move on to the next number if I was able to space each variable? Or should I read all variables into one array and then sort them?

If the goal is to sort the values, then you have a few options:

1) Place the values in an array, and sort them as you insert them in.
2) Place the values in an array, and sort them once you've gotten all the values.
3) Place the values in a linked list, and sort them as you get them.

Number 1 is the simplest to code.
Number 2 is a little faster than number 1 since you can use a more complex sorting algorithm.
Number 3 is best if you don't know how many values you are getting since lists are variable size whereas arrays are fixed size.

All in all, it's all about which solution makes the most sense to you based on how you want your application to run.

Thank you very much for your responses.