std::getline and cin

hi,
I have this code:

PHP Code:

---

...

string BookName, Author;

cout << "> Enter book title: ";
getline(cin, BookName);                        // this does not work

cout << "> Enter author of book: ";
getline(cin, Author);                            // but this work!?

... 


---

the output is:

Quote:

---

> Enter book title: > Enter author of book:

---

and then waiting for something to write!

I don't know what's wrong? :confused:

Is that ALL of the code?

I suspect you have something like:

Code:

---

int x;
cin >> x;

---

If so, you will need to get rid of the newline that was left behind by cin.

--
Mats

This is part of a class method.
BookName and Author are the attribute of the class!

this is the class:

PHP Code:

---

class Book
{
    public:
        Book();
        Book(string);

        void setBookInfo(void);

        friend void split(Book&, string, const char);

        string    BookName;
        string    Author;
        int        pages;
}; 


---

and this is setBookInfo declaration:

PHP Code:

---

void Book::setBookInfo()
{
    cout << endl << "-------------------------------------------------------------------" << endl
         << "> Enter book title: ";
    getline(cin, BookName);
    cout << "> Enter author of book: ";
    getline(cin, Author);
    cout << "> Enter number of Book pages: ";
    cin >> pages;
    cout << "-------------------------------------------------------------------" << endl << endl;
} 


---

Code:

---

cin >> pages;

---

Hey look! It's cin >> (some integer thing)! You can't mix >> and getline without thinking about it. In this case you may want to use cin.ignore() after the int, or use getline+strtol to read the int as well.

Quote:

---

Originally Posted by tabstop

Code:

---

cin >> pages;

---

Hey look! It's cin >> (some integer thing)! You can't mix >> and getline without thinking about it. In this case you may want to use cin.ignore() after the int, or use getline+strtol to read the int as well.

---

What prize do I get? Can I have a soft toy? ;)

--
Mats

Quote:

---

Originally Posted by tabstop

Code:

---

cin >> pages;

---

Hey look! It's cin >> (some integer thing)! You can't mix >> and getline without thinking about it. In this case you may want to use cin.ignore() after the int, or use getline+strtol to read the int as well.

---

I didn't understand, I don't think it's related to:

Code:

---

cin >> pages;

---

because the first getline didn't work even when I remove cin >> pages; line

Quote:

---

Originally Posted by behzad_shabani

I didn't understand, I don't think it's related to:

Code:

---

cin >> pages;

---

because the first getline didn't work even when I remove cin >> pages; line

---

Is this getline the very first thing you do? You don't, say, have a menu where you have to type 1 to add a book or anything?

And there isn't another cin >> choice to select the "setBookInfo"? Like a menu for example?

--
Mats

Quote:

---

Originally Posted by tabstop

Is this getline the very first thing you do? You don't, say, have a menu where you have to type 1 to add a book or anything?

---

oh yeah!
thanks, it works now ;)
thank you all

I'll just throw in something, too, to show my good intentions.
First off myfunc(void) is the same as myfunc(), so you can drop the "void" part in your class.
And secondly, you are stripping the names of your parameters to your functions. This is bad practice for a number of reasons. More info here: SourceForge.net: Do not remove parameter names - cpwiki

If you're mixing cin >> with getline, a good solution is to always call cin.ignore() after a call to cin >> (but never after a call to getline).